[PHP-DEV] Re: [PHP-CVS] com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt ext/opcache/tests/opt/dce_002.phpt

2017-10-06 Thread Rasmus Lerdorf
On Fri, Oct 6, 2017 at 12:04 PM, Sara Golemon wrote: > On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf > wrote: > > Sara/Remi do you mind if I merge this into 7.2? This affects opcache > debug > > output only and I want to start playing with some DCE reporting from > Phan. > > Having the origina

[PHP-DEV] Re: GitHub and Extensions

2017-10-06 Thread Christoph M. Becker
On 06.10.2017 at 19:26, Will Fitch wrote: > What is the process of closing out pull requests on GitHub for extensions > we maintain? For example: > https://github.com/php/pecl-numbers-bitset/issues/11 - I have no way of > closing that out other than to push a bogus commit with "Fix #11" as the > m

[PHP-DEV] GitHub and Extensions

2017-10-06 Thread Will Fitch
Hi All - What is the process of closing out pull requests on GitHub for extensions we maintain? For example: https://github.com/php/pecl-numbers-bitset/issues/11 - I have no way of closing that out other than to push a bogus commit with "Fix #11" as the message. Is there are grant option for GitH

[PHP-DEV] Re: [PHP-CVS] com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt ext/opcache/tests/opt/dce_002.phpt

2017-10-06 Thread Sara Golemon
On Fri, Oct 6, 2017 at 10:18 AM, Rasmus Lerdorf wrote: > Sara/Remi do you mind if I merge this into 7.2? This affects opcache debug > output only and I want to start playing with some DCE reporting from Phan. > Having the original line numbers available will make that more effective. > > http://gi

[PHP-DEV] Re: [PHP-CVS] com php-src: Add line numbers to Opcache's zend_dump_op() debug output: ext/opcache/Optimizer/zend_dump.c ext/opcache/tests/opt/dce_001.phpt ext/opcache/tests/opt/dce_002.phpt

2017-10-06 Thread Rasmus Lerdorf
Sara/Remi do you mind if I merge this into 7.2? This affects opcache debug output only and I want to start playing with some DCE reporting from Phan. Having the original line numbers available will make that more effective. On Fri, Oct 6, 2017 at 11:03 AM, Rasmus Lerdorf wrote: > Commit:9fe6