Re: [PHP-DEV] fputcsv() and $escape character

2017-09-22 Thread Christoph M. Becker
On 21.09.2017 at 23:08, Dan Ackroyd wrote: > On 21 September 2017 at 12:43, Christoph M. Becker wrote: > >> There are several bug reports regarding "broken" fputcsv() behavior in >> our tracker, namely, because the $escape parameter causes unexpected >> results. For instance: > > I looked at fi

Re: [PHP-DEV] fputcsv() and $escape character

2017-09-22 Thread Andreas Hennings
On Fri, Sep 22, 2017 at 1:20 PM, Christoph M. Becker wrote: >> please make sure the behaviour of common applications, most notably >> Excel, is considered and tested. In my experience it has its own quirks, >> and it's likely that a large proportion of users require >> interoperability with it. It

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread Sara Golemon
>> On Fri, Sep 22, 2017 at 12:21 PM, O'Neil Delpratt wrote: >> I still have the memory leak without that line. I think I was thinking I >> need to add a refcount to the XdmNode object, but maybe I am wrong. >> > The Following gives leak: > > $proc = Saxon/SaxonProcessor > > $xquery = $proc->NewXQ

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread O'Neil Delpratt
The Following gives leak: $proc = Saxon/SaxonProcessor $xquery = $proc->NewXQueryProcessor() $sourceNode = $proc->parseXmlFromString("”); $xquery->setContextItem($sourceNode); // with this line commented out there is no leak. > On 22 Sep 2017, at 17:32, Sara Golemon wrote: > > On Fri, Sep

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread Sara Golemon
On Fri, Sep 22, 2017 at 12:21 PM, O'Neil Delpratt wrote: > I still have the memory leak without that line. I think I was thinking I need > to add a refcount to the XdmNode object, but maybe I am wrong. > What's the shortest possible script you can reproduce the leak with? Is (new XQueryProcessor

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread O'Neil Delpratt
I still have the memory leak without that line. I think I was thinking I need to add a refcount to the XdmNode object, but maybe I am wrong. > On 22 Sep 2017, at 17:09, Sara Golemon wrote: > > On Fri, Sep 22, 2017 at 7:01 AM, O'Neil Delpratt wrote: >> Z_ADDREF_P(oth); >> > It's a little

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread Sara Golemon
On Fri, Sep 22, 2017 at 7:01 AM, O'Neil Delpratt wrote: > Z_ADDREF_P(oth); > It's a little rough staring through all the commented out lines and inconsistent indenting, but this line stands out to me. Where is oth's refcount meant to be decremented? Why is it even being incremented in the

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread O'Neil Delpratt
> On 22 Sep 2017, at 15:40, Johannes Schlüter wrote: > > On Fr, 2017-09-22 at 12:01 +0100, O'Neil Delpratt wrote: >> >> [Fri Sep 22 08:56:42 2017] Script: '/home/ond1/work/svn/latest9.8- >> saxonc/hec/samples/php/xqueryExamples.php' >> /home/ond1/work/svn/latest9.8- >> saxonc/hec/Saxon.C.API

Re: [PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread Johannes Schlüter
On Fr, 2017-09-22 at 12:01 +0100, O'Neil Delpratt wrote: >  > [Fri Sep 22 08:56:42 2017]  Script:  '/home/ond1/work/svn/latest9.8- > saxonc/hec/samples/php/xqueryExamples.php' > /home/ond1/work/svn/latest9.8- > saxonc/hec/Saxon.C.API/php7_saxon.cpp(3250) :  Freeing  [...] > See full code of PHP ext

Re: [PHP-DEV] fputcsv() and $escape character

2017-09-22 Thread Christoph M. Becker
On 21.09.2017 at 20:01, Rowan Collins wrote: > On 21 September 2017 18:32:57 BST, Andreas Hennings > wrote: > >> So empty string would enable the standard behavior RFC 7111 with no >> escape char. >> If so, I support this. > > Just a note regarding standards: Actually, there is no accepted st

[PHP-DEV] PHP extension - Saxon/C

2017-09-22 Thread O'Neil Delpratt
Hi, I am having a problem in my PHP extension and I am wondering if you can give me some advise or even a pointer. We have the following class object XQueryProcessor and XdmNode. The following method takes the XdmNode as parameter: XQueryProcessor.setContextItem(XdmNode) Any idea what is goi

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-22 Thread li...@rhsoft.net
Am 22.09.2017 um 10:21 schrieb Tony Marston: wrote in message news:064eafcb-e42f-cfeb-76f1-e2c5aec0e...@rhsoft.net... Am 19.09.2017 um 11:24 schrieb Tony Marston: If the single character  "ß" represents two "s" characters joined together, then the uppercase equivalent should also be a single

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-22 Thread Tony Marston
wrote in message news:064eafcb-e42f-cfeb-76f1-e2c5aec0e...@rhsoft.net... Am 20.09.2017 um 11:30 schrieb Tony Marston: wrote in message news:098adca8-6897-929d-90e4-cc464f0e2...@rhsoft.net... Am 19.09.2017 um 11:24 schrieb Tony Marston: If the single character "ß" represents two "s" chara