Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension

2017-08-21 Thread Marco Pivetta
Yes, because once it lands in core, it sticks around for almost eternity. On 21 Aug 2017 23:54, "BohwaZ/PHP" wrote: > Le 22/08/2017 07:55, Adam Baratz a écrit : > >> A new method is an API change to me, so an RFC would be warranted. I'm >> reluctant to add driver-specific methods, since that se

[PHP-DEV] Contravariance and the "empty type"

2017-08-21 Thread Andreas Hennings
Hello list, for a while I had this thought about contravariance and an "empty type". I don't expect too much of it, for now I just want to share the idea. Maybe this concept even exists somewhere in a different language, and I am not aware of it. I think it has some overlap with generics, https://

Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension

2017-08-21 Thread Adam Baratz
On Mon, Aug 21, 2017 at 5:54 PM, BohwaZ/PHP wrote: > Le 22/08/2017 07:55, Adam Baratz a écrit : > >> A new method is an API change to me, so an RFC would be warranted. I'm >> reluctant to add driver-specific methods, since that seems opposed to >> PDO's >> driver-agnostic API, but that's not to s

Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension

2017-08-21 Thread BohwaZ/PHP
Le 22/08/2017 07:55, Adam Baratz a écrit : A new method is an API change to me, so an RFC would be warranted. I'm reluctant to add driver-specific methods, since that seems opposed to PDO's driver-agnostic API, but that's not to say we couldn't hash something out. Do we need a RFC every time

Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension

2017-08-21 Thread Adam Baratz
> > I just have proposed a patch to have SQLite3 open_blob feature implemented > in PDO_SQLite: https://github.com/php/php-src/pull/2698 [cross-posted from GitHub] A new method is an API change to me, so an RFC would be warranted. I'm reluctant to add driver-specific methods, since that seems op

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2017-08-20

2017-08-21 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-08-20 19:23:13-07:00 commit: 80745e6 previous commit:e147ef1 revision date: 2017-08-19 21:09:54+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-21 Thread Andrea Faulds
Hi everyone, Nikita Popov wrote: Sounds good to me. Something you might want to consider is to also throw a warning if the floating point number is not an exact integer. For example allow a silent cast of 42.0 to 42, but throw a warning if 42.5 is used as an index (or worse, 42.9, in wh

Re: [PHP-DEV] 7.2.0 beta 3: libtool: Version mismatch error. This is libtool 2.4.6, but the libtool: definition of this LT_INIT

2017-08-21 Thread Remi Collet
Le 20/08/2017 à 20:01, li...@rhsoft.net a écrit : > i saw exactly the same "You should recreate aclocal.m4 with macros from > libtool 2.4.6" with the first alpha tarball while all the time HEAD, 7.0 > and 7.1 are working fine with the same build-spec I have build all alpha/beta of 7.2.0 without an