[PHP-DEV] [RFC] [VOTE] Improve hash_hkdf() parameter

2017-03-24 Thread Yasuo Ohgaki
Hi all, Since hash_hkdf() is in PHP 7.1.2, I start vote from today. Current hash_hkdf() function signature does not make sense. - hash_hkdf() is simple hash_hmac() extension, yet it has totally different signature. - Return value is binary unlike other hash functions. - The signature is in

[PHP-DEV] Re: [RFC][DISCUSSION] Improve hash_hkdf() parameter

2017-03-24 Thread Yasuo Ohgaki
On Sat, Mar 25, 2017 at 6:04 AM, Yasuo Ohgaki wrote: > > This would be final RFC. > > https://wiki.php.net/rfc/improve_hash_hkdf_parameter > > Simpler is better. > I made introduction simpler. > If there aren't comments, I'll start vote in a few days. > I noticed master is merged to 7.1 branch.

[PHP-DEV] GOOD Benchmark Results for PHP Master 2017-03-23

2017-03-24 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-03-23 20:29:51-07:00 commit: 1686183 previous commit:0d834c6 revision date: 2017-03-23 22:50:21+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] Re: [RFC][DISCUSSION] Improve hash_hkdf() parameter

2017-03-24 Thread Yasuo Ohgaki
Hi all, This would be final RFC. https://wiki.php.net/rfc/improve_hash_hkdf_parameter Simpler is better. I made introduction simpler. If there aren't comments, I'll start vote in a few days. Regards, P.S. I really would like to avoid having yet another inconsistent function signature. -- Yasu

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Fleshgrinder
On 3/24/2017 8:15 PM, Niklas Keller wrote: > If PhpToken::getAll() violates the SRP, then Lexer::fromFile() is just the > same sort of violation. > > Regards, Niklas > This is kind of true in PHP, because we are lacking proper abstractions for path and file handling. It is most certainly not tru

Re: [PHP-DEV] [RFC][Discuss] Arrow Functions

2017-03-24 Thread ilija . tovilo
Hi Rowan I see. I still think a simple poll would be useful to choose the least controversial syntax. Otherwise I fear that the RFC might get rejected out of superficial reasons. Regards, Ilija On 7 Feb 2017, 21:07 +0100, Rowan Collins , wrote: > Hi Ilija, > > On 7 February 2017 18:58:15 GMT+0

Re: [PHP-DEV] Re: PHP 7.0 and openssl 1.1

2017-03-24 Thread Jakub Zelenka
Hi, On Sun, Mar 12, 2017 at 10:28 PM, Jakub Zelenka wrote: > Hi, > > On Sun, Mar 12, 2017 at 1:49 PM, Remi Collet > wrote: > >> >> But as said by Rasmus, there is tons of extensions and libraries linked >> >> against openssl, and having both versions loaded in the same process >> can >> >> only

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Niklas Keller
2017-03-24 19:35 GMT+01:00 Fleshgrinder : > On 3/24/2017 4:23 PM, Andrea Faulds wrote: > > Hi Nikita, > > > > Nikita Popov wrote: > > > >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which > >> returns an array of PhpToken objects, rather than the mix of plain > >> strings > >>

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Nikita Popov
On Fri, Mar 24, 2017 at 5:26 PM, Levi Morrison wrote: > On Fri, Mar 24, 2017 at 9:23 AM, Andrea Faulds wrote: > > Hi Nikita, > > > > Nikita Popov wrote: > > > >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which > >> returns an array of PhpToken objects, rather than the mix of

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread guilhermebla...@gmail.com
Thanks Fleshgrinder! You expressed exactly what I thought, but was too busy... cough... lazy to put in an email. Cheers, On Fri, Mar 24, 2017 at 2:35 PM, Fleshgrinder wrote: > On 3/24/2017 4:23 PM, Andrea Faulds wrote: > > Hi Nikita, > > > > Nikita Popov wrote: > > > >> I'd like to add a new T

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Fleshgrinder
On 3/24/2017 4:23 PM, Andrea Faulds wrote: > Hi Nikita, > > Nikita Popov wrote: > >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which >> returns an array of PhpToken objects, rather than the mix of plain >> strings >> and arrays we currently have. The PhpToken class is defined

[PHP-DEV] RE: OpenSSL 1.1 test keys

2017-03-24 Thread Anatol Belski
Hi Jakub, > -Original Message- > From: jakub@gmail.com [mailto:jakub@gmail.com] On Behalf Of Jakub > Zelenka > Sent: Thursday, March 23, 2017 9:19 PM > To: Anatol Belski > Cc: PHP internals list > Subject: Re: OpenSSL 1.1 test keys > > Yep I have been looking a little bit and i

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Levi Morrison
On Fri, Mar 24, 2017 at 9:23 AM, Andrea Faulds wrote: > Hi Nikita, > > Nikita Popov wrote: > >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which >> returns an array of PhpToken objects, rather than the mix of plain strings >> and arrays we currently have. The PhpToken class is

Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread David Rodrigues
Em 24 de mar de 2017 12:24 PM, "Andrea Faulds" escreveu: Hi Nikita, Nikita Popov wrote: I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which > returns an array of PhpToken objects, rather than the mix of plain strings > and arrays we currently have. The PhpToken class is define

[PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()

2017-03-24 Thread Andrea Faulds
Hi Nikita, Nikita Popov wrote: I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which returns an array of PhpToken objects, rather than the mix of plain strings and arrays we currently have. The PhpToken class is defined as: class PhpToken { public $type; public $text;