[PHP-DEV] number_format() = "-0.00"

Hi internals, I've submit a PR (https://github.com/php/php-src/pull/2220) to fix a bug ( https://bugs.php.net/bug.php?id=73581). Kalle suggested I run the change by here to see if there are any concerns or feedback about merging this? Thanks for your time, Craig

Re: [PHP-DEV] Translating optional zval ** with zend_parse_parameters() to PHP 7

Hi Thomas 2016-11-25 4:13 GMT+01:00 Thomas Hruska : > I'm working on updating an extension for PHP 7 compatibility. I have one > function that uses an optional zval ** with zend_parse_parameters(). > > zval **zprevcount = NULL; > int count; > int argc = ZEND_NUM_ARGS(); >

Re: [PHP-DEV] How to handle error in sapi

Hi Zheng 2016-11-25 6:40 GMT+01:00 Zheng Shao : > I'm confused by how to handle an error inside php_apache_sapi_read_post, > shoud I throw a zend_throw_exception or use a global flag for error handling? php_apache_sapi_read_post() is invoked very early on (php_module_startup > sapi_activate > sa

[PHP-DEV] How to handle error in sapi

Hi, I'm working on fix this bug (https://bugs.php.net/bug.php?id=61471) both on PHP-7 and PHP-5.6. The problem is `ap_get_brigade` will return an error when connection timeout happened. in `sapi/apache2handler/sapi_apache2.c`: static int php_apache_sapi_read_post(char *buf, uint count_bytes TS

[PHP-DEV] Translating optional zval ** with zend_parse_parameters() to PHP 7

I'm working on updating an extension for PHP 7 compatibility. I have one function that uses an optional zval ** with zend_parse_parameters(). zval **zprevcount = NULL; int count; int argc = ZEND_NUM_ARGS(); if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|Z", &zp

[PHP-DEV] PHP 5.6.29 RC1 is available for testing

Hello everyone, PHP 5.6.29 RC1 was just released and can be downloaded from: http://downloads.php.net/~tyrael/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer

Re: [PHP-DEV] [RFC] ArrayIterator improvements

Hello PHPeeps, I've updated the RFC! Have a look at it, please! (Sorry for the engrish) Wes 2016-11-23 15:29 GMT+01:00 Wes : > I'm fine with anything as... well, being picky on this won't change the > fact that SPL's design and exceptions are a mess :P > > If you are ok with that, I'm modifying

[PHP-DEV] Deprecate INTL_IDNA_VARIANT_2003

Hi! I've just noticed that ICU has deprecated the IDNA 2003 related functions as of ICU 55[1]. Therefore I suggest that we deprecate INTL_IDNA_VARIANT_2003 as of PHP 7.2, make INTL_IDNA_VARIANT_UTS46 the default as of PHP 8.0(?) (or even remove this parameter?), and remove INT_IDNA_VARIANT_2003 a

Re: [PHP-DEV] C89 vs. C99

On 11/13/2016 02:20 PM, Anatol Belski wrote: moving to C99, we enable a set of new features not available with > the ANSI C, that we need to internalize and accept. Just following up here. Perhaps it was not a good idea to fire a bug report at 7.0.14RC1 but what is done is done. It can always

Re: [PHP-DEV] PHP 7.0.14RC1 is available for testing

You can just enable -std=c99 with gcc I won't be using gcc for this test. to see it doesn't compile. Some amount of work might be needed for > true C99 compat. Oh, I agree. That is fine at this stage. I was merely doing the acid test to see what happened. I'd suggest you to reply to t

RE: [PHP-DEV] PHP 7.0.14RC1 is available for testing

Hi, > -Original Message- > From: Dennis Clarke [mailto:dcla...@blastwave.org] > Sent: Thursday, November 24, 2016 3:09 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] PHP 7.0.14RC1 is available for testing > > On 11/24/2016 06:29 AM, Anatol Belski wrote: > > Hi, > > > > PHP 7.0.

Re: [PHP-DEV] PHP 7.0.14RC1 is available for testing

On 11/24/2016 09:09 AM, Dennis Clarke wrote: On 11/24/2016 06:29 AM, Anatol Belski wrote: Hi, PHP 7.0.14 RC1 was just released and can be downloaded from: Please test it carefully, and report any bugs in the bug system. First pass instantly fails in the configure stage when using a c99 co

Re: [PHP-DEV] PHP 7.0.14RC1 is available for testing

On 11/24/2016 06:29 AM, Anatol Belski wrote: Hi, PHP 7.0.14 RC1 was just released and can be downloaded from: Please test it carefully, and report any bugs in the bug system. I am going to drag it kicking and screaming across a strict C99 compiler inside a strict POSIX environment and se

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-11-24

Results for project PHP master, build date 2016-11-24 06:26:35+02:00 commit: b6068f6 previous commit:ae38b9e revision date: 2016-11-24 01:59:40+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] PHP 7.0.14RC1 is available for testing

Hi, PHP 7.0.14 RC1 was just released and can be downloaded from: https://downloads.php.net/~ab/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to the

[PHP-DEV] Re: VCS Account Request: rkgudboy

Hi! On 24.11.2016 at 06:33, Rohit Kashyap wrote: > Hi, > > Not till now, I am willing to contribute and need guidance to proceed ahead > or any task that I can pick up to get started. See , in particular the "Four Best Ways to Contribute". Pick any you feel com

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-24 9:58 GMT+01:00 Dan Ackroyd : > Hi Levi, > > On 23 November 2016 at 01:25, Levi Morrison wrote: > > > > it assumes that all types that are not statically known to the engine are > > objects. This is a restrictive future compatibility concern. > > Any RFC and/or patch can only deal with

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

Hi Levi, On 23 November 2016 at 01:25, Levi Morrison wrote: > > it assumes that all types that are not statically known to the engine are > objects. This is a restrictive future compatibility concern. Any RFC and/or patch can only deal with PHP as it currently is. > Giving up these options for

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

On 23 November 2016 at 11:07, Marc Bennewitz wrote: > > If I declare a return type of "object" and extends that to return "static" > it doesn't compile because "static" is not a valid return type yet. > Hi Marc, That should be part of a separate RFC, that is focused on making static a valid retu