Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing

2016-07-06 Thread Yasuo Ohgaki
Hi Christoph, On Wed, Jul 6, 2016 at 9:10 PM, Christoph Becker wrote: > > Yes, I am aware that the patch uses php_random_bytes(), but what happens > when it fails, in which case php_session_create_id() returns null[1]? > Would it be impossible to use a session in this case? php_session_create_id

Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing

2016-07-06 Thread Leigh
On Wed, 6 Jul 2016 at 13:10 Christoph Becker wrote: > > Yes, I am aware that the patch uses php_random_bytes(), but what happens > when it fails, in which case php_session_create_id() returns null[1]? > Would it be impossible to use a session in this case? > > [1] > < > https://github.com/php/php

Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing

2016-07-06 Thread Christoph Becker
Hi Yasuo! On 06.07.2016 at 03:51, Yasuo Ohgaki wrote: > > On Wed, Jul 6, 2016 at 12:37 AM, Christoph Becker wrote: >> On 05.07.2016 at 16:32, Leigh wrote: >> >>> On 5 July 2016 at 04:02, Pierre Joye wrote: We can argue about the provided pnrng being CS but it is not php's job to decide

[PHP-DEV] UGLY Benchmark Results for PHP Master 2016-07-06

2016-07-06 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-07-06 06:29:40+03:00 commit: 210b6a2 previous commit:4b9362d revision date: 2016-07-05 16:09:21-05:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC][Vote] ReflectionType Improvements

2016-07-06 Thread Rowan Collins
On 05/07/2016 22:06, Levi Morrison wrote: Compare that to using only if-else for control flow: if ($type->isBuiltin()) { handle_builtin(); } else if ($type instanceof ReflectionClassType) { handle_class($type); } else { handle_undefined($type); } I'd much