[PHP-DEV] Re: Object getter method optimization

Hi Xinchen Hui, The magic get method is not being optimized. This optimization only focuses on simple getter, which is used in a lot of OO-based appoications like Symfony or Drupal. Hi Dimitry, Thanks for reviewing the code, comments are helpful. :) could you explain a little bit of how runtime

Re: [PHP-DEV] Object getter method optimization

HI Yo-An Lin, I added comments to PR. After fixing obvious errors (explained in comments), few tests are still failed tests/classes/unset_properties.phpt Zend/tests/bug52614.phpt The introduced run-time check in ZEND_INIT_METHOD_CALL speed-ups getters in cost of small overhead for all other

Re: [PHP-DEV] [RFC][Voting] Null Coalesce Equal Operator

Le 24/03/2016 16:08, Midori Kocak a écrit : Remember Null coalesce Equal Operator ??= She is in voting phase now. :) https://wiki.php.net/rfc/null_coalesce_equal_operator

Re: [PHP-DEV] Object getter method optimization

I submitted my PR here https://github.com/php/php-src/pull/1847 On Fri, Apr 1, 2016 at 11:41 PM, Lin Yo-An wrote: > Hi internals, > > > Here comes the result: > > Without getter optimization (3 runs): > > 250.76603889465ms > > With getter optimization (3 runs) > > 110.88299751282ms > > > Microbe

Re: [PHP-DEV] Object getter method optimization

Hi internals, Here comes the result: Without getter optimization (3 runs): 250.76603889465ms With getter optimization (3 runs) 110.88299751282ms Microbench result: https://gist.github.com/c9s/0273ac21631562724cabf86c42e86e32 On Fri, Apr 1, 2016 at 4:35 PM, Lin Yo-An wrote: > Hi Dmitry

Re: [PHP-DEV] Object getter method optimization

Hey: On Fri, Apr 1, 2016 at 4:35 PM, Lin Yo-An wrote: > Hi Dmitry, Nikita, Andrea > > > My implementation now is able to get the property offset and fetch object > property directly without invoking zend_std_read_property and pushing new > call frame onto the stack. > > The current behavior: > >

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-04-01

Results for project PHP master, build date 2016-04-01 06:35:45+03:00 commit: c72282a previous commit:44c219b revision date: 2016-03-31 17:10:51+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Object getter method optimization

Hi Dmitry, Nikita, Andrea My implementation now is able to get the property offset and fetch object property directly without invoking zend_std_read_property and pushing new call frame onto the stack. The current behavior: 1. In compile-time, the pass_two() function now marks the getter functio