[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Andrea Faulds
Hi, Nikita Popov wrote: What I mean is, for example: var_dump(~(bool)true); echo "Done\n"; Will throw an exception without opcache, will result in no output (and no *visible* error) with opcache. My point here is that const-operand-only cases might be necessary to handle error cases like this.

Re: [PHP-DEV] segfault in ini_lex() in 7.0.3

2016-03-14 Thread Adam Baratz
> > If you haven't already done so, please file a bug report. The files > uploaded aren't very helpful in terms of diagnosing the issue. > I've dug a little deeper into this. Haven't isolated exactly where the problem's coming from, but I know enough to say the segfault I shared is a side effect

Re: [PHP-DEV] [RFC Discussion] "var" Deprecation

2016-03-14 Thread Björn Larsson
Den 2016-03-14 kl. 19:14, skrev Colin O'Dell: Forcing people to specify a visibility for properties and not for methods would add yet another inconsistency in the language. That's a really good point. However, I think we currently have a different inconsistency: declaring functions without exp

Re: [PHP-DEV] [RFC Discussion] "var" Deprecation

2016-03-14 Thread Fleshgrinder
On 3/14/2016 7:26 PM, James Titcumb wrote: > Yup, agree with this. In my opinion, I'd like to see two birds with one > stone, but a separate RFC is acceptable I suppose. The only risk is one > change getting voted in and not the other, leaving an even worse > inconsistency IMO. I think this RFC sho

Re: [PHP-DEV] [RFC Discussion] "var" Deprecation

2016-03-14 Thread James Titcumb
On 14 Mar 2016 6:14 p.m., "Colin O'Dell" wrote: > > > > > Forcing people to specify a visibility for properties and not for methods > > would add yet another inconsistency in the language. > > > > That's a really good point. Yup, agree with this. In my opinion, I'd like to see two birds with one

Re: [PHP-DEV] [RFC Discussion] "var" Deprecation

2016-03-14 Thread Colin O'Dell
> > Forcing people to specify a visibility for properties and not for methods > would add yet another inconsistency in the language. > That's a really good point. However, I think we currently have a different inconsistency: declaring functions without explicit visibility is possible without need

Re: [PHP-DEV] [RFC Discussion] "var" Deprecation

2016-03-14 Thread Patrick ALLAERT
Le jeu. 10 mars 2016 à 18:15, Colin O'Dell a écrit : > Hello all, > > I have completed my initial draft of the RFC to deprecate "var" in favor of > "public": https://wiki.php.net/rfc/var_deprecation > > I would greatly appreciate any feedback on this RFC, especially with the > following: > > - En

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-03-14

2016-03-14 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-03-14 06:31:10+02:00 commit: 01579ae previous commit:d5cf1a1 revision date: 2016-03-12 08:33:04+09:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-14 Thread Christian Schneider
Am 10.03.2016 um 16:44 schrieb Andrew Brown : > as @Arvids said, var is missing functionality that public has, so they are > not exact aliases of each other. i think this is valid enough reason to > remove it. To me this is reason enough to keep it. If your codebase does not care about visibility

[PHP-DEV] Re: php wiki

2016-03-14 Thread Christoph Becker
Avtandil Kikabidze wrote: > Hi. I am web developer from Georgia, Tbilisi. About me https://longman.me/cv > How I can register on php wiki? I am trying here > https://wiki.php.net/rfc?do=register but I got error: "That wasn't the > answer we were expecting" > Please help me Please read the instruc

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Nikita Popov
On Mon, Mar 14, 2016 at 12:58 PM, Dmitry Stogov wrote: > > > On 03/14/2016 02:29 PM, Nikita Popov wrote: > > On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov wrote: > >> Please take a quick look and let me know if you see any problems. >> >> >> https://gist.github.com/dstogov/23cc318dd3e411904e10

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Dmitry Stogov
On 03/14/2016 02:29 PM, Nikita Popov wrote: On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov > wrote: Please take a quick look and let me know if you see any problems. https://gist.github.com/dstogov/23cc318dd3e411904e10 I'm going to commit this tomorrow.

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Nikita Popov
On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov wrote: > Please take a quick look and let me know if you see any problems. > > > https://gist.github.com/dstogov/23cc318dd3e411904e10 > > > I'm going to commit this tomorrow. > > > Thanks. Dmitry. > ZEND_ADD is not commutative for array operands. Z

[PHP-DEV] Remove useless opcode handlers

2016-03-14 Thread Dmitry Stogov
Please take a quick look and let me know if you see any problems. https://gist.github.com/dstogov/23cc318dd3e411904e10 I'm going to commit this tomorrow. Thanks. Dmitry.