Re: [PHP-DEV] [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Stanislav Malyshev
Hi! > Why? Misconduct is simply the inversion of 'conduct', and a code of > conduct, necessarily, primarily deals with misconduct. Good conduct is > supposed to be what normally happens. It's the exceptions to that - > misconduct - that you need a code to manage. I would disagree with that. If yo

[PHP-DEV] A Modest Code of Conduct Proposal that Almost Everyone Can Agree On

2016-01-22 Thread Scott Arciszewski
Let's start with a rhetorical question: When you are adding unit tests to a legacy code base, where do you start? ... Typically, you start at the extremes and work your way to the core of the application, refactoring as you need to go. I think many people agree that a Code of Conduct, in the abs

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Pádraic Brady
Hi, On 22 January 2016 at 18:15, Chase Peeler wrote: > 1.) I think everyone already knows how to be an adult. The fact that > sometimes we don't act in a civil manner isn't because we don't have > something telling us what civil behavior entails. Putting it in writing > might make us feel good, b

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Chase Peeler
On Fri, Jan 22, 2016 at 2:42 PM John Bafford wrote: > Chase, > > On Jan 22, 2016, at 13:15, Chase Peeler wrote: > > > > 1.) I think everyone already knows how to be an adult. The fact that > > sometimes we don't act in a civil manner isn't because we don't have > > something telling us what civi

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Chase Peeler
On Fri, Jan 22, 2016 at 1:59 PM Alda Marteau-Hardi < php-intern...@leetchee.fr> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hello everyone ! > > It's my first mail here and before writing anything else I'd like to > say that I'm thankful to Anthony and Derick for carrying this R

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread John Bafford
Chase, On Jan 22, 2016, at 13:15, Chase Peeler wrote: > > 1.) I think everyone already knows how to be an adult. The fact that > sometimes we don't act in a civil manner isn't because we don't have > something telling us what civil behavior entails. Putting it in writing > might make us feel goo

[PHP-DEV] Re: Reusing main VM stack for generators

2016-01-22 Thread Bob Weinand
> Am 22.01.2016 um 15:43 schrieb Dmitry Stogov : > > > Hi, > > Could you please, take a look into the PoC. > It's incomplete, but may be you get ideas how to fix this. > > https://gist.github.com/dstogov/285024375d15cacf2a9b > > > Few tes

Re: [PHP-DEV] Re: PDO Close Connection

2016-01-22 Thread Rowan Collins
Gabriel Zerbib wrote on 22/01/2016 13:35: I hear your point, but I think that the problem is mostly similar to the following piece: $fp = fopen('filename', 'w'); fclose($fp); fwrite($fp, 'data'); Sure, but does that mean that PDO should gain a close function, or that the file functi

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Alda Marteau-Hardi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello everyone ! It's my first mail here and before writing anything else I'd like to say that I'm thankful to Anthony and Derick for carrying this RFC. Now… I have one issue with this argument : Chase Peeler a écrit le 22/01/2016 19:15 : > 3.) Fi

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Chase Peeler
I just want to reiterate what I've said a few times before. I'm leaving the points about why I think a Code of Conduct, in general, is a bad idea until the end, in hopes that others will at least read my other points. I don't think there is anything "new" in what I'm saying below either - I'm prett

[PHP-DEV] BAD Benchmark Results for PHP Master 2016-01-22

2016-01-22 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-01-22 06:29:56+02:00 commit: af255c6 previous commit:50c255d revision date: 2016-01-21 21:58:23+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Derick Rethans
On Fri, 22 Jan 2016, Florian Anderiasch wrote: > On 22.01.2016 15:29, Pierre Joye wrote: > > > > Freshly adopted: > > > > http://rubyonrails.org/conduct/ > > https://golang.org/conduct > > > > Ruby (the language) is discussing the adoption of a Code of Conduct > right now, and several people i

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Florian Anderiasch
On 22.01.2016 15:29, Pierre Joye wrote: > > Freshly adopted: > > http://rubyonrails.org/conduct/ > https://golang.org/conduct > Ruby (the language) is discussing the adoption of a Code of Conduct right now, and several people in that thread issue what I think are similar concerns about the word

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Pierre Joye
On Jan 22, 2016 7:03 PM, "Derick Rethans" wrote: Freshly adopted: http://rubyonrails.org/conduct/ https://golang.org/conduct I like both with a very good special mention for the Go one for its clarity and completeness. Cheers,

[PHP-DEV] Reusing main VM stack for generators

2016-01-22 Thread Dmitry Stogov
Hi, Could you please, take a look into the PoC. It's incomplete, but may be you get ideas how to fix this. https://gist.github.com/dstogov/285024375d15cacf2a9b Few tests are failed, because YIELD may be used as expression in nested calls (between INIT_FCALL/DO_FCALL), and the caller functi

Re: [PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Chris Riley
On 22 January 2016 at 14:29, Pierre Joye wrote: > On Jan 22, 2016 7:03 PM, "Derick Rethans" wrote: > > Freshly adopted: > > http://rubyonrails.org/conduct/ > https://golang.org/conduct > > I like both with a very good special mention for the Go one for its clarity > and completeness. > > Cheers,

[PHP-DEV] Re: PDO Close Connection

2016-01-22 Thread Gabriel Zerbib
> > > -- Forwarded message -- > From: Rowan Collins > To: internals@lists.php.net > Cc: > Date: Thu, 21 Jan 2016 19:18:51 + > > > I think the main problem with a close method on something that represents > a resource like a PDO connection object is how the object should behave

Re: [PHP-DEV] Severe safety fail in file access and stream filters

2016-01-22 Thread Umberto Salsi
yohg...@ohgaki.net (Yasuo Ohgaki) wrote: > > Plain file stream reads data by php_stdiop_read() > > > > http://lxr.php.net/xref/PHP_5_6/main/streams/plain_wrapper.c#338 > > > > As you can see there is no way to return errors from it. We need > > errno like error handling for PHP streams to propagat

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-22 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 22/01/2016 11:38, Remi Collet a écrit : > Reproducer attached > > It seems that using a user land SessionHandler, the "write" method > is not called, raising this issue. Attached as .phpt Notice: the issue only happens after the: PHP Warning: s

[PHP-DEV] Re: [RFC] [Re-proposed] Adopt Code of Conduct

2016-01-22 Thread Derick Rethans
Hi, Sorry, this turned out to be longer than I wanted. First of all, thanks for all your comments, well wishes and suggestions. I can't possibly reply to all of them individually, but I think the main take aways are below. I deliberately left out names. - Putting a document to collaborate on o

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-22 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reproducer attached It seems that using a user land SessionHandler, the "write" method is not called, raising this issue. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEA

Re: [PHP-DEV] Handling of withdrawn RFCs

2016-01-22 Thread Derick Rethans
On Thu, 21 Jan 2016, Flyingmana wrote: > On 01/21/2016 09:53 PM, Ronald Chmara wrote: > > > On Thu, Jan 21, 2016 at 12:33 PM, Flyingmana > > wrote: > >> An RFC could still be valuable for the project, even if the original > >> author leaved, so taking it over should be possible. And it should n

[PHP-DEV] PHP 5.6.18 RC1 is available for testing

2016-01-22 Thread Ferenc Kovacs
Hello everyone, PHP 5.6.18 RC1 was just released and can be downloaded from: http://downloads.php.net/~tyrael/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-22 Thread Remi Collet
Le 21/01/2016 23:07, Yasuo Ohgaki a écrit : > Patch for fixing BC would be this, if I'm correct about the cause. > > e8f1c29cc96ce333fa808aba126297b77d94abdf (main patch) > 57be57ac94ef46fa7a73889a1e7d6e75aa4ab00f (TSRM fix for PHP 5.6) > > I appreciate if you could run tests without these pat

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

2016-01-22 Thread Anatol Belski
Hi, > -Original Message- > From: Remi Collet [mailto:r...@fedoraproject.org] > Sent: Thursday, January 21, 2016 5:20 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - BC break > *** > + /usr/bin/php -d > include_path=.:/builddir/build/