[PHP-DEV] One last ldap_connect headache

2015-11-03 Thread Côme Chilliet
I got mail from someone saying that in previous version, calling ldap_connect($host, NULL) would use default port. While now it is considered as trying to use port 0 and trigger an error. I’m a bit troubled about it because the documentation says: resource ldap_connect ([ string $hostname = NULL

[PHP-DEV] Fixing ldap_connect documentation

2015-11-03 Thread Côme Chilliet
Hello, About ldap_connect documentation, we got an interesting proposition there: https://github.com/owncloud/core/issues/20020#issuecomment-153387886 The idea is to documment the LDAP URI version as a default and only list the host, port syntax as a backward compatibilty thing. Which it is IMO.

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-03 Thread Côme Chilliet
Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a écrit : > I'd argue this is a regression, documented feature or not. Supporting > 'host:port' is not a bug, and this has broken existing code, which micro > (x.y.Z) versions are not allowed to do. It should be fixed ASAP. So I got two votes agai

Re: [PHP-DEV] Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

2015-11-03 Thread Bob Weinand
Hey, zend_vm_execute.h is an auto-generated file, via zend_vm_gen.php. In reality the patch only fixes the code in exactly one location (zend_vm_def.h) and then regenerated zend_vm_execute.h. Bob > Am 04.11.2015 um 03:10 schrieb Paul Dragoonis : > > Hey, > > Looking at the patch, the changes

Re: [PHP-DEV] Re: Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

2015-11-03 Thread Paul Dragoonis
Hey, Looking at the patch, the changes to zend_vm_def.h and zend_vm_execute.h are duplicated in 10 locations. I'm wondering if we can consolidate this into maintainable function/macro to handle this? On Wed, Nov 4, 2015 at 1:58 AM, Xinchen Hui wrote: > Hey: > > > > On Wed, Nov 4, 2015 at 3:58 A

[PHP-DEV] Re: Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

2015-11-03 Thread Xinchen Hui
Hey: On Wed, Nov 4, 2015 at 3:58 AM, Dmitry Stogov wrote: > Hi, > > I think, I found the root problem of https://bugs.php.net/bug.php?id=70805 > > unset($a) or unser($GLOBAL["a"]) triggered GC and destructors calls that > tried to release the same global variable $a once again. As result it's

Re: [PHP-DEV] [RFC][DISCUSSION] Trailing commas in all list syntax

2015-11-03 Thread Bishop Bettini
On Tue, Nov 3, 2015 at 2:22 PM, Sammy Kaye Powers wrote: > The RFC to allow trailing commas to function calls & declarations has been > withdrawn in favor of the a RFC that broadens the scope to all list syntax. > > https://wiki.php.net/rfc/list-syntax-trailing-commas > > The RFC to allow trailin

[PHP-DEV] Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

2015-11-03 Thread Dmitry Stogov
Hi, I think, I found the root problem of https://bugs.php.net/bug.php?id=70805 unset($a) or unser($GLOBAL["a"]) triggered GC and destructors calls that tried to release the same global variable $a once again. As result it's reference counter was decremented twice and this caused use-after-free,

Re: [PHP-DEV] Small regression in PHP-LDAP

2015-11-03 Thread Andreas Heigl
Am 03.11.15 um 20:07 schrieb Andrea Faulds: > Hi Andreas, > > Andreas Heigl wrote: >> +1 on that solution. Just throwing "host:port" onto something doesn't >> help anyone. Try that with "www.google.com:443" in your favourite >> browser. Most will give you an error (if it's not port 80). So those >

[PHP-DEV] [RFC][DISCUSSION] Trailing commas in all list syntax

2015-11-03 Thread Sammy Kaye Powers
Hey internals! The RFC to allow trailing commas to function calls & declarations has been withdrawn in favor of the a RFC that broadens the scope to all list syntax. https://wiki.php.net/rfc/list-syntax-trailing-commas The RFC to allow trailing commas for all lists is now open for discussion. :)

Re: [PHP-DEV] Small regression in PHP-LDAP

2015-11-03 Thread Andrea Faulds
Hi Andreas, Andreas Heigl wrote: +1 on that solution. Just throwing "host:port" onto something doesn't help anyone. Try that with "www.google.com:443" in your favourite browser. Most will give you an error (if it's not port 80). So those people that try it will eventually read the documentation

[PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-03 Thread Andrea Faulds
Hi Côme, Côme Chilliet wrote: The use of ldap_connect(host:port) without ldap:// is not something that is in the tests, and is not explicitely allowed by our documentation: http://php.net/manual/en/function.ldap-connect.php I don't use LDAP, so maybe it's different here, but accepting both

Re: [PHP-DEV] Re: Make sessions use php_random_bytes in 7.1

2015-11-03 Thread Sammy Kaye Powers
On Sun, Nov 1, 2015 at 2:02 PM, Tom Worster wrote: > On 11/1/15, 12:40 PM, "Leigh" wrote: > > >On 1 November 2015 at 16:07, Tom Worster wrote: > > > > > >I don't have one. > > > >But if I may ask, I'm curious, as always: What happens in the case that > >php_random_bytes() fails? > > > >Tom > >

Re: [PHP-DEV] Small regression in PHP-LDAP

2015-11-03 Thread Andreas Heigl
Am 03.11.15 um 15:23 schrieb Bishop Bettini: > On Tue, Nov 3, 2015 at 12:03 AM, Côme Chilliet wrote: > >> So basically my question is, is that something that should be "fixed" to >> be consistent with previous PHP version, or should it stay that way as this >> is what is documented and tested? >>

Re: [PHP-DEV] Small regression in PHP-LDAP

2015-11-03 Thread Bishop Bettini
On Tue, Nov 3, 2015 at 12:03 AM, Côme Chilliet wrote: > So basically my question is, is that something that should be "fixed" to > be consistent with previous PHP version, or should it stay that way as this > is what is documented and tested? > An equivalent question: Do you want to support this

[PHP-DEV] Benchmark Results for PHP Master 2015-11-03

2015-11-03 Thread lp_benchmark_robot
Results for project PHP master, build date 2015-11-03 05:26:18+02:00 commit: a79a504b6da0f1a9420f4611e2a23f46f348f722 revision date: 2015-11-02 16:43:52+08:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB mem

Re: [PHP-DEV] [Question] Variadic method signature compatibility between 5.6 and 7.0

2015-11-03 Thread Rowan Collins
Rowan Collins wrote on 03/11/2015 09:20: That's not equivalent, because the version with no arguments explicitly prohibits zero arguments, which the variadic signature doesn't. Sorry, this should read "the version with no arguments explicitly prohibits passing one argument". -- PHP Interna

Re: [PHP-DEV] [Question] Variadic method signature compatibility between 5.6 and 7.0

2015-11-03 Thread Rowan Collins
Marc Bennewitz wrote on 02/11/2015 19:44: Hi Rowan, On 11/02/2015 05:41 PM, Rowan Collins wrote: Alexander Lisachenko wrote on 02/11/2015 11:12: First definition declares exactly one single parameter, which can be absent during the method call, so I can even write public static function test