Re: [PHP-DEV] Port random_bytes to PHP 5

2015-10-12 Thread Larry Garfield
On 10/12/2015 07:29 PM, Tom Worster wrote: Could we regard random_bytes() as a security patch rather than a new feature and therefore port it to PHP 5? Error handling would have to change but that should be feasible. Iirc, earlier commits of random_bytes() had PHP 5-like behavior on error. My m

Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Xinchen Hui
Hey: On Tue, Oct 13, 2015 at 6:12 AM, Anatol Belski wrote: > > > > -Original Message- > > From: Nikita Popov [mailto:nikita@gmail.com] > > Sent: Monday, October 12, 2015 10:33 PM > > To: Anatol Belski > > Cc: Dmitry Stogov ; PHP internals < > internals@lists.php.net> > > Subject: Re

[PHP-DEV] Port random_bytes to PHP 5

2015-10-12 Thread Tom Worster
Could we regard random_bytes() as a security patch rather than a new feature and therefore port it to PHP 5? Error handling would have to change but that should be feasible. Iirc, earlier commits of random_bytes() had PHP 5-like behavior on error. My motivation: it's easier to defend abandoning O

RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Anatol Belski
> -Original Message- > From: Dmitry Stogov [mailto:dmi...@zend.com] > Sent: Monday, October 12, 2015 11:55 PM > To: Nikita Popov > Cc: Anatol Belski ; PHP internals > > Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by > ReflectionFunctionAbstract::getClosure() >

RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Anatol Belski
> -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Monday, October 12, 2015 10:33 PM > To: Anatol Belski > Cc: Dmitry Stogov ; PHP internals > Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by > ReflectionFunctionAbstract::getClosure()

Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Dmitry Stogov
On Mon, Oct 12, 2015 at 11:32 PM, Nikita Popov wrote: > On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski > wrote: > >> Hi, >> >> > -Original Message- >> > From: Nikita Popov [mailto:nikita@gmail.com] >> > Sent: Monday, October 12, 2015 8:57 PM >> > To: Dmitry Stogov >> > Cc: PHP inte

Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Nikita Popov
On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski wrote: > Hi, > > > -Original Message- > > From: Nikita Popov [mailto:nikita@gmail.com] > > Sent: Monday, October 12, 2015 8:57 PM > > To: Dmitry Stogov > > Cc: PHP internals ; Andrea Faulds ; > Stas > > Malyshev ; Bob Weinand ; > > Anat

RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Anatol Belski
Hi, > -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Monday, October 12, 2015 8:57 PM > To: Dmitry Stogov > Cc: PHP internals ; Andrea Faulds ; Stas > Malyshev ; Bob Weinand ; > Anatol Belski > Subject: [PHP-DEV] Re: Forbid rebinding scope of closures creat

[PHP-DEV] Scalar type hints and scalar type name aliases cause confuson

2015-10-12 Thread Andrea Faulds
Hi, As PHP 7 currently is, if you write this: public function foo(): integer { return 12; } $bar = foo(); you'll get the following error: Fatal error: Uncaught TypeError: Return value of foo() must be an instance of integer, integer returned Similarly, if you were to

[PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Nikita Popov
On Mon, Oct 12, 2015 at 8:24 PM, Dmitry Stogov wrote: > Hi Nikita, > > I think the effect of the remaining patch is negligible. > It disables things, that shouldn't work by design, didn't work in fact and > leaded to crashes. > It might work only in some cases and only because of luck. > > So, I

[PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

2015-10-12 Thread Dmitry Stogov
Hi Nikita, I think the effect of the remaining patch is negligible. It disables things, that shouldn't work by design, didn't work in fact and leaded to crashes. It might work only in some cases and only because of luck. So, I think it's better to commit this before next RC. Anatol is going to st

[PHP-DEV] Benchmark Results for PHP Master 2015-10-12

2015-10-12 Thread lp_benchmark_robot
Results for project php-src-nightly, build date 2015-10-12 05:12:45+03:00 commit: 8d12ff75132644006b394ab02c37944c48d6a920 revision_date: 2015-10-11 12:08:34-03:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Re: Windows OpCache bug fix

2015-10-12 Thread Dmitry Stogov
Anatol committed a better fix. It falls back to file-cache in case of failure, and maps just a small portion of SHM for synchronization between processes. In general, extending this approach, we may map the whole SHM segment into different address space and implement routines to find/load data from