[PHP-DEV] RE: [PHP-CVS] com php-src: fix typo: Zend/zend_range_check.h

2015-08-26 Thread Anatol Belski
Hi Matt, > -Original Message- > From: Matt Wilmas [mailto:php_li...@realplain.com] > Sent: Wednesday, August 26, 2015 5:22 PM > To: Anatol Belski ; php-...@lists.php.net > Cc: internals@lists.php.net > Subject: Re: [PHP-CVS] com php-src: fix typo: Zend/zend_range_check.h > > Hi Anatol :-)

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Lester Caine
On 26/08/15 20:02, Stanislav Malyshev wrote: >> Just because there is a function, which does not exactly roll off the >> > tongue (plus the fun of the needle/haystack ordering issue), does not >> > mean it gets used (even if it is the correct thing to use). > As it looks to me, in order to fix the

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Stanislav Malyshev
Hi! > Just because there is a function, which does not exactly roll off the > tongue (plus the fun of the needle/haystack ordering issue), does not > mean it gets used (even if it is the correct thing to use). As it looks to me, in order to fix the fact that people are not using existing function

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Bishop Bettini
On Tue, Aug 25, 2015 at 11:09 PM, Scott Arciszewski wrote: > Would anyone be interested in adding another helper like > isset()/empty() simply called exists() which would return true if the > variable is defined in the current scope (i.e. without raising an > E_NOTICE)? > Agree with Rowan as he

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Rowan Collins
Craig Francis wrote on 26/08/2015 18:07: I provide examples to help explain that I (and I suspect most developers) default to using isset which works on either. Just because there is a function, which does not exactly roll off the tongue (plus the fun of the needle/haystack ordering issue), do

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread James Gilliland
On Wed, Aug 26, 2015 at 12:07 PM, Craig Francis wrote: > > On 26 Aug 2015, at 16:06, Rowan Collins wrote: > > > Craig Francis wrote on 26/08/2015 14:53: > >> On 26 Aug 2015, at 12:36, Rowan Collins > wrote: > >> > > >> where NULL may be a perfectly valid value. > > > > It's not that NULL isn'

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Ryan Pallas
On Wed, Aug 26, 2015 at 11:08 AM, Craig Francis wrote: > On 26 Aug 2015, at 16:44, Stanislav Malyshev wrote: > > >> Depending on the website I may then add a key to define the > >> 'report-uri', or I may set it to NULL to say that I don't want one. > > > > NULL is not the best value to for this,

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Craig Francis
On 26 Aug 2015, at 16:44, Stanislav Malyshev wrote: >> Depending on the website I may then add a key to define the >> 'report-uri', or I may set it to NULL to say that I don't want one. > > NULL is not the best value to for this, but the function you're looking > for is array_key_exists(). Wh

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Craig Francis
On 26 Aug 2015, at 16:06, Rowan Collins wrote: > Craig Francis wrote on 26/08/2015 14:53: >> On 26 Aug 2015, at 12:36, Rowan Collins wrote: >> >>> Fortunately, the function you are looking for already exists: >>> http://php.net/array_key_exists >> It does, although I seem to have edited that

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Stanislav Malyshev
Hi! > Depending on the website I may then add a key to define the > 'report-uri', or I may set it to NULL to say that I don't want one. NULL is not the best value to for this, but the function you're looking for is array_key_exists(). -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PH

[PHP-DEV] Re: [PHP-CVS] com php-src: fix typo: Zend/zend_range_check.h

2015-08-26 Thread Matt Wilmas
Hi Anatol :-), Just wanted to point out that those conditions (non-0 macros, of course) should use UNEXPECTED(), so their code block can be moved "out of the way." (May already be happening with a "return" involved.) Although now, IF php_error_docref is involved, that *should* implicitly hap

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Rowan Collins
Craig Francis wrote on 26/08/2015 14:53: On 26 Aug 2015, at 12:36, Rowan Collins wrote: Fortunately, the function you are looking for already exists: http://php.net/array_key_exists It does, although I seem to have edited that out of my reply... was trying to keep it short ;-) You could h

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Craig Francis
On 26 Aug 2015, at 12:36, Rowan Collins wrote: > Fortunately, the function you are looking for already exists: > http://php.net/array_key_exists It does, although I seem to have edited that out of my reply... was trying to keep it short ;-) At the moment I'm out of examples (bit busy at the

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Rowan Collins
Craig Francis wrote on 26/08/2015 12:23: If you want some example of where I got this wrong... I have a config array [...] When creating a URL builder that allowed the query string to be passed in as an array [...] Neither were major problems, just a slight annoyance (i.e. identified and fix

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Craig Francis
On 26 Aug 2015, at 05:36, Stanislav Malyshev wrote: > >> Would anyone be interested in adding another helper like >> isset()/empty() simply called exists() which would return true if the >> variable is defined in the current scope (i.e. without raising an >> E_NOTICE)? > > Not sure what the use

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

2015-08-26 Thread Niklas Keller
Hi Björn, > Ah yes, then a set_throwable_handler would be needed. A final question: > Would it be an alternative to update set_error_handler to also handle > \Throwable\Error\* > exceptions and let set_exception_handler catching same type of exceptions > like > in PHP 5? > set_error_handler han

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

2015-08-26 Thread Björn Larsson
Den 2015-08-20 kl. 19:11, skrev Stanislav Malyshev: Hi! Hm... But isn't then the safe route to revert set_exception_handler to old behaviour and take the rest in 7.1? I mean depending on size of problems it takes It's not that safe if set_exception_handler is used as "handler of last resort".

Re: [PHP-DEV] Notice on non existing array key (on a boolean)

2015-08-26 Thread AllenJB
I've added an explicit set of tests for object properties and function return values and they're passing for me (I also updated the branch to current master and updated the tests to handle Engine Exceptions). The build passes on my branch, but 1 failed on the PR and I can see no way to request

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-08-26 Thread Rowan Collins
Scott Arciszewski wrote on 26/08/2015 04:09: Hi everybody, Would anyone be interested in adding another helper like isset()/empty() simply called exists() which would return true if the variable is defined in the current scope (i.e. without raising an E_NOTICE)? My answer to this would be a ve

[PHP-DEV] Benchmark Results for PHP Master 2015-08-26

2015-08-26 Thread lp_benchmark_robot
Results for project php-src-nightly, build date 2015-08-26 05:00:00+03:00 commit: 25f9e255264d8196f51a22707e797977e4cd3995 revision_date:2015-08-26 03:27:05+03:00 environment: Haswell-EP cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB