Re: [PHP-DEV] C++ Extensions

Hi! > A) Adding those defines prior to including stdint.h > B) Expecting C++ ext devs to define those before including php.h > C) Modifying zend_long.h to use things like > std::numeric_limits() when __cplusplus is defined > > A may (potentially) have unexpected side-effects > B has precedent (se

[PHP-DEV] C++ Extensions

PHP7's 64bit support in Zend/zend_long.h uses INT64_MIN/MAX as well as INT64_C/INT32_C concat macros. In C++, these are only defined if __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS has been set prior to including stdint.h A C++ extension developer could deal with this by defining those prior to

Re: [PHP-DEV] set_exception_handler catches all Throwables

Stas and all, On Wed, Aug 19, 2015 at 2:45 PM, Stanislav Malyshev wrote: > Hi! > >> Actually, I don't call this intended. This is just as much as a BC break >> as the original implementation where Errors where also Exceptions. IMO, >> set_exception_handler() should be changed - with my preference

Re: [PHP-DEV] set_exception_handler catches all Throwables

Hi! > Actually, I don't call this intended. This is just as much as a BC break > as the original implementation where Errors where also Exceptions. IMO, > set_exception_handler() should be changed - with my preference it not > capturing Error, and instead have an additional set_throwable_handle

Re: [PHP-DEV] set_exception_handler catches all Throwables

Hi! > We're trying to use TYPO3 on PHP7 and have the problem that throwables > get passed to the exception handler because 'set_exception_handler()' > does send all throwables to the handler, not only exceptions. Why this is a problem for TYPO3? How they use set_exception_handler() that catching

Re: [PHP-DEV] set_exception_handler catches all Throwables

On 19 August 2015 at 07:20, Björn Larsson wrote: > Den 2015-08-19 kl. 15:55, skrev Ryan Pallas: >> I agree with this completely. I think the point here is that >> catch(Exception $e) remains unchanged while setting a handler actually >> catches more things now. Tbh I feel like this is an oversight

RE: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

Hi, > -Original Message- > From: Sebastian Bergmann [mailto:sebast...@php.net] > Sent: Wednesday, August 19, 2015 4:21 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in > main/php_version.h > > Am 19.08.2015 um 16:09 schrieb N

Re: [PHP-DEV] Re: Marking error, etc. functions as cold?

Hi Matt, On Wed, Aug 19, 2015 at 4:05 PM, Matt Wilmas wrote: > Hi Dmitry, > > - Original Message - > From: "Dmitry Stogov" > Sent: Monday, August 17, 2015 > > This is good idea. >> Some times ago I played with "hot" attribute, and didn't get any >> improvement, but we really may get some

Re: [PHP-DEV] Recap - Core functions throwing exceptions in PHP7

Ah, I didn't realize this thread existed. I had just commented on the old one, but the point still stands: PHP 7.0 RC1 was just tagged. Shouldn't this be a relatively high priority to fix/decide so we don't end up with behavior that can't be fixed until PHP 8.0? On Mon, Aug 10, 2015 at 6:54 PM Ni

Re: [PHP-DEV] Core functions throwing exceptions in PHP7

PHP 7.0 RC1 was just tagged. Shouldn't this be a relatively high priority to fix/decide so we don't end up with behavior that can't be fixed until PHP 8.0? On Sat, Aug 1, 2015 at 6:16 PM Scott Arciszewski wrote: > On Sat, Aug 1, 2015 at 6:37 AM, Nikita Popov wrote: > > tl;dr: This should defini

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

Den 2015-08-19 kl. 16:09, skrev Niklas Keller: It surely won't be the last one. I am not keen to keep adding or changing things like that at this stage, given the tough timeline. Yeah, there are quite some topics yet which unfortunately cannot be resolved properly in the given time frame till

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

Am 19.08.2015 um 16:09 schrieb Niklas Keller: > TBH, I'd rather take the time and have a delayed release without a hurry > than shipping a final version with unresolved problems. Having a schedule > to follow is nice, but you should rethink the schedule when problems arise > instead of following it

Re: [PHP-DEV] set_exception_handler catches all Throwables

Den 2015-08-19 kl. 15:55, skrev Ryan Pallas: On Aug 19, 2015 6:44 AM, "Björn Larsson" > wrote: > > Plan to migrate to PHP 7 later, like the new Exception/Error way > of working very much. Point is that current set_exception_handler > only address exceptions, n

Re: [PHP-DEV] set_exception_handler catches all Throwables

> > I agree with this completely. I think the point here is that > catch(Exception $e) remains unchanged while setting a handler actually > catches more things now. Tbh I feel like this is an oversight in > implementing the Error/Throwable rfc and should be addressed now, otherwise > it can't be ch

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

> > > It surely won't be the last one. I am not keen to keep adding or > changing things > > like that at this stage, given the tough timeline. > > Yeah, there are quite some topics yet which unfortunately cannot be > resolved properly in the given time frame till 7.0 final. With regard to > that,

Re: [PHP-DEV] set_exception_handler catches all Throwables

On Aug 19, 2015 6:44 AM, "Björn Larsson" wrote: > > Plan to migrate to PHP 7 later, like the new Exception/Error way > of working very much. Point is that current set_exception_handler > only address exceptions, not errors. You are right that on that the > surface it's the same callback, but could

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

Den 2015-08-19 kl. 15:18, skrev Anatol Belski: -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Wednesday, August 19, 2015 10:19 AM To: Sebastian Bergmann Cc: PHP internals Subject: Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_v

RE: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

> -Original Message- > From: Pierre Joye [mailto:pierre@gmail.com] > Sent: Wednesday, August 19, 2015 10:19 AM > To: Sebastian Bergmann > Cc: PHP internals > Subject: Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in > main/php_version.h > > On Aug 19, 2015 12:11

Re: [PHP-DEV] Re: Marking error, etc. functions as cold?

Hi Dmitry, - Original Message - From: "Dmitry Stogov" Sent: Monday, August 17, 2015 This is good idea. Some times ago I played with "hot" attribute, and didn't get any improvement, but we really may get something with "cold". It was cool to hear that. :-) I just noticed the changes y

Re: [PHP-DEV] set_exception_handler catches all Throwables

Plan to migrate to PHP 7 later, like the new Exception/Error way of working very much. Point is that current set_exception_handler only address exceptions, not errors. You are right that on that the surface it's the same callback, but could eg be logging in different ways and to different recipien

[PHP-DEV] Benchmark Results for PHP Master 2015-08-19

Results for project php-src-nightly, build date 2015-08-19 05:00:00+03:00 commit: 9047b567e346841ee73fcef27a33d609d438df69 revision_date:2015-08-19 10:42:53+10:00 environment: Haswell-EP cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] set_exception_handler catches all Throwables

What do you guys do in the set_exception_handler callback? Wouldn't most code just use the same callback and just log the error / exception? Regards, Niklas 2015-08-19 11:55 GMT+02:00 Björn Larsson : > Den 2015-08-19 kl. 10:52, skrev Peter Cowburn: > >> On 17 August 2015 at 15:24, Sebastian Berg

Re: [PHP-DEV] Adding phpdbg_webhelper to .gitignore

> Am 19.08.2015 um 01:46 schrieb Christopher Jones > : > On 12/08/2015 11:31 pm, Ferenc Kovacs wrote: >> >> On Wed, Aug 12, 2015 at 1:55 PM, Christopher Jones >> mailto:christopher.jo...@oracle.com>> wrote: >> >> >>Bob, >> >>Is the ext/phpdbg_webhelper sym link really needed ? If so,

Re: [PHP-DEV] set_exception_handler catches all Throwables

Den 2015-08-19 kl. 10:52, skrev Peter Cowburn: On 17 August 2015 at 15:24, Sebastian Bergmann wrote: Am 17.08.2015 um 16:00 schrieb Derick Rethans: Actually, I don't call this intended. This is just as much as a BC break as the original implementation where Errors where also Exceptions. IMO,

Re: [PHP-DEV] set_exception_handler catches all Throwables

On 17 August 2015 at 15:24, Sebastian Bergmann wrote: > Am 17.08.2015 um 16:00 schrieb Derick Rethans: > > Actually, I don't call this intended. This is just as much as a BC break > > as the original implementation where Errors where also Exceptions. IMO, > > set_exception_handler() should be cha

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: bump versions: configure.in main/php_version.h

On Aug 19, 2015 12:11 PM, "Sebastian Bergmann" wrote: > > Am 18.08.2015 um 19:07 schrieb Anatol Belski: > > Do you have some impregnable issue in mind preventing to do this? > > Hm, maybe: what about the need for set_throwable_handler() that was > recently raised as a topic? It surely won't be