[PHP-DEV] Re: com php-src: Fixed tests(I am not sure, these tests seems strange, anywayit passes locally now): tests/run-test/test005.phpttests/run-test/test008.phpt tests/run-test/test008a.phpt

2015-08-17 Thread Christoph Becker
On 13.08.2015 at 16:31, Xinchen Hui wrote: > Commit:69dbfa8e9f7a292880a639cad647d8ef8cf28a5c > Author:Xinchen Hui Thu, 13 Aug 2015 22:31:59 > +0800 > Parents: 896cb514995ff98cb03257d88fc7b55aab5186f9 > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=co

Re: [PHP-DEV] set_exception_handler catches all Throwables

2015-08-17 Thread Sebastian Bergmann
Am 17.08.2015 um 16:00 schrieb Derick Rethans: > Actually, I don't call this intended. This is just as much as a BC break > as the original implementation where Errors where also Exceptions. IMO, > set_exception_handler() should be changed - with my preference it not > capturing Error, and inste

Re: [PHP-DEV] set_exception_handler catches all Throwables

2015-08-17 Thread Derick Rethans
On Mon, 17 Aug 2015, Christian Weiske wrote: > >This is intended and documented here: > >http://php.net/manual/en/function.set-exception-handler.php > > If "Documented" means the note > > > Note that providing an explicit Exception type hint for the ex > > parameter in your callback will cause

[PHP-DEV] Re: Marking error, etc. functions as cold?

2015-08-17 Thread Dmitry Stogov
This is good idea. Some times ago I played with "hot" attribute, and didn't get any improvement, but we really may get something with "cold". Thanks. Dmitry. On Mon, Aug 17, 2015 at 1:26 PM, Matt Wilmas wrote: > Hi Dmitry, all, > > Has it been considered to use __attribute__((cold)) on, for exa

Re: [PHP-DEV] set_exception_handler catches all Throwables

2015-08-17 Thread Christian Weiske
Hello Niklas, >This is intended and documented here: >http://php.net/manual/en/function.set-exception-handler.php If "Documented" means the note > Note that providing an explicit Exception type hint for the ex > parameter in your callback will cause issues with the changed > exception hierarch

Re: [PHP-DEV] set_exception_handler catches all Throwables

2015-08-17 Thread Niklas Keller
This is intended and documented here: http://php.net/manual/en/function.set-exception-handler.php Regards, Niklas 2015-08-17 12:31 GMT+02:00 Christian Weiske : > Hi, > > > We're trying to use TYPO3 on PHP7 and have the problem that throwables > get passed to the exception handler because 'set_ex

[PHP-DEV] set_exception_handler catches all Throwables

2015-08-17 Thread Christian Weiske
Hi, We're trying to use TYPO3 on PHP7 and have the problem that throwables get passed to the exception handler because 'set_exception_handler()' does send all throwables to the handler, not only exceptions. Is this intended, or should a "set_throwable_handler()" function be introduced instead?

[PHP-DEV] Marking error, etc. functions as cold?

2015-08-17 Thread Matt Wilmas
Hi Dmitry, all, Has it been considered to use __attribute__((cold)) on, for example, error-type functions? I happened to notice this part about it in the GCC docs [1] a couple days ago: "The paths leading to calls of cold functions within code are marked as unlikely by the branch prediction m

Re: [PHP-DEV] Parameter parsing for zval type?

2015-08-17 Thread Dmitry Stogov
On Thu, Aug 13, 2015 at 1:12 AM, Matt Wilmas wrote: > H Dmitry, > > - Original Message - > From: "Dmitry Stogov" > Sent: Tuesday, August 11, 2015 > > On Tue, Aug 11, 2015 at 11:10 PM, Matt Wilmas >> wrote: >> >> [...] >>> >>> Look at e.g. is_numeric() or strpos() (needle). Plain zval pa

[PHP-DEV] Benchmark Results for PHP Master 2015-08-17

2015-08-17 Thread lp_benchmark_robot
Results for project php-src-nightly, build date 2015-08-17 05:00:00+03:00 commit: 9a895396c994b243db8379f41052272b05da0fef revision_date:2015-08-16 21:27:50+01:00 environment: Haswell-EP cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] Additional ideas about the design by contract RFC

2015-08-17 Thread Net Mo
I like the idea a lot, although I'm not so sure of the proposed syntax. I would make it less specific. Preconditions/Postconditions assertions are indeed useful but the functionality could be extended to regular checks as well by making the error user defined. Plus, I would prefer having named ch