Re: [PHP-DEV] Bugfest

2014-12-29 Thread Ferenc Kovacs
On Sun, Dec 28, 2014 at 7:45 AM, Remi Collet wrote: > Le 27/12/2014 16:06, Sebastian Bergmann a écrit : > > Am 27.12.2014 um 16:01 schrieb Kalle Sommer Nielsen: > >> bugs going as far back as to PHP4. > > > > Bug reports for PHP version that are not supported anymore [1] > > should IMHO be bulk-c

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Jacob Bednarz
My previous suggestion was to have a contributors page and it will rank people based on bug fixes. There appears to be a trend emerging where frameworks are making this more of a feature on their sites and there's nothing people enjoy more than getting recognition for their effort - even if

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Maciej Sobaczewski
I'm pretty sure that just trying to reproduce a problem and posting results in the comment, would be *very* helpful. W dniu 2014-12-29 o 19:19, Rafael Kassner pisze: Any chance to people without Karma helping here? Maybe trying to reproduce the bug in 5.4+ and asking for feedback? Any workflow

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Rafael Kassner
Any chance to people without Karma helping here? Maybe trying to reproduce the bug in 5.4+ and asking for feedback? Any workflow suggested? On Dec 29, 2014 4:03 PM, "Stanislav Malyshev" wrote: > Hi! > > > ...and what to do with feature requests? > > I would say - if it looks big (i.e. BC-breaking

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Camilo Sperberg
I will have some time the next few days, I have little C knowledge and never committed something to PHP core, but I could take a look and do some cleanup. Sent from my iPhone 7 Beta [Confidential use only] > On 29 dec. 2014, at 19:02, Stanislav Malyshev wrote: > > Hi! > >> ...and what to do

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Stanislav Malyshev
Hi! > ...and what to do with feature requests? I would say - if it looks big (i.e. BC-breaking change, language change, completely new functionality that may influence other parts of the language, etc.), recommend submitting the RFC, otherwise if it's clear what is being asked than just leave the

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Stanislav Malyshev
Hi! > The issue is obvious: I fixed the discrepancy between the docs and the > ARG_INFO listed by requiring the first parameter to > spl_autoload_register to be a callable. However, spl_autoload_register > has a second parameter that says whether or not an exception should be > thrown if it can't

Re: [PHP-DEV] VCS Account Request: jacob

2014-12-29 Thread Ferenc Kovacs
On Sun, Dec 28, 2014 at 7:11 PM, Pierre Joye wrote: > > On Dec 28, 2014 11:46 PM, "Ferenc Kovacs" wrote: > > > > > > > > On Sun, Dec 28, 2014 at 11:06 AM, Pierre Joye > wrote: > >> > >> btw, what is the best way to approve such accounts, with karma? > >> > >> On Sat, Dec 27, 2014 at 9:59 PM, Ja

Re: [PHP-DEV] VCS Account Request: jacob

2014-12-29 Thread Hannes Magnusson
let me know if you need commit karma for anything. Saw you were commenting on very old tickets, I'm not going after you to close them - you can do that yourself now :) -Hannes On Sat, Dec 27, 2014 at 9:59 PM, Jacob Bednarz wrote: > - Triaging bugs, issues and cleaning up bug reports > > > -- >

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Ferenc Kovacs
On Mon, Dec 29, 2014 at 2:42 PM, Levi Morrison wrote: > On Mon, Dec 29, 2014 at 6:17 AM, Levi Morrison wrote: > > On Mon, Dec 29, 2014 at 3:22 AM, Stanislav Malyshev > wrote: > >> Hi! > >> > >>> Hi Stas > >>> > >>> 2014-12-29 9:05 GMT+01:00 Stas Malyshev : > The CI tests still seem to be f

[PHP-DEV] Re: VCS Account Request: jacob

2014-12-29 Thread PHP Group
VCS Account Approved: jacob approved by bjori \o/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE][RFC] PHP 5.7

2014-12-29 Thread Andrea Faulds
Hey Ferenc, > On 29 Dec 2014, at 15:43, Ferenc Kovacs wrote: > > I'm not entirely sure that it is a good idea to go through the voting, as in > a previous mail you wrote that you don't support the idea anymore and you > plan withdrawing it: > https://www.mail-archive.com/internals@lists.php.ne

[PHP-DEV] Re: VCS Account Request: itsmedinesh31

2014-12-29 Thread PHP Group
VCS Account Rejected: itsmedinesh31 rejected by bjori /o\ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE][RFC] PHP 5.7

2014-12-29 Thread Ferenc Kovacs
On Mon, Dec 29, 2014 at 3:41 PM, Andrea Faulds wrote: > Good afternoon, > > I’m going to put the PHP 5.7 RFC to a vote, since it’d been 2 weeks. I’m > not entirely certain myself whether it’s a good idea, but I’d like it for > us to vote on it so we can settle the matter. If people vote against 5

[PHP-DEV] [VOTE][RFC] PHP 5.7

2014-12-29 Thread Andrea Faulds
Good afternoon, I’m going to put the PHP 5.7 RFC to a vote, since it’d been 2 weeks. I’m not entirely certain myself whether it’s a good idea, but I’d like it for us to vote on it so we can settle the matter. If people vote against 5.7, a new RFC proposing an alternative could always be made by

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Philip Hofstetter
Hi, On Mon, Dec 29, 2014 at 2:42 PM, Levi Morrison wrote: > 1) providing a non-callable type is a logical error even if you > suppress it with $throw = false yes. > 2) and parameter types are the standard way of checking this, not some > odd boolean as another parameter yes > 3) this would

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Levi Morrison
On Mon, Dec 29, 2014 at 6:17 AM, Levi Morrison wrote: > On Mon, Dec 29, 2014 at 3:22 AM, Stanislav Malyshev > wrote: >> Hi! >> >>> Hi Stas >>> >>> 2014-12-29 9:05 GMT+01:00 Stas Malyshev : The CI tests still seem to be failing: =

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Levi Morrison
On Mon, Dec 29, 2014 at 3:22 AM, Stanislav Malyshev wrote: > Hi! > >> Hi Stas >> >> 2014-12-29 9:05 GMT+01:00 Stas Malyshev : >>> The CI tests still seem to be failing: >>> >>> = >>> FAILED TEST SUMMARY >>> ---

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Levi Morrison
>> For a while I have been just stalking the bugs database[1], and I >> would love if we could some more focus on closing bugs. I'm not saying >> the job we do (my self included) is not being done well enough, but >> currently we have over 4.1k and a lot of those are old feature >> requests, or bug

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Matteo Beccati
Hi, On 29/12/2014 11:18, Kalle Sommer Nielsen wrote: * spl_autoload_001.phpt fails with an E_RECOVERABLE_ERROR but that is not due to my patch (tests with and without) * spl_autoload_005.phpt fails due to an E_STRICT (non-static method called statically) * spl_autoload_007.phpt fails due t

Re: [PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Stanislav Malyshev
Hi! > Hi Stas > > 2014-12-29 9:05 GMT+01:00 Stas Malyshev : >> The CI tests still seem to be failing: >> >> = >> FAILED TEST SUMMARY >> - >> SPL: spl_autoload()

[PHP-DEV] Fwd: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Kalle Sommer Nielsen
Forgot to reply-all; -- Forwarded message -- From: Kalle Sommer Nielsen Date: 2014-12-29 11:17 GMT+01:00 Subject: Re: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_er

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix tests I broke with the E_ERROR > E_RECOVERABLE_ERROR change: tests/output/ob_010.phpt tests/output/ob_011.phpt tests/output/ob_start_error_005.phpt

2014-12-29 Thread Stas Malyshev
Hi! On Sun, Dec 28, 2014 at 10:54 PM, Kalle Sommer Nielsen wrote: > Commit:334b9718d578caa9f4c6d3c2f7e2fb9b65696dc3 > Author:Kalle Sommer Nielsen Mon, 29 Dec 2014 > 07:54:44 +0100 > Parents: 3bd96e0735f45359bc3cff2981acbd34c60770c9 > Branches: master > > Link: > http://git.ph

Re: [PHP-DEV] Bugfest

2014-12-29 Thread Stanislav Malyshev
Hi! > For a while I have been just stalking the bugs database[1], and I > would love if we could some more focus on closing bugs. I'm not saying > the job we do (my self included) is not being done well enough, but > currently we have over 4.1k and a lot of those are old feature > requests, or bug