Re: [PHP-DEV] setcookie() minor BC break - fixes issue #67736

2014-09-07 Thread Tjerk Meesters
Hi! On Sat, Sep 6, 2014 at 5:38 AM, Florian Margaine wrote: > Hi, > > This is a minor BC break, but still a BC break, so worth discussing on this > ML. > > When a second setcookie() is done with the same name, a warning is emitted, > because the ietf rfc 6265 says it *should* only send one Set-

Re: [PHP-DEV] [RFC] Implicit isset() in Shorthand Ternary Operator

2014-09-07 Thread Andrea Faulds
On 7 Sep 2014, at 13:22, Sherif Ramadan wrote: > I've played around with this branch for a bit and seems reasonable, passes > the tests, and doesn't seem to have any serious issues/memories leaks > AFAICT. There’s actually a quite serious issue just now, which is that it evaluates the first op

Re: [PHP-DEV] [RFC] Implicit isset() in Shorthand Ternary Operator

2014-09-07 Thread Sherif Ramadan
I've played around with this branch for a bit and seems reasonable, passes the tests, and doesn't seem to have any serious issues/memories leaks AFAICT. I can't stress enough, however, how important it is for us to avoid inconsistencies in behavior between various forms of syntax. This is often so

Re: [PHP-DEV] [RFC] Implicit isset() in Shorthand Ternary Operator

2014-09-07 Thread Pierre Joye
Hi Andrea, On Sep 6, 2014 2:03 AM, "Andrea Faulds" wrote: > > Good evening, > > I’ve written an RFC and working patch which attempt to add this feature which has been often requested: https://wiki.php.net/rfc/isset_ternary I did not look at the patch yet but I like it from a feature point of vie