Re: [PHP-DEV] 5.4 non-security issues - last call

2014-09-02 Thread Stas Malyshev
Hi! > I have one fix for imagecrop, should be applied by tomorrow. Didn't see the fix, so I've tagged without it in the meantime, but if it's ready I could retag. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime Development Mailing L

Re: [PHP-DEV] destructors and output_buffering

2014-09-02 Thread Stas Malyshev
Hi! On Tue, Sep 2, 2014 at 12:56 AM, Stas Malyshev wrote: > Hi! > > I've created a proposed fix for #67644: > > https://github.com/php/php-src/pull/798 Looks like this fix breaks some tests, so I'm not feeling good putting it into 5.4. I'll revert it for now and try to figure out a better sol

Re: [PHP-DEV] destructors and output_buffering

2014-09-02 Thread jocelyn fournier
Hi Stas, Actually I would love flushing ob_start() in my own shutdown function, but since my application is a library called in auto_prepend_file, I have to protect ob_start() from being flushed too early by some wrong code in the client application. Hence I'm removing the PHP_OUTPUT_HANDLER_C

Re: [PHP-DEV] destructors and output_buffering

2014-09-02 Thread Stas Malyshev
Hi! > One line fix, nice :) > > A quick question about how resources are freed : > if some variables are computed inside a singleton and read through a > myclass::instance()->get_my_variable(), should we expect to have those > variables available when calling ob_start() callbacks ? > > From e

Re: [PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread guilhermebla...@gmail.com
It's also supported by System V using exactly same API. Some references: http://fossies.org/dox/glibc-2.19/sem__timedwait_8c_source.html http://manned.org/sem_timedwait/83baa20c http://linux.die.net/man/3/sem_timedwait http://pubs.opengroup.org/onlinepubs/009695399/functions/sem_timedwait.html O

Re: [PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread Matteo Beccati
On 02/09/2014 16:39, guilhermebla...@gmail.com wrote: > Hi Matteo, > > BSD does accept it as sem_timedwait, which I could find a reference for > FreeBSD: > > http://www.freebsd.org/cgi/man.cgi?query=sema&sektion=9 that's part of the FreeBSD Kernel Developer's Manual, not SysV semaphores ;) Che

Re: [PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread guilhermebla...@gmail.com
Hi Matteo, BSD does accept it as sem_timedwait, which I could find a reference for FreeBSD: http://www.freebsd.org/cgi/man.cgi?query=sema&sektion=9 Cheers, On Tue, Sep 2, 2014 at 10:01 AM, Matteo Beccati wrote: > Hi, > > On 02/09/2014 15:38, guilhermebla...@gmail.com wrote: > > I'd propose i

Re: [PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread Matteo Beccati
Hi, On 02/09/2014 15:38, guilhermebla...@gmail.com wrote: > I'd propose instead of accepting "nowait" only, I'd use a better support > and accept "until", dealing with possible cases: > > * -1: Blocks and wait until lock is acquired > * 0: Exactly what your patch does, attempt to grab and if

Re: [PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread guilhermebla...@gmail.com
Hi, Since I don't know where you guys like to discuss implementations, I'm pasting same thing I did in php-src PR: I'd propose instead of accepting "nowait" only, I'd use a better support and accept "until", dealing with possible cases: - -1: Blocks and wait until lock is acquired - 0: Ex

Re: [PHP-DEV] destructors and output_buffering

2014-09-02 Thread jocelyn fournier
Hi, One line fix, nice :) A quick question about how resources are freed : if some variables are computed inside a singleton and read through a myclass::instance()->get_my_variable(), should we expect to have those variables available when calling ob_start() callbacks ? From experiment, they

[PHP-DEV] Optional nowait argument to sem_acquire

2014-09-02 Thread Matteo Beccati
Hi everyone, the following patch: https://github.com/php/php-src/pull/741 has been lying around somewhere on my box since years and I recently stumbled upon it. However 5.6 was already RC and Ferenc suggested to eventually wait for 5.6.1. Do you think it's ok to add such a minor feature to 5.6

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
On Mon, September 1, 2014 23:45, Matt Wilmas wrote: > Hi Stas, > > > - Original Message - > From: "Stas Malyshev" > Sent: Monday, September 01, 2014 > > >> Hi! >> >> >>> It's much more optimized than what's there now, and slightly over the >>> > old >>> implementation. Not sure if I should

Re: [PHP-DEV] VCS Account Request: cpusavage5150

2014-09-02 Thread Andrea Faulds
On 2 Sep 2014, at 12:29, Caleb Lamb wrote: > Maintaining php.net, Maintaining an official, bundled PHP extension, and > Developing the PHP runtime Do you have any patches? -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http:/

[PHP-DEV] VCS Account Request: cpusavage5150

2014-09-02 Thread Caleb Lamb
Maintaining php.net, Maintaining an official, bundled PHP extension, and Developing the PHP runtime -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
On Mon, September 1, 2014 22:49, Stas Malyshev wrote: > Hi! > > >> It's much more optimized than what's there now, and slightly over the >> old implementation. Not sure if I should give the saved patch link, or >> the "live compare" (?) on Github, so I'll do both for now: >> http://realplain.com/p

[PHP-DEV] Re: [PATCH] Microsecond resolution and accuracy on Windows

2014-09-02 Thread Anatol Belski
Hi Matt, On Mon, September 1, 2014 20:36, Matt Wilmas wrote: > Hi all! > > > I'm back after several years, and will have a few more changes for > Windows, > at least. (It was CVS back then, so I still have to figure some things > out... Just had to edit files on Github site. :-/) > > Anyway, thi

Re: [PHP-DEV] destructors and output_buffering

2014-09-02 Thread Stas Malyshev
Hi! I've created a proposed fix for #67644: https://github.com/php/php-src/pull/798 It is the most conservative one which I'm thinking of putting into 5.4, so that at least we won't have segfaults. If we want to improve upon it, we can do that in 5.5/5.6, but I'd like at least plug the segfaults