Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Sat, Aug 23, 2014 at 9:41 PM, Andrea Faulds wrote: > > On 23 Aug 2014, at 20:38, Pierre Joye wrote: > >> Please try to port one. That will solve this never ending ping pong >> game. Extensions are broken per se with ng, almost every zval macros >> usage must change (some disappeared, like the

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Andrea Faulds
On 23 Aug 2014, at 20:38, Pierre Joye wrote: > Please try to port one. That will solve this never ending ping pong > game. Extensions are broken per se with ng, almost every zval macros > usage must change (some disappeared, like the _PP ones), all hash APIs > call must be change (a must, not de

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Sat, Aug 23, 2014 at 9:29 PM, Andrea Faulds wrote: > > On 23 Aug 2014, at 20:19, Kris Craig wrote: > >> I have a quick question for the people debating this issue: Aside from the >> dispute over whether or not it's necessary / unimportant, are there any >> pressing reasons *not* to implement

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Andrea Faulds
On 23 Aug 2014, at 20:19, Kris Craig wrote: > I have a quick question for the people debating this issue: Aside from the > dispute over whether or not it's necessary / unimportant, are there any > pressing reasons *not* to implement the changes that Pierre is advocating? > I.e. would it break a

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Kris Craig
On Aug 23, 2014 12:10 PM, "Pierre Joye" wrote: > > On Sat, Aug 23, 2014 at 6:40 PM, Rasmus Lerdorf wrote: > > On 8/22/14, 11:25 PM, Pierre Joye wrote: > >> There is. Long is not used anymore. So we can argue about that but > >> there is a change and it should be reflected imo. > >> > >> You still

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Sat, Aug 23, 2014 at 6:40 PM, Rasmus Lerdorf wrote: > On 8/22/14, 11:25 PM, Pierre Joye wrote: >> There is. Long is not used anymore. So we can argue about that but >> there is a change and it should be reflected imo. >> >> You still totally ignore any of my other points, which are even more >>

Re: [PHP-DEV] "PHP" namespace?

2014-08-23 Thread Rowan Collins
On 23/08/2014 04:39, Yasuo Ohgaki wrote: Hi Rowan, On Mon, Aug 18, 2014 at 12:28 AM, Rowan Collins mailto:rowan.coll...@gmail.com>> wrote: On 15/08/2014 01:46, Yasuo Ohgaki wrote: I have previously been tempted by the thought of adding a new set of functions with a clearer design

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Rasmus Lerdorf
On 8/22/14, 11:25 PM, Pierre Joye wrote: > There is. Long is not used anymore. So we can argue about that but > there is a change and it should be reflected imo. > > You still totally ignore any of my other points, which are even more > important in regard to maintaining one code tree for 5.x and

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Aug 23, 2014 5:02 PM, "Andrea Faulds" wrote: > > > On 23 Aug 2014, at 16:00, Pierre Joye wrote: > > > uint32_t for zend_uint (solving the > > zend_uint vs zend_into_t). > > uint32_t isn’t universally available. MSVC 2010 does not have it, for example. It would be nice to at least read the cod

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Andrea Faulds
On 23 Aug 2014, at 16:00, Pierre Joye wrote: > uint32_t for zend_uint (solving the > zend_uint vs zend_into_t). uint32_t isn’t universally available. MSVC 2010 does not have it, for example. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscr

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Aug 23, 2014 4:34 PM, "Andrea Faulds" wrote: > > > On 23 Aug 2014, at 10:43, Dmitry Stogov wrote: > > > I think it's ok to keep zend_off_t and zend_size_t as is. > > Could someone enlighten me as to why we need zend_size_t? Isn’t that just a typedef for size_t? It’s not like it’ll vary on diff

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Andrea Faulds
On 23 Aug 2014, at 10:43, Dmitry Stogov wrote: > I think it's ok to keep zend_off_t and zend_size_t as is. Could someone enlighten me as to why we need zend_size_t? Isn’t that just a typedef for size_t? It’s not like it’ll vary on different platforms, doing so would defeat the purpose of usin

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Pierre Joye
On Aug 23, 2014 11:55 AM, "Dmitry Stogov" wrote: > > 100% agree with RFC. > It would be great if technical improvements wouldn't be messed with this > renaming :( You realize that 80%+ of the zval macros has to be changed as well right? And not only the name but the argument and their content. I

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Dmitry Stogov
100% agree with RFC. It would be great if technical improvements wouldn't be messed with this renaming :( Thanks. Dmitry, On Fri, Aug 22, 2014 at 3:16 PM, Nikita Popov wrote: > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introdu

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-23 Thread Dmitry Stogov
I think it's ok to keep zend_off_t and zend_size_t as is. Thanks. Dmitry, On Fri, Aug 22, 2014 at 4:09 PM, Anatol Belski wrote: > Hi Nikita, > > On Fri, August 22, 2014 13:16, Nikita Popov wrote: > > Hi internals! > > > > > > Today the int64 RFC has been merged, despite objections regarding th