Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Sat, Aug 23, 2014 at 8:21 AM, Rasmus Lerdorf wrote: > On 8/22/14, 11:09 PM, Pierre Joye wrote: >> On Sat, Aug 23, 2014 at 8:05 AM, Rasmus Lerdorf wrote: >>> On 8/22/14, 10:46 PM, Pierre Joye wrote: In other words, it would be nice to see more developers actually porting extensions to

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Rasmus Lerdorf
On 8/22/14, 11:09 PM, Pierre Joye wrote: > On Sat, Aug 23, 2014 at 8:05 AM, Rasmus Lerdorf wrote: >> On 8/22/14, 10:46 PM, Pierre Joye wrote: >>> In other words, it would be nice to see more developers actually >>> porting extensions to realize the amount of changes are introduced by >>> NG and by

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Sat, Aug 23, 2014 at 8:05 AM, Rasmus Lerdorf wrote: > On 8/22/14, 10:46 PM, Pierre Joye wrote: >> In other words, it would be nice to see more developers actually >> porting extensions to realize the amount of changes are introduced by >> NG and by the int64. The sooner is in order of magnitude

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Rasmus Lerdorf
On 8/22/14, 10:46 PM, Pierre Joye wrote: > In other words, it would be nice to see more developers actually > porting extensions to realize the amount of changes are introduced by > NG and by the int64. The sooner is in order of magnitude must larger. > It is not a bad comment, only a fact. Given t

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
hi Rasmus, On Sat, Aug 23, 2014 at 4:05 AM, Rasmus Lerdorf wrote: > On 8/22/14, 11:38 AM, Pierre Joye wrote: >> On Aug 22, 2014 5:33 PM, "Andrea Faulds" wrote: >>> >>> >>> On 22 Aug 2014, at 12:16, Nikita Popov wrote: >>> As we were not given a chance to resolve this issue before the merge

Re: [PHP-DEV] "PHP" namespace?

2014-08-22 Thread Yasuo Ohgaki
Hi Rowan, On Mon, Aug 18, 2014 at 12:28 AM, Rowan Collins wrote: > On 15/08/2014 01:46, Yasuo Ohgaki wrote: > > On Wed, Jul 30, 2014 at 9:35 PM, Rowan Collins > > wrote: >> >> Making small changes, such as extra function aliases, or identical >> versions

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Andrea Faulds
On 23 Aug 2014, at 03:05, Rasmus Lerdorf wrote: > The end result here is likely that in order to write a portable > extension, extension authors will simply do: > > #ifndef IS_LONG > # define IS_LONG IS_INT > # define Z_STRLEN Z_STRSIZE > # define RETURN_LONG RETURN_INT > # define RETVAL_LONG R

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Rasmus Lerdorf
On 8/22/14, 11:38 AM, Pierre Joye wrote: > On Aug 22, 2014 5:33 PM, "Andrea Faulds" wrote: >> >> >> On 22 Aug 2014, at 12:16, Nikita Popov wrote: >> >>> As we were not given a chance to resolve this issue before the merge, a >>> short proposal has been created, which aims to revert all unnecessar

[PHP-DEV] Re: 5.6.0 final is near

2014-08-22 Thread Ferenc Kovacs
On Sun, Aug 17, 2014 at 11:25 AM, Ferenc Kovacs wrote: > Hi, > > I'm planning to release 5.6.0 from RC4 if nothing serious comes up, so > this is just a heads-up: if you think that there is some fix, which should > make into the 5.6.0 final (which isn't in RC4) or if you think that there > is som

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-22 Thread Pascal MARTIN
On 18/08/2014 18:41, Nikita Popov wrote: I've opened the vote on the Abstract Syntax Tree RFC: https://wiki.php.net/rfc/abstract_syntax_tree#vote After speaking with other members of AFUP (French UG) about this RFC, we pretty much all agree that a cleaner compilation process is a nice

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Aug 22, 2014 5:33 PM, "Andrea Faulds" wrote: > > > On 22 Aug 2014, at 12:16, Nikita Popov wrote: > > > As we were not given a chance to resolve this issue before the merge, a > > short proposal has been created, which aims to revert all unnecessary > > naming changes and instead use type names

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Jan Ehrhardt
Ferenc Kovacs in php.internals (Fri, 22 Aug 2014 18:59:01 +0200): >People means ext devs here. OK. >The concern raised here that if we delay the namechange then early >adopters(ext developers adding support for php7) have to update their code >twice. Provided the name change (back!) is agreed up

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Ferenc Kovacs
2014.08.22. 17:56 ezt írta ("Jan Ehrhardt" ): > > Andrea Faulds in php.internals (Fri, 22 Aug 2014 16:32:51 +0100): > >I’m very much in favour of this RFC. It is not necessary to change > >the type names after all; if people turn on compiler warnings, they’ll > >find out what’s broken anyway. > > '

Re: [PHP-DEV] New Memory Manager for PHP7

2014-08-22 Thread Levi Morrison
On Fri, Aug 22, 2014 at 4:04 AM, Dmitry Stogov wrote: > Hi, > > I'm going to commit this on next week, if nobody cares. > MM is a self containing subsystem, and it must not affect anything else. > > Thanks. Dmitry. I compared this to master on a small PHP array vs SplFixedArray performance test I

Re: [PHP-DEV] 5.4 security only

2014-08-22 Thread Michael Wallner
On 22/08/14 13:56, Julien Pauli wrote: > On Wed, Aug 20, 2014 at 10:45 PM, Stas Malyshev > wrote: >> Hi! >> >>> Apparently the fix for #67724 [2] caused #67865 [1], but I already have >>> a fix for the fix (oh my) [3]. >> >> I've reverted it from 5.4.32, but please commit this fix in 5.4. As phar

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 17:17, Derick Rethans wrote: > On Fri, 22 Aug 2014, Anatol Belski wrote: > > >> On Fri, August 22, 2014 14:54, Derick Rethans wrote: >> > >>> Yeah, those datatypes should already be there. What needs fixing to >>> make it work? >>> >> >> I think now that it's unavoidable to

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Jan Ehrhardt
Andrea Faulds in php.internals (Fri, 22 Aug 2014 16:32:51 +0100): >I’m very much in favour of this RFC. It is not necessary to change >the type names after all; if people turn on compiler warnings, they’ll >find out what’s broken anyway. 'people'? Which people? Will a normal user ever notice anyt

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Andrea Faulds
On 22 Aug 2014, at 12:16, Nikita Popov wrote: > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, which aims to revert all unnecessary > naming changes and instead use type names that are consistent with the > existing code base and expect

[PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Derick Rethans
On Fri, 22 Aug 2014, Anatol Belski wrote: > On Fri, August 22, 2014 14:54, Derick Rethans wrote: > > Yeah, those datatypes should already be there. What needs fixing to > > make it work? > > > > I think now that it's unavoidable to create an arch dependent portable > type as timelib_sll is alw

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread christopher jones
On 8/22/14, 5:11 AM, Pierre Joye wrote: On Fri, Aug 22, 2014 at 1:28 PM, Bob Weinand wrote: Yes, please. We're all in favor of the 64 bit implementation, but definitely not on the naming. I think it was a big mistake to not separate the naming and implementation votes initially. I also wou

Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready to be merged

2014-08-22 Thread Andrea Faulds
On 22 Aug 2014, at 08:10, Matteo Beccati wrote: > On 21/08/2014 19:42, Andrea Faulds wrote: >> * IS_LONG/long - 32-bit or 64-bit integer (machine-dependant) >> * IS_BIGINT/bigint - arbitrary-size integer >> * IS_BIGINT_OR_LONG/integer - either a long or a bigint (pseudo-type) >> >> Replacing IS

[PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 14:54, Derick Rethans wrote: > On Fri, 22 Aug 2014, Anatol Belski wrote: > > >> On Fri, August 22, 2014 14:01, Derick Rethans wrote: >> >>> On Mon, 18 Aug 2014, Anatol Belski wrote: >>> >>> >>> Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4 Author:Anatol B

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Jan Ehrhardt
Pierre Joye in php.internals (Fri, 22 Aug 2014 14:17:04 +0200): >And I'd to remember that we suffer from double standards while you >guys do whatever you want with ng, and certainly with ast as well. Just a side note: talking in "you guys" and "we" is not constructive. I had the idea you had come

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Anatol Belski
On Fri, August 22, 2014 14:15, Pierre Joye wrote: > On Fri, Aug 22, 2014 at 2:01 PM, Derick Rethans wrote: > >> On Mon, 18 Aug 2014, Anatol Belski wrote: >> >> >>> Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4 >>> Author:Anatol Belski Mon, 18 Aug 2014 >>> 18:57:55 +0200 >>> Pare

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Fri, Aug 22, 2014 at 1:28 PM, Bob Weinand wrote: > Yes, please. We're all in favor of the 64 bit implementation, but definitely > not on > the naming. I think it was a big mistake to not separate the naming and > implementation votes initially. > > I also would support a shorter RFC cycle, du

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Fri, Aug 22, 2014 at 1:16 PM, Nikita Popov wrote: > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, which aims t

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Pierre Joye
On Fri, Aug 22, 2014 at 1:16 PM, Nikita Popov wrote: > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, which aims t

[PHP-DEV] Re: [PHP-CVS] com php-src: fixes to date: ext/date/lib/timelib.c ext/date/lib/timelib.h ext/date/php_date.c ext/date/php_date.h

2014-08-22 Thread Pierre Joye
On Fri, Aug 22, 2014 at 2:01 PM, Derick Rethans wrote: > On Mon, 18 Aug 2014, Anatol Belski wrote: > >> Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4 >> Author:Anatol Belski Mon, 18 Aug 2014 18:57:55 >> +0200 >> Parents: b8324e6d635450562ecb253af38f22105e19e460 >> Branches:

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Anatol Belski
Hi Nikita, On Fri, August 22, 2014 13:16, Nikita Popov wrote: > Hi internals! > > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, w

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Derick Rethans
On Fri, 22 Aug 2014, Nikita Popov wrote: > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, > a short proposal has been created, which aims to revert

Re: [PHP-DEV] 5.4 security only

2014-08-22 Thread Julien Pauli
On Wed, Aug 20, 2014 at 10:45 PM, Stas Malyshev wrote: > Hi! > >> Apparently the fix for #67724 [2] caused #67865 [1], but I already have >> a fix for the fix (oh my) [3]. > > I've reverted it from 5.4.32, but please commit this fix in 5.4. As phar > is currently broken, fix for this qualifies as

Re: [PHP-DEV] Merges between PHP5 and PHP7

2014-08-22 Thread Derick Rethans
On Fri, 22 Aug 2014, Anatol Belski wrote: > as there are many data type changes, here's an idea on how to simplify > the merges. Git supports custom merge drivers which attracted my > attention, so I've ended up with the following trick: As there are that many differences, does it still make se

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-22 Thread Derick Rethans
On Wed, 20 Aug 2014, Andrea Faulds wrote: > > On 20 Aug 2014, at 03:53, Laruence wrote: > > > On Wed, Aug 20, 2014 at 6:36 AM, Andrea Faulds wrote: > >> Good evening, > >> > >> I have made an RFC which would make some small changes to how > >> integers are handled, targeted at PHP 7: > >> >

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Bob Weinand
Am 22.8.2014 um 13:16 schrieb Nikita Popov : > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, which aims to rever

Re: [PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Joe Watkins
On Fri, 2014-08-22 at 13:16 +0200, Nikita Popov wrote: > Hi internals! > > Today the int64 RFC has been merged, despite objections regarding the > naming changes it introduces. > > As we were not given a chance to resolve this issue before the merge, a > short proposal has been created, which aim

[PHP-DEV] [RFC] Better type names for int64 RFC

2014-08-22 Thread Nikita Popov
Hi internals! Today the int64 RFC has been merged, despite objections regarding the naming changes it introduces. As we were not given a chance to resolve this issue before the merge, a short proposal has been created, which aims to revert all unnecessary naming changes and instead use type names

Re: [PHP-DEV] New Memory Manager for PHP7

2014-08-22 Thread Dmitry Stogov
Hi, I'm going to commit this on next week, if nobody cares. MM is a self containing subsystem, and it must not affect anything else. Thanks. Dmitry. On Mon, Aug 18, 2014 at 10:07 PM, Levi Morrison wrote: > On Mon, Aug 18, 2014 at 12:04 PM, Nikita Popov > wrote: > > On Mon, Aug 18, 2014 at 7

Re: [PHP-DEV] On BC and not being evil (Was: Re: [PHP-DEV] [RFC] Integer Semantics)

2014-08-22 Thread Lester Caine
On 21/08/14 19:17, Stas Malyshev wrote: > We have millions of people using PHP 5, and the goal is for > almost all of them to eventually use PHP 7, otherwise there's no point > in it. Each BC break creates another hurdle on the way to it. We should > take it seriously. Currently we have millions s

[PHP-DEV] Merges between PHP5 and PHP7

2014-08-22 Thread Anatol Belski
Hi, as there are many data type changes, here's an idea on how to simplify the merges. Git supports custom merge drivers which attracted my attention, so I've ended up with the following trick: === Add to .git/config === [merge "7"] name = Compatibility merge between PHP5 and PHP7 driver

Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready to be merged

2014-08-22 Thread Anatol Belski
Moin, On Thu, August 21, 2014 19:23, Dmitry Stogov wrote: > Hi, > > > Thanks to Anatol and Pierre the 64-bit patch is ready > https://github.com/weltling/php-src > > > I made quick code review and don't see any technical problems now. > > > The performance and memory consumption difference is negl

Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready to be merged

2014-08-22 Thread Lester Caine
On 21/08/14 19:10, Andrea Faulds wrote: >> I would instead to ask you to try to migrate a not so trivial extension :) > No, seriously. Why can’t a sed script be used to change a constant name? Can > you tell me why that wouldn’t work? Compatibility across all builds? Many of the times 'blanket' c

[PHP-DEV] PHP 5.5.16 is available

2014-08-22 Thread Julien Pauli
Hello! The PHP development team announces the immediate availability of PHP 5.5.16. This fixes some bugs against 5.5.15 and addresses five CVEs. All PHP 5.5 users are encouraged to upgrade to this version. For source downloads of PHP 5.5.16 please visit our downloads page: http://www.php.net/dow

Re: [PHP-DEV] 64-bit integers and 64-bit string length patch is ready to be merged

2014-08-22 Thread Matteo Beccati
On 21/08/2014 19:42, Andrea Faulds wrote: > * IS_LONG/long - 32-bit or 64-bit integer (machine-dependant) > * IS_BIGINT/bigint - arbitrary-size integer > * IS_BIGINT_OR_LONG/integer - either a long or a bigint (pseudo-type) > > Replacing IS_LONG with IS_INT kinda ruins my naming scheme. The intent