Hi Stas,
On Mon, Aug 5, 2013 at 9:45 AM, Stas Malyshev wrote:
> >> https://github.com/php/php-src/pull/368
> >> https://github.com/php/php-src/pull/367
> >> https://github.com/php/php-src/pull/366
>
> I've amended your patch slightly:
> https://github.com/php/php-src/pull/401
>
> and it looks fin
Hi!
>> https://github.com/php/php-src/pull/368
>> https://github.com/php/php-src/pull/367
>> https://github.com/php/php-src/pull/366
I've amended your patch slightly:
https://github.com/php/php-src/pull/401
and it looks fine to me now. What do you think, is it OK with you?
--
Stanislav Malyshe
Hi!
> Sorry for the long delay, I've sent pull requests
>
> https://github.com/php/php-src/pull/368
> https://github.com/php/php-src/pull/367
> https://github.com/php/php-src/pull/366
I'm looking at the pulls, and I see these issues:
1. session_id is still banned in strict mode. Can we not ban
Hey Rasmus
2013/8/3 Rasmus Lerdorf :
> Hey Johannes, could you take a look at:
>
> https://gist.github.com/anonymous/6143477
>
> You can reproduce in 5.5 with:
>
> sapi/cli/php ext/mysqli/tests/mysqli_poll_kill.php
>
> main/streams/cast.c:306 is:
>
> if (php_stream_is_filtered(stream)) {
>
> but p
Well, if he's still up to it I think we should list him as a maintainer.
Ralph?
Yes, I am ready to get back on this horse.
Stas, I will address your questions on my original PR this week, perhaps
we can get it to a place where you can close it out.
-ralph
--
PHP Internals - PHP Runtime Dev
