Re: [PHP-DEV] Always set return_value_ptr?

2013-08-03 Thread Anatol Belski
Hi Nikita, On Sat, 2013-08-03 at 20:16 +0200, Nikita Popov wrote: > Why can't we always provide the retval ptr, even for functions that don't > return by reference? This would allow returning zvals without having to > copy them first (what RETVAL_ZVAL does). were it not possible to zval_add_ref(

[PHP-DEV] Always set return_value_ptr?

2013-08-03 Thread Nikita Popov
Hi internals! Is there any particular reason why we only pass return_value_ptr to internal functions if they have the ACC_RETURN_REFERENCE flag set? Why can't we always provide the retval ptr, even for functions that don't return by reference? This would allow returning zvals without having to co

[PHP-DEV] Segfault on mysqlnd stream cast

2013-08-03 Thread Rasmus Lerdorf
Hey Johannes, could you take a look at: https://gist.github.com/anonymous/6143477 You can reproduce in 5.5 with: sapi/cli/php ext/mysqli/tests/mysqli_poll_kill.php main/streams/cast.c:306 is: if (php_stream_is_filtered(stream)) { but php_stream_is_filtered is just a macro that isn't expecting