Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread Kris Craig
On Thu, Nov 29, 2012 at 3:57 PM, David Muir wrote: > On 30/11/12 05:25, Ángel González wrote: > > On 29/11/12 18:17, Anthony Ferrara wrote: > >> Just pointing this out: that's NOT what this RFC recommends, and is > >> NOT what's being voted on. This RFC is talking about ONLY adding > >> E_DEPRECA

Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread David Muir
On 30/11/12 05:25, Ángel González wrote: > On 29/11/12 18:17, Anthony Ferrara wrote: >> Just pointing this out: that's NOT what this RFC recommends, and is >> NOT what's being voted on. This RFC is talking about ONLY adding >> E_DEPRECATED to core. And the way it's proposed to be done, the >> "move

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Pierre Joye
hi Jan, On Thu, Nov 29, 2012 at 4:46 PM, Jan Ehrhardt wrote: > Kris Craig in php.internals (Wed, 28 Nov 2012 12:33:55 -0800): >>We also know that E_DEPRECATED works when other approaches do not. I would >>point you all to the famous example of Drupal 7, which would break >>completely due to a fl

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Peter Cowburn
On 29 November 2012 08:27, Pierre Joye wrote: > > No there is not [precedent to remove from core without deprecating first], > not since the RFC introduction. Removing > extension in minor (x.y+1 or x.y.z+1) is not allowed. > Moving an extension to PECL in a minor version increment is allowed, p

Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread Ángel González
On 29/11/12 18:17, Anthony Ferrara wrote: > Just pointing this out: that's NOT what this RFC recommends, and is > NOT what's being voted on. This RFC is talking about ONLY adding > E_DEPRECATED to core. And the way it's proposed to be done, the > "moves-to-PECL" couldn't happen, since it's hard-cod

Re: [PHP-DEV] SplDoublyLinkedList missing insertBefore/After

2012-11-29 Thread Daniel Ribeiro Gomes
It would be an awesome feature, indeed. Daniel Ribeiro Gomes Pereira Twitter | Facebook | LinkedIn iPhone: +55 (48) 9111-0931 2012/11/29 Levi

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Kris Craig
On Thu, Nov 29, 2012 at 10:03 AM, Anthony Ferrara wrote: > Kris > > > I think you're forgetting though that the same applies to PHP itself. Many >> repos still default to PHP 5.1.x. Adoption always tends to be a lagging >> factor. I don't see any evidence to suggest that Drupal and other distro

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Anthony Ferrara
Kris I think you're forgetting though that the same applies to PHP itself. Many > repos still default to PHP 5.1.x. Adoption always tends to be a lagging > factor. I don't see any evidence to suggest that Drupal and other distros > have even slower adoption rates than PHP. In fact, the opposi

Re: [PHP-DEV] SplDoublyLinkedList missing insertBefore/After

2012-11-29 Thread Levi Morrison
On Thu, Nov 29, 2012 at 4:38 AM, Rafael Dohms wrote: > I have just noticed that the current SPL inplementation of a > DoublyLinkedList does not include methods to insert nodes into the middle > of the list (insertBefore, insertAfter). > > After mentioning it I ran into a few people and other outbu

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Kris Craig
On Thu, Nov 29, 2012 at 7:46 AM, Jan Ehrhardt wrote: > Kris Craig in php.internals (Wed, 28 Nov 2012 12:33:55 -0800): > >We also know that E_DEPRECATED works when other approaches do not. I > would > >point you all to the famous example of Drupal 7, which would break > >completely due to a flurr

Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread Anthony Ferrara
Angel On Thu, Nov 29, 2012 at 12:02 PM, Ángel González wrote: > David Muir wrote: > > On 29/11/12 05:09, Ángel González wrote: > >> I see it as simple to show E_DEPRECATED but not when installed from > >> PECL. > >> > >> 1) Add a > >> int mysql_extension_triggers_deprecated_warning = 1; > >> > >

Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread Ángel González
David Muir wrote: > On 29/11/12 05:09, Ángel González wrote: >> I see it as simple to show E_DEPRECATED but not when installed from >> PECL. >> >> 1) Add a >> int mysql_extension_triggers_deprecated_warning = 1; >> >> And use it as a conditional for triggering the warning. >> >> 2) Copy the extensi

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Remi Collet
My 0,02€ Could it be possible to add in "deprecated" field in the zend_module_entry structure, add 0 value in STANDARD_MODULE_PROPERTIES_EX add 1 value in DEPRECATED_MODULE_PROPERTIES_EX (new constant) And then, only throw a message during initial module load. This will produce really less noi

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Jan Ehrhardt
Kris Craig in php.internals (Wed, 28 Nov 2012 12:33:55 -0800): >We also know that E_DEPRECATED works when other approaches do not. I would >point you all to the famous example of Drupal 7, which would break >completely due to a flurry of E_DEPRECATED warnings (if display_errors was >set to on) bei

Re: [PHP-DEV] DOMNodeList memory eating

2012-11-29 Thread Rob Richards
XPath returns a fully populated list of object based on the expression. getElementsByTagName accesses the nodes within the tree in real time as you iterate so you only have one object at a time unless you are persisting them. Different behavior due to who owns the data and its lifecycle. XPath

[PHP-DEV] DOMNodeList memory eating

2012-11-29 Thread Nicolai Scheer
Hi! Just stumbled upon a strange behaviour when iterating over DOMNodeLists. Before I open a bug report I'd like to ask if anyone can comment on this issue, maybe it's the excpected behaviour. Consider the following small script: x x x XML; $dom = new DOMDocument(); $dom->loadXML

Re: [PHP-DEV] SplDoublyLinkedList missing insertBefore/After

2012-11-29 Thread Paul Dragoonis
Hi Rafael, I have worked on this code before and if the idea is accepted I'm happy to add features to this class. Let me know. Thanks, Paul. On Thu, Nov 29, 2012 at 11:38 AM, Rafael Dohms wrote: > I have just noticed that the current SPL inplementation of a > DoublyLinkedList does not include

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Johannes Schlüter
On Wed, 2012-11-28 at 23:28 -0500, Anthony Ferrara wrote: > Case in point, take a look at 5.3.0. The following extensions were moved to > PECL: > > >- ext/dbase >- ext/fbsql >- ext/fdf >- ext/ncurses >- ext/mhash (BC layer is now entirely within ext/hash) >- ext/ming >

[PHP-DEV] SplDoublyLinkedList missing insertBefore/After

2012-11-29 Thread Rafael Dohms
I have just noticed that the current SPL inplementation of a DoublyLinkedList does not include methods to insert nodes into the middle of the list (insertBefore, insertAfter). After mentioning it I ran into a few people and other outbursts on the internet of more people who saw this and complained

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Chris van Dam
Hi Internals, I think the E_DEPRECATED flag for this extension is fine, as it helps tracking down the code which needs to be fixed. Kind regards, Chris van Dam Op 29-11-12 09:27 schreef Pierre Joye : >hi Anthony, > >As you are (relatively) new in php.net, let keep the history in mind >while co

Re: [PHP-DEV] Bug 61272

2012-11-29 Thread Michael Wallner
On 29 November 2012 08:00, Yasuo Ohgaki wrote: > I recently looked into new output code in PHP 5.4. > It's MUCH nicer than older code. Good job! Appreciated! > However, new code encapsulate output globals. (I mean internally) > It would be nice for my extension if output globals are exposed. T

Re: [PHP-DEV] ext/mysql in PECL and E_DEPRECATED

2012-11-29 Thread Pierre Joye
hi Alan! On Thu, Nov 29, 2012 at 12:11 AM, Mailing list wrote: > .. annoying top posting... Why do you top post too then? :) > This is getting close to a good solution. > > ini option mysql_is_deprecated - can not be set in .ini/htaccess etc, only > by ini_set() - so hosters/distros can not f

Re: [PHP-DEV] Re: [VOTE] ext/mysql deprecation in 5.5

2012-11-29 Thread Pierre Joye
hi Anthony, As you are (relatively) new in php.net, let keep the history in mind while comparing things. On Thu, Nov 29, 2012 at 5:28 AM, Anthony Ferrara wrote: > Actually, it is very much within the scope of this discussion. > > Case in point, take a look at 5.3.0. The following extensions wer