Re: [PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Sara Golemon
On Mon, Jul 2, 2012 at 5:49 PM, Anthony Ferrara wrote: > Sara, > > On Mon, Jul 2, 2012 at 8:24 PM, Sara Golemon wrote: > > I'd like to see hash_init() support this mode as well (for completeness). > > Perhaps something like the following: > > > > $ctx = hash_init("sha512", HASH_PBKDF2, $salt, a

Re: [PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Anthony Ferrara
Sara, On Mon, Jul 2, 2012 at 8:24 PM, Sara Golemon wrote: > I'd like to see hash_init() support this mode as well (for completeness). >  Perhaps something like the following: > > $ctx = hash_init("sha512", HASH_PBKDF2, $salt, array('length' => 32, > 'iterations' => 5000)); > > The new fourth para

Re: [PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Sara Golemon
I'd like to see hash_init() support this mode as well (for completeness). Perhaps something like the following: $ctx = hash_init("sha512", HASH_PBKDF2, $salt, array('length' => 32, 'iterations' => 5000)); The new fourth parameter being an overloadable options generic so that we don't have an end

Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API

2012-07-02 Thread Anthony Ferrara
Chris, > To be honest, a note next to PASSWORD_DEFAULT would be good too. Ok, I'll add that in shortly. >>> The API of password_make_salt() seems restrictive.  What if other >>> options are needed in future? >> >> >> Can you give any examples of what options would be needed in the >> future, or

Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API

2012-07-02 Thread Christopher Jones
On 07/02/2012 01:55 PM, Anthony Ferrara wrote: Chris, Can you update the RFC (aka future documentation) and make this obvious to an end user? I just made an update (in the behavior sections). Let me know if additional clarification is needed. To be honest, a note next to PASSWORD_DEFAULT

Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API

2012-07-02 Thread Anthony Ferrara
Chris, > Can you update the RFC (aka future documentation) and make this obvious > to an end user? I just made an update (in the behavior sections). Let me know if additional clarification is needed. > I think PASSWORD_BCRYPT should be an ordinal value, which the new > library maps to "2y" when

Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API

2012-07-02 Thread Christopher Jones
On 06/26/2012 08:25 AM, Anthony Ferrara wrote: Hello All, I've taken the conversation of the previous simplified password hashing API, and generated a patch and draft RFC for it. The patch isn't ready yet (needs review, cleanup and testing), but it's a start. https://wiki.php.net/rfc/password

Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API

2012-07-02 Thread Christopher Jones
On 06/27/2012 07:16 AM, Anthony Ferrara wrote: Arvids, On Wed, Jun 27, 2012 at 9:23 AM, Arvids Godjuks wrote: Hello. I personally think that using PASSWORD_DEFAULT for algorythm by default is a bad idea. This should be defined by user in the code. Even worse if it is defined by .ini setting

Re: [PHP-DEV] concatenation operator

2012-07-02 Thread Christopher Jones
On 06/30/2012 04:51 PM, Johannes Schlüter wrote: On Sat, 2012-06-30 at 03:53 -0700, Adi Mutu wrote: Only thing that helps is learning the code structure and digging through it. Any hint/documentation to learn that? Use the source. ;-) A bit more seriously: No, there's no good single plac

Re: [PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Anthony Ferrara
Paul On Mon, Jul 2, 2012 at 12:38 PM, Paul Dragoonis wrote: > I see no coding examples, just a function declaration. I've updated the RFC adding 2 examples. Anthony -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Paul Dragoonis
I see no coding examples, just a function declaration. On Mon, Jul 2, 2012 at 5:34 PM, Anthony Ferrara wrote: > Hello all, > > I've opened voting for the hash_pbkdf2 RFC adding hash_pbkdf2() to master: > > https://wiki.php.net/rfc/hash_pbkdf2#vote > > Thanks, > > Anthony > > -- > PHP Internals -

[PHP-DEV] [VOTE] Hash_pbkdf2

2012-07-02 Thread Anthony Ferrara
Hello all, I've opened voting for the hash_pbkdf2 RFC adding hash_pbkdf2() to master: https://wiki.php.net/rfc/hash_pbkdf2#vote Thanks, Anthony -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: JSON changes in 5.3/5.4

2012-07-02 Thread Max Benson
Johannes Schlüter schlueters.de> writes: > I think in 5.3 we don't need changes. 5.3 is a stable stable stable > branch. Fixing bugs, ok, changing behavior: No go. > > I haven't looked at it in detail, though. > > johannes > Indeed, 5.3 seems very stable. We ran many tests. Regards, Max Bens