Hi!
> For instance, 0f180a63 was committed to 5.3 in April 7 (a
> stream_get_line() fix). It is most definitely in 5.4.4RC2:
>
> $ git merge-base 0f180a63e php-5.4.4RC2
> 0f180a63ebb2d65bbe49b68d2430639b20443e9a
>
> However, there's no mention in NEWS.
I don't see NEWS entry for 5.3 either for
Hi!
> Sorry to bring this up again, but they aren't. 5.3 NEWS are not being
> merged.
Something weird going on with the NEWS. For example, I did cleanup in
this commit:
https://github.com/php/php-src/commit/5ebb0e520f4c31d09d9e5acd323162eca3fee0e3
However I'm looking at the tree now and it's g
Nikita,
> I don't know whether that behavior is of any use, so I'll gladly
> change the behavior to throwing an exception if that's more desirable.
You can't throw an exception from rewind, since it's called before
foreach(). So it wouldn't be iterable then.
I think the noop on rewind is valid
On Wed, Jun 6, 2012 at 10:55 AM, Gustavo Lopes wrote:
> On Tue, 5 Jun 2012 19:35:14 +0200, Nikita Popov wrote:
>>
>>
>> Before going any further I'd like to get some comments about what you
>> think of adding generator support to PHP.
>>
>
> I approve.
>
> A few comments on the current RFC:
>
> *
On 6 Jun 2012 08:43, "David Soria Parra" wrote:
>
> Do we need an RFC for that simple pull request or can we just go ahead
> and pull it?
Please don't waste your time on an rfc for it. If you really want to write
anything, write the doc.
-Hannes
On Wed, 06 Jun 2012 21:40:54 +0200, Kris Craig
wrote:
IMHO since it represents a language change (albeit a minor one) I agree
with Pierre that an RFC wouldn't hurt. If nothing else it's just a good
habit to get into I think.
Adding a function or class most definitely is not a language cha
On Wed, Jun 6, 2012 at 4:29 AM, Felipe Pena wrote:
> Hi,
>
> 2012/6/6 Pierre Joye :
> > hi,
> >
> > Pull it but I would still do a RFC to clearly document it (exact
> > behaviors), which could be then used by the doc team and to implement
> > tests.
> >
> > On Wed, Jun 6, 2012 at 11:51 AM, Derick
On Wed, Jun 6, 2012 at 10:09 AM, Nikita Popov wrote:
> On Tue, Jun 5, 2012 at 8:32 PM, Kris Craig wrote:
> > Some observations and questions:
> >
> > In the RFC, the top example claims to make use of the file() function,
> but
> > in fact does not. Did you mean fopen()? Or did you mean that thi
On Wed, Jun 6, 2012 at 4:15 AM, Laruence wrote:
> Hi Nikita:
>
> the most important part to me is how did you implemented `yield`
> keyword, is there a whole patch file I can look into?
>
> what will happen if you use a `yield` in a normal function?
>
> actually, I tried to implemented
On Tue, Jun 5, 2012 at 8:52 PM, Benjamin Eberlei wrote:
> This is really awesome. Some remarks:
>
> 1. The * looks a bit hidden. How about reusing the yield keyword? "function
> yield getLines()"
I mainly chose the * modifier because this is how JavaScript
(ECMAScript Harmony) does it. It also see
On Tue, Jun 5, 2012 at 8:32 PM, Kris Craig wrote:
> Some observations and questions:
>
> In the RFC, the top example claims to make use of the file() function, but
> in fact does not. Did you mean fopen()? Or did you mean that this to be an
> example of someone writing their own file() function
On 06/06/12 12:20, Ivan Enderlin @ Hoa wrote:
> On 05/06/12 19:35, Nikita Popov wrote:
>> Hi internals!
> Hi Nikita,
>
>> Before going any further I'd like to get some comments about what you
>> think of adding generator support to PHP.
> I have always hoped to see the “yield” keywork introduced in
On 2012-06-03, Yasuo Ohgaki wrote:
> Hi,
>
> I noticed that old PHP source in git lacks Zend directory.
> Perhaps, all Zend Engine 1?
Thanks i'll take a look
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hi,
2012/6/6 Pierre Joye :
> hi,
>
> Pull it but I would still do a RFC to clearly document it (exact
> behaviors), which could be then used by the doc team and to implement
> tests.
>
> On Wed, Jun 6, 2012 at 11:51 AM, Derick Rethans wrote:
>> David Soria Parra wrote:
>>
>>> Going through the 2
Hello Ivan,
Moreover, I wonder how a “recursive yield” would act (something like
> “public function *f ( … ) { … yield $this->f(…); … }”). It is possible? Is
> it anticipated?
>
According to the RFC, your syntax will yield an entire generator and not
its intividual values. Please consider this
On 05/06/12 19:35, Nikita Popov wrote:
Hi internals!
Hi Nikita,
Before going any further I'd like to get some comments about what you
think of adding generator support to PHP.
I have always hoped to see the “yield” keywork introduced in PHP. I even
suggested that in this mailing-list at least
hi,
Pull it but I would still do a RFC to clearly document it (exact
behaviors), which could be then used by the doc team and to implement
tests.
On Wed, Jun 6, 2012 at 11:51 AM, Derick Rethans wrote:
> David Soria Parra wrote:
>
>> Going through the 26 open pull requests (please let us work on
David Soria Parra wrote:
> Going through the 26 open pull requests (please let us work on getting
> that number down), I stumbled over
> https://github.com/php/php-src/pull/60.
>
> This was already proposed on the mailinglits, but the thread died fast
> without
> a satisfying answer on whether t
hi Rasmus, Sara,
Adding Sara to the loop as she is around and may miss that thread. We
also tried to convince her to contribute that back to core :)
On Wed, Jun 6, 2012 at 10:11 AM, Rasmus Lerdorf wrote:
> On 06/06/2012 04:42 AM, Laruence wrote:
>> On Wed, Jun 6, 2012 at 10:27 AM, Laruence wrot
On Tue, 5 Jun 2012 19:35:14 +0200, Nikita Popov wrote:
Before going any further I'd like to get some comments about what you
think of adding generator support to PHP.
I approve.
A few comments on the current RFC:
* The RFC is too vague.
* You're violating the contract of Iterator left and r
On 06/06/2012 04:42 AM, Laruence wrote:
> On Wed, Jun 6, 2012 at 10:27 AM, Laruence wrote:
>> On Wed, Jun 6, 2012 at 10:15 AM, Laruence wrote:
>>> Hi Nikita:
>>>
>>>the most important part to me is how did you implemented `yield`
>>> keyword, is there a whole patch file I can look into?
>>
Hi!
> Going through the 26 open pull requests (please let us work on getting
> that number down), I stumbled over https://github.com/php/php-src/pull/60.
>
> This was already proposed on the mailinglits, but the thread died fast without
> a satisfying answer on whether to add a function boolval()
Going through the 26 open pull requests (please let us work on getting
that number down), I stumbled over https://github.com/php/php-src/pull/60.
This was already proposed on the mailinglits, but the thread died fast without
a satisfying answer on whether to add a function boolval() or not.
Perso
23 matches
Mail list logo
