Re: [PHP-DEV] Accessors v2.4 Proposed Changes

2012-03-22 Thread Michael Wallner
Hi Clint, On 22 March 2012 20:00, Clint M Priest wrote: > Does anyone else have any comments about this RFC (as-implemented)? I need time, probably longer than the weekend, to review your RFC, to be able to say anything seriously. Generally, I was against the idea of accessors, when you brought

Re: [PHP-DEV] Override keyword

2012-03-22 Thread Ivan Enderlin @ Hoa
Hi Michael, I think your proposition is related to annotations. It is a “service”, an _information_, so it clearly belongs to annotations, documentation or IDE domain, but it does not belong to the language. Are you agree with this? Best regards. On 22/03/12 21:27, Michael Morris wrote: Wit

[PHP-DEV] fix for 61418 breaks win32 build

2012-03-22 Thread Stas Malyshev
Hi! Commit 714f1ff4b37c5101b3c61ea108a3d415f41e50df is breaking win32 build and causing bug #61482. I am reverting this commit. Gustavo, please check the code and see if you can improve the fix so it does not break win32. The reproduction details are in the bug 61482. -- Stanislav Malyshev, Softw

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-22 Thread Christopher Jones
On 03/22/2012 05:09 PM, Kiall Mac Innes wrote: Right - `git diff` shows the different between HEAD (The last commit of the branch your are currently on) and what you have yet to commit. I was doing the diffs compared with the origin/* branches, as shown in the gist, https://gist.github.com/21

Re: [PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-22 Thread Kiall Mac Innes
On Thu, Mar 22, 2012 at 11:24 PM, Christopher Jones < christopher.jo...@oracle.com> wrote: > 1. I had fun with a couple of small git merges today. I was trying to > use local clones as briefly outlined on irc by dsp. Multiple clones for each branch will be *much **much* harder to manage from

[PHP-DEV] Git merging fun and a local clone-per branch workflow

2012-03-22 Thread Christopher Jones
1. I had fun with a couple of small git merges today. I was trying to use local clones as briefly outlined on irc by dsp. The goal is to have different local directories for each of the three branches: 5.3, 5.4 and 'trunk'. The resulting pushes I made today are a little strange and

RE: [PHP-DEV] Override keyword

2012-03-22 Thread Dmitri Snytkine
This can be useful but I think it belongs in annotations, same as it is done in Java. Java has @override annotation which does exactly this thing and is undestood natively by Java. First the annotations should be implementend natively in php. Dmitri Snytkine Web Developer Ultra Logistics, Inc. P

[PHP-DEV] Override keyword

2012-03-22 Thread Michael Morris
Without cluttering the RFC list up further (I fear I've done too much of that with the last two bombed suggestions), I'd just like to come out and ask if the addition of an override keyword on classes had ever been considered? I'd see it as more than a self documenting thing for BC reasons than an

[PHP-DEV] Accessors v2.4 Proposed Changes

2012-03-22 Thread Clint M Priest
I've been away from this for a while and getting back to it now... Wanted to open discussion back up on these two points that Rasmus and Tom had: 1) Accessor should over-ride the __get()/__set(). If an accessor is set for a property, it would be ineligible for calling __get/__set, anyone

[PHP-DEV] SVN Account Request: maarten

2012-03-22 Thread Maarten Scholder
Derick told me to request "no karma, bug traiage only" I want to contribute to the issue tracker by reproducing/triaging/closing issues. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: com php-src: Fixed reference counting: ext/spl/spl_directory.c

2012-03-22 Thread David Soria Parra
On 2012-03-22, David Soria Parra wrote: > On 2012-03-22, Dmitry Stogov wrote: >> Commit:14af1fe6923c65a91cd77eab5a8d4326f854391d >> Author:Dmitry Stogov Thu, 22 Mar 2012 14:38:38 >> +0400 >> Parents: 523396cb28a0cb87ced9ec1179ef4f119d28ec80 >> Branches: PHP-5.3 PHP-5.4 >> > >

[PHP-DEV] Re: com php-src: Fixed reference counting: ext/spl/spl_directory.c

2012-03-22 Thread David Soria Parra
On 2012-03-22, Dmitry Stogov wrote: > Commit:14af1fe6923c65a91cd77eab5a8d4326f854391d > Author:Dmitry Stogov Thu, 22 Mar 2012 14:38:38 > +0400 > Parents: 523396cb28a0cb87ced9ec1179ef4f119d28ec80 > Branches: PHP-5.3 PHP-5.4 > why are you commiting the patch 3 times? we have a

[PHP-DEV] Remove empty / not used file

2012-03-22 Thread Laruence
Hi: I found there might be a no-use file in php-src, which is PHP-src/stub.c could we remove it? -- Laruence  Xinchen Hui http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php