Re: [PHP-DEV] Remove memory leak in PHP5.4 for bug 55971

2012-01-20 Thread Pierrick Charron
Yes :) I sent you an other mail about this bug yesterday to confirm that I can commit it. P. On 20 January 2012 13:05, Stas Malyshev wrote: > Hi! > > >> Nevery mind. Apparently Dmitry committed a patch for this one. > > > I think what he committed was a patch for another problem - double free in

Re: [PHP-DEV] Remove memory leak in PHP5.4 for bug 55971

2012-01-20 Thread Stas Malyshev
Hi! Nevery mind. Apparently Dmitry committed a patch for this one. I think what he committed was a patch for another problem - double free in traits. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Developmen

Re: [PHP-DEV] Remove memory leak in PHP5.4 for bug 55971

2012-01-20 Thread Pierrick Charron
Nevery mind. Apparently Dmitry committed a patch for this one. P. On 20 January 2012 08:04, Pierrick Charron wrote: > Ok i'll only commit it on trunk and 5.3 for right now and keep the > patch ready to apply. What about the other one I sent you (60809) ? > > On 20 January 2012 02:10, Stas Malysh

Re: [PHP-DEV] Remove memory leak in PHP5.4 for bug 55971

2012-01-20 Thread Pierrick Charron
Ok i'll only commit it on trunk and 5.3 for right now and keep the patch ready to apply. What about the other one I sent you (60809) ? On 20 January 2012 02:10, Stas Malyshev wrote: > Hi! > > >> I did run the test of bug #55871 and got memory leaks. This patch >> remove them. Could you please rev

Re: [PHP-DEV] Bug 48417 and PHP 5.4

2012-01-20 Thread Pierre Joye
hi, I'm not sure to follow you here, what did change that this issue is now a PHP problem? Felipe's fix sounds correct to me. On Fri, Jan 20, 2012 at 8:25 AM, Edward Z. Yang wrote: > Hey Pierre, > > I was wondering if you'd be willing to pitch a rollback of r300894 > post-code-freeze.  If not,

Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Yasuo Ohgaki
Hi Stats, 2012/1/20 Stas Malyshev : > I'd propose to make a binary-compatible change for 5.3 and 5.4.1, and > discuss what we do for trunk - I still like the idea of keeping less > handlers better, and if that means we can have the same patch for all > branches, then it's an added bonus. Ok, then

Re: [PHP-DEV] 64bit Windows builds

2012-01-20 Thread Pierre Joye
hi Bill, 2012/1/20 William A. Rowe Jr. : > On 1/19/2012 5:29 AM, Pierre Joye wrote: >> 2012/1/19 Ángel González : >> >>> Such binaries wouldn't be compatible with IIS, but mingw seems preferible >>> to the legacy VC6 for use with the oficial Apache binaries. > > A couple of things to remember; msv

Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Stas Malyshev
Hi! We can make new session ID in PS_OPEN_FUNC() or PS_READ_FUNC() always when ID is not already initialized one, by calling private validation function from PS_OPEN_FUNC() or PS_READ_FUNC(). However, I think it's more cleaner to keep PS module's modular architecture. Current session module's c

Re: [PHP-DEV] Code freeze for 5.4

2012-01-20 Thread Yasuo Ohgaki
Hi Stats, 2012/1/20 Stas Malyshev : > Hi! > > >> Hi Stats, >> >> Ok, I'll hold committing to 5.4, but commit it only to trunk. >> >> Any comments form anyone? for committing to trunk? >> Patch details and user land counter measure are in RFC. > > > Re-reading the discussion, I see that the questi