Re: [PHP-DEV] Urgent patch for traits in PHP 5.4

2012-01-16 Thread Stas Malyshev
Hi! Now especially for traits it delays resolution of special constant __CONST__ til run-time. Looks good, I don't see any problems with it so far. If nobody else does, let's commit it, -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PH

[PHP-DEV] Reflection to remove final

2012-01-16 Thread Jan Dolecek
Hi, reflection is a great tool for testing, but it still misses support for mocking classes/methods marked as final. I created a small patch https://gist.github.com/1621839#file_php_finals.patch, examples how to use it https://gist.github.com/1621839#file_final_test.php and wrote a short article e

Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Remi Collet
Le 16/01/2012 18:39, Ulf Wendel a écrit : > Am 16.01.2012 11:19, schrieb Remi Collet: >> P.S. well, don't know if having such a hardcoded path is a good idea... > > mysqlnd is a libmysql drop-in replacement. Guess what libmysql does... - > do "strings libmysqlclient.so | grep mysql.sock" on a stan

Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Ulf Wendel
Am 16.01.2012 11:19, schrieb Remi Collet: P.S. well, don't know if having such a hardcoded path is a good idea... mysqlnd is a libmysql drop-in replacement. Guess what libmysql does... - do "strings libmysqlclient.so | grep mysql.sock" on a standard source build. Ulf -- PHP Internals - PHP

[PHP-DEV] Output buffer bug in RC5

2012-01-16 Thread Jan Dolecek
Hi guys, I've just downloaded PHP 5.4 RC5 and noticed a problem with output buffering. I filled in a bug report (https://bugs.php.net/bug.php?id=60768) but wanna give you a quick notice, so that it gets fixed before next RC and stable won't be delayed. Test case is attached and works properly in

Re: [PHP-DEV] Urgent patch for traits in PHP 5.4

2012-01-16 Thread Florian Anderiasch
On 01/16/2012 11:25 AM, Stefan Marr wrote: > I would argue that __FILE__ and __LINE__ are not referring to conceptual > entities, but the literal code. And, I guess, they are mostly used for > debugging purposes to identify the relevant code. Thus, I would not change > them, but keep them as com

Re: [PHP-DEV] Urgent patch for traits in PHP 5.4

2012-01-16 Thread Dmitry Stogov
Hi, The updated patch is attached. Now especially for traits it delays resolution of special constant __CONST__ til run-time. Thanks. Dmitry. On 01/15/2012 06:56 AM, Stas Malyshev wrote: Hi! What would be the best approach to handle the case of property definitions? I don't think this o

Re: [PHP-DEV] Urgent patch for traits in PHP 5.4

2012-01-16 Thread Stefan Marr
Hi: On 16 Jan 2012, at 11:15, yoram bar haim wrote: > If we want __CLASS__ to be resolved at runtime (at list in case of trait), > then what about __FILE__ and __LINE__ ? should they be resolved at compile > time and reflect the original code in the trait or should they reffer to the > using c

Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Remi Collet
Le 15/01/2012 00:12, Johannes Schlüter a écrit : > In what case do you notice that? - ext/mysql, mysqli and PDO_mysql > should override that. Only case I can see would be some mysqlnd plugin > overriding the host. You're right, this patch is an old one, before bug #60155 was fixed (in r318696), a

Re: [PHP-DEV] Urgent patch for traits in PHP 5.4

2012-01-16 Thread yoram bar haim
If we want __CLASS__ to be resolved at runtime (at list in case of trait), then what about __FILE__ and __LINE__ ? should they be resolved at compile time and reflect the original code in the trait or should they reffer to the using class (which is a problem for the __LINE__ ...) ? On Monday, J