Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Александр Москалёв
oh. sorry for "where" and "from" ... from hard work brain froze With regards, Alexander Moskaliov ir...@irker.net 2011/12/2 Александр Москалёв > ($new ? new insert() : new update())->from()->where()->exec(); > >

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Александр Москалёв
($new ? new insert() : new update())->from()->where()->exec(); (same for array and callable expr) And yes, we can write it by many different ways... And yes it's not more readable than other ways BUT. As I wrote before many times - if we can add this without bc and php slowdown, user can use it

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Anthony Ferrara
>    if (!(($validator = new SomeValidator())->isValid($value))) { If you wanted to get into the whole "readable code" thoughts, that's a fubar mess. However, I can see your point and your usecase. Then again, if we're talking about OO design, that's bad in general since it creates a tight coupl

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Matthew Weier O'Phinney
On 2011-12-02, "Dmitri Snytkine" wrote: > IT would probably be even more convenient to just say > if( (new Validator())->isValid($value) ){ > > } > > No reason to just temporaraly assign $validator. Except that you can't get the validation error messages if validation fails. That was the point o

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Matthew Weier O'Phinney
On 2011-12-02, Rasmus Lerdorf wrote: > On 12/02/2011 08:50 AM, Matthew Weier O'Phinney wrote: > > if (!(($validator = new SomeValidator())->isValid($value))) { > > // Validation failed, get messages... > > $view->assign('errors' => $validator->getMessages()); > > return

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Will Fitch
That variable is used for getting error messages. Sent from my iPad On Dec 2, 2011, at 11:56 AM, Dmitri Snytkine wrote: > IT would probably be even more convenient to just say > if( (new Validator())->isValid($value) ){ > > } > > No reason to just temporaraly assign $validator. > > > > Dmitri S

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Rasmus Lerdorf
On 12/02/2011 08:50 AM, Matthew Weier O'Phinney wrote: > if (!(($validator = new SomeValidator())->isValid($value))) { > // Validation failed, get messages... > $view->assign('errors' => $validator->getMessages()); > return $view->render('error'); > } > // valida

RE: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Dmitri Snytkine
IT would probably be even more convenient to just say if( (new Validator())->isValid($value) ){ } No reason to just temporaraly assign $validator. Dmitri Snytkine Web Developer Ultra Logistics, Inc. Phone: (888) 220-4640 x 2097 Fax: (888) 795-6642 E-Mail: dsnytk...@ultralogistics.com Web: www.

Re: [PHP-DEV] 5.4's New De-referencing plus assignment

2011-12-02 Thread Matthew Weier O'Phinney
On 2011-12-01, Anthony Ferrara wrote: > On Thu, Dec 1, 2011 at 12:34 PM, Ralph Schindler > wrote: > > needs to somehow guarantee that all methods of the type $foo will return > > $this.  (BTW, this is not an argument for my feature as much as its an > > argument as much as its one for "if we're g

Re: [PHP-DEV] CI for 5.4

2011-12-02 Thread Ferenc Kovacs
On Fri, Dec 2, 2011 at 4:47 PM, Matteo Beccati wrote: > Hi, > > On 26/11/2011 01:05, Ferenc Kovacs wrote: > > FreeBSD: > > > > As I mentioned previously, the IO perf is really bad for those two vm's, > so > > if we can't find a solution, or other place to run those, I will have to > > turn those

Re: [PHP-DEV] CI for 5.4

2011-12-02 Thread Matteo Beccati
Hi, On 26/11/2011 01:05, Ferenc Kovacs wrote: > FreeBSD: > > As I mentioned previously, the IO perf is really bad for those two vm's, so > if we can't find a solution, or other place to run those, I will have to > turn those off, as they really slows down the build(they are like 5-10 > times slow

Re: [PHP-DEV] Strict session?

2011-12-02 Thread Yasuo Ohgaki
Hi Ferenc, 2011/12/2 Ferenc Kovacs : > > wouldn't it be better if we push the session id validation to the > application level? > we should provide a hook both to the C api and to > the session_set_save_handler. > of course we can additionally change the default range of valid characters > for the

Re: [PHP-DEV] Strict session?

2011-12-02 Thread Yasuo Ohgaki
Hi all, I haven't mentioned, but I'll file CVE for this because this is exploitable venerability. Unless it is filed by CVE, not many people would know the risk of adoption/fixation. There may be the entry for this, though. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Run

Re: [PHP-DEV] Strict session?

2011-12-02 Thread Ferenc Kovacs
On Fri, Dec 2, 2011 at 10:31 AM, Yasuo Ohgaki wrote: > Hi Daniel, > > 2011/12/2 Daniel K. : > > Yasuo Ohgaki wrote: > >> > >> 2011/12/2 Daniel K. : > >>> > >>> Yasuo Ohgaki wrote: > > 2011/12/2 Yasuo Ohgaki : > >>> > >>> Search for a + followed by only tabs or spaces. Empty lines should

Re: [PHP-DEV] Strict session?

2011-12-02 Thread Yasuo Ohgaki
Hi Daniel, 2011/12/2 Daniel K. : > Yasuo Ohgaki wrote: >> >> 2011/12/2 Daniel K. : >>> >>> Yasuo Ohgaki wrote: 2011/12/2 Yasuo Ohgaki : >>> >>> Search for a + followed by only tabs or spaces. Empty lines should be >>> just that, empty. >> >> >> Does CODING_STANDARDS mention this? > > > I