Re: [PHP-DEV] session.cache_limiter empty string?

2011-11-28 Thread Yasuo Ohgaki
2011/11/29 Yasuo Ohgaki : > Hi Karoly, > > 2011/10/12 Karoly Negyesi : >> Setting session.cache_limiter to an empty string doesn't send headers. >> Is this just an artefact of if (!strcasecmp(lim->name, >> PS(cache_limiter))) not matching the empty string or does if >> (PS(cache_limiter)[0] == '\0'

Re: [PHP-DEV] Strict session?

2011-11-28 Thread Yasuo Ohgaki
Hi folks, I updated wiki page to remove draft status. https://wiki.php.net/rfc/strict_sessions Any corrections and comments are appreciated. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Thoughts On Implementing Decorator Sugar to core

2011-11-28 Thread Anthony Ferrara
Comments Inline On Mon, Nov 28, 2011 at 12:57 PM, Matthew Weier O'Phinney wrote: > This seems reasonable, but there are some pretty big drawbacks as well: > >  * Type-hinting -- typically, a decorator should be able to be used >   wherever the object it decorates is used. As such, if you simply

Re: [PHP-DEV] session.cache_limiter empty string?

2011-11-28 Thread Yasuo Ohgaki
Hi Karoly, 2011/10/12 Karoly Negyesi : > Setting session.cache_limiter to an empty string doesn't send headers. > Is this just an artefact of if (!strcasecmp(lim->name, > PS(cache_limiter))) not matching the empty string or does if > (PS(cache_limiter)[0] == '\0') return 0; deliberately stop it? >

Re: [PHP-DEV] Strict session?

2011-11-28 Thread Yasuo Ohgaki
Thank you Ferenc and Hannes! -- Yasuo Ohgaki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Strict session?

2011-11-28 Thread Hannes Magnusson
On Mon, Nov 28, 2011 at 21:51, Yasuo Ohgaki wrote: > Hannes, I could edit the page once, but "save" button is disabled for > some reason. Could you check my karma? Thank you. Please fill out the large pink field called "Edit summary".. and write something in it. The save button will then be enabl

Re: [PHP-DEV] Strict session?

2011-11-28 Thread Ferenc Kovacs
> > > Hannes, I could edit the page once, but "save" button is disabled for > some reason. Could you check my karma? Thank you. you have to either provide a comment for the wiki change or check the Minor Changes checkbox to be allowed to save your work. -- Ferenc Kovács @Tyr43l - http://tyrael

Re: [PHP-DEV] Strict session?

2011-11-28 Thread Yasuo Ohgaki
Hi all, Some users that have tested this patch asked me if it's possible deleting offending cookies that enable targeted DoS attack. https://wiki.php.net/rfc/strict_sessions I would like to add patch that deletes offending cookies which may controlled by php.ini setting. I can try to delete poss

Re: [PHP-DEV] Any chance of having __invokeStatic()

2011-11-28 Thread Evan Coury
On Mon, Nov 28, 2011 at 1:11 PM, Nikita Popov wrote: > How would this be different from defining a function MyClass? Actually, I just found myself wanting this the other day. The class name in question was being defined in a config file, which the user would be free to override with their own cla

Re: [PHP-DEV] Any chance of having __invokeStatic()

2011-11-28 Thread Nikita Popov
How would this be different from defining a function MyClass? Nikita On Mon, Nov 28, 2011 at 9:02 PM, Dmitri Snytkine wrote: > I think __invokeStatic() would be a very useful magic function, especially > with support for late static binding. > you could difine it one and all sub-classes will hav

[PHP-DEV] Any chance of having __invokeStatic()

2011-11-28 Thread Dmitri Snytkine
I think __invokeStatic() would be a very useful magic function, especially with support for late static binding. you could difine it one and all sub-classes will have that option of basically being callable classes. MyClass($params) could then do some processing and return some data. This would b

[PHP-DEV] Re: Thoughts On Implementing Decorator Sugar to core

2011-11-28 Thread Matthew Weier O'Phinney
On 2011-11-23, Anthony Ferrara wrote: > I've had an idea that's been burning in my head for a while. Rather > than write an RFC or do any significant work on it, I thought I would > bounce this off of you all first. > > Basically, I see a problem with implementing decorators in PHP. Oof, yes.

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > thanks for the answer, in this case I think this would be a worthwhile > improvement. > > + foreach ($extensions as $req_ext) { > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > + if ($loaded == '0') { > > it would be more effici

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Johannes Schlüter
On Mon, 2011-11-28 at 15:02 +, Derick Rethans wrote: > On Mon, 28 Nov 2011, Johannes Schlüter wrote: > > > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > > + foreach ($extensions as $req_ext) { > > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > > + if (

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Pierre Joye
2011/11/28 Ferenc Kovacs : >>    run-tests.php -d extension=/path/to/extname.so >> > > yeah, but we advertise make test as the official/endorsed way to run the > test suite, so that should work. any reliable tests cannot be done using make test as long as there some random php.ini's in the system

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
2011/11/28 Johannes Schlüter > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > + foreach ($extensions as $req_ext) { > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > + if ($loaded == '0') { > > This should use the tmp-php.ini as that might already load the

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Johannes Schlüter wrote: > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > + foreach ($extensions as $req_ext) { > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > + if ($loaded == '0') { > > This should use the tmp-php.ini as that might

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Johannes Schlüter
On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > + foreach ($extensions as $req_ext) { > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > + if ($loaded == '0') { This should use the tmp-php.ini as that might already load the required extension if it was built in the

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
On Mon, Nov 28, 2011 at 2:44 PM, Derick Rethans wrote: > On Mon, 28 Nov 2011, Richard Quadling wrote: > > > On 28 November 2011 13:36, Derick Rethans wrote: > > > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > > > > > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans > wrote: > > >> > > >> > I'm

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Pierre Joye
hi Derick, On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > I'm currently writing a shared extension thta depends on another shared > extension (igbinary). "make test" doesn't handle this at the moment, > because it removes every extension= line from it's temporary php.ini. > This means

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Richard Quadling wrote: > On 28 November 2011 13:36, Derick Rethans wrote: > > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > > > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > >> > >> > I'm currently writing a shared extension thta depends on another > >> > shared

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Richard Quadling
On 28 November 2011 13:36, Derick Rethans wrote: > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: >> >> > I'm currently writing a shared extension thta depends on another >> > shared extension (igbinary). "make test" doesn't handle this at th

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > > > I'm currently writing a shared extension thta depends on another > > shared extension (igbinary). "make test" doesn't handle this at the > > moment, because it removes every extension= line

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > Hi, > > I'm currently writing a shared extension thta depends on another shared > extension (igbinary). "make test" doesn't handle this at the moment, > because it removes every extension= line from it's temporary php.ini. > This means that

[PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
Hi, I'm currently writing a shared extension thta depends on another shared extension (igbinary). "make test" doesn't handle this at the moment, because it removes every extension= line from it's temporary php.ini. This means that the dependent extension (igbinary) now isn't loaded, which means