[PHP-DEV] missing docs for 5.4

2011-11-22 Thread Stas Malyshev
Hi! We're still missing some docs for new 5.4 stuff, and I think it'd be great to have it covered by the time of the release. These parts are completely missing from the manual: - Syntax: Short array notation, callable type in function args - Classes: ReflectionZendExtension, SessionHandler

[PHP-DEV] intl IDNA patch (was: Re: [PECL-DEV] libidn2 extension for php)

2011-11-22 Thread Stas Malyshev
Hi! First of all, I would like to politely ask everybody on the list to change subject if, well, subject of the discussion changes. I was totally under impression that this topic still discusses libidn2 extension in PECL and might miss discussion about intl IDNA patch if David didn't point it

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-22 Thread Stas Malyshev
Hi! On 11/22/11 6:36 PM, Etienne Kneuss wrote: PEAR is definitely doing some strange things :) Is it checking indices of a variables without checking first if it's an array? Sounds like the comeback of "Please don't break bad code!" seen with is_a :) I think somebody should start a code cleanu

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-22 Thread Etienne Kneuss
On Wed, Nov 23, 2011 at 03:31, Daniel Convissor wrote: > Hi Etienne: > >> AFAIK this is one of the change that was explicitly put in to make it >> more consistent. > > But now it breaks code in the wild.  I came across this due to an > isset() in PEAR now passing when it didn't before. PEAR is de

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-22 Thread Daniel Convissor
Hi Etienne: > AFAIK this is one of the change that was explicitly put in to make it > more consistent. But now it breaks code in the wild. I came across this due to an isset() in PEAR now passing when it didn't before. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-22 Thread Etienne Kneuss
Hi, AFAIK this is one of the change that was explicitly put in to make it more consistent. Before, you had: $string = "asd"; $string[0] == "a" but: $string[0][0] == Fatal: cannot use string offset as an array while $string[0] == "a", it makes no sense for $string[0][0] not to return "a" again,

[PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-22 Thread Daniel Convissor
Hi Folks: I just stumbled upon a regression in 5.4. In an array, a sub-sub-key of an existing key is now returning a letter of the value indexed by the main key. I'm raising it here so it doesn't get lost. https://bugs.php.net/bug.php?id=60362 Thanks, --Dan -- T H E A N A L Y S I S A N

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Ferenc Kovacs
On Wed, Nov 23, 2011 at 1:46 AM, Yasuo Ohgaki wrote: > Ferenc, > > I can login to wiki, but cannot write to the page. > > https://wiki.php.net/rfc/strict_sessions > > Could you update the page with attached file? > > Thank you. > > -- > Yasuo Ohgaki > Sure, Hannes, could you please give karma t

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Yasuo Ohgaki
Ferenc, I can login to wiki, but cannot write to the page. https://wiki.php.net/rfc/strict_sessions Could you update the page with attached file? Thank you. -- Yasuo Ohgaki == Request for Comments: Strict Sessions == * Version: 0.1 * Date: 2011-11-23 * Author: Yasuo Ohgaki * S

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-22 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/21/2011 01:23 PM, Pierre Joye wrote: > hi, > > After a short talk on IRC, we agreed to go with the solution 1. > > David, Stas, any objection for 5.4? As it adds a new feature it is > actually a bug fix too. - From my side it's okay to add it

[PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-22 Thread David Soria Parra
On 2011-11-21, "Gustavo Lopes" wrote: > > -static void php_intl_idn_to(INTERNAL_FUNCTION_PARAMETERS, int mode) > +/* like INTL_CHECK_STATUS, but as a function and varying the name of the > func */ > +static int php_intl_idn_check_status(UErrorCode err, const char *msg, int > mode TSRMLS_DC) >

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Yasuo Ohgaki
2011/11/23 Ferenc Kovacs :>>> It will save much time if I don't have to write wiki for rfc. >> >> Please add at least the contents of your email to an RFC so there is >> some description that doesn't require trawling through mail archives >> to find. Thank you. I see you've made new page. I'll add

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Ferenc Kovacs
On Wed, Nov 23, 2011 at 12:31 AM, Christopher Jones < christopher.jo...@oracle.com> wrote: > > > On 11/22/2011 02:51 PM, Yasuo Ohgaki wrote: > > It will save much time if I don't have to write wiki for rfc. >> > > Please add at least the contents of your email to an RFC so there is > some descrip

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Christopher Jones
On 11/22/2011 02:51 PM, Yasuo Ohgaki wrote: It will save much time if I don't have to write wiki for rfc. Please add at least the contents of your email to an RFC so there is some description that doesn't require trawling through mail archives to find. Chris -- Email: christopher.jo...@ora

Re: [PHP-DEV] Strict session?

2011-11-22 Thread Yasuo Ohgaki
Hi all, I've made the patch for trunk. I checked by using session module tests using valgrind. https://gist.github.com/1379668 This patch adds - validate_sid() to ps_modules (Save handlers) - use_strict_session to php.ini (On by default, off for old behavior) - display that save handler suppo

Re: [PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch

2011-11-22 Thread Yasuo Ohgaki
Hi, Thanks for the comments. 2011/11/22 Rafael Kassner : > I've ported everything > to UTF-8 (this included rewrite a 8 years old application). I guess > this is a good implementation, considering that many people still use > old PostgreSQL versions. I think so, too. Database server's (and it's

Re: [PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch

2011-11-22 Thread Daniel Convissor
Hi Yasuo: > I've posted pgsql patch that adds > pg_escape_literal()/pg_escape_identifier() pg_escape_identifier() sounds good. Regarding pg_escape_literal(), which implements PQescapeLiteral, it is very similar to PHP's pg_esacpe_string(), implementing PQescapeStringConn. What is the benefit of

Re: [PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch

2011-11-22 Thread Rafael Kassner
Amazing! I was in big troubles with multibyte escaping a couple years ago. Nowadays, after a big ship of encoding problems (not only with db, but navigator encoding, proxy caching and so on), I've ported everything to UTF-8 (this included rewrite a 8 years old application). I guess this is a good