Re: [PHP-DEV] some notes about traits

2011-11-15 Thread Christopher Jones
On 11/15/11 4:17 PM, Rasmus Schultz wrote: So I guess my remaining quibble is that the documentation needs to relay this somehow - with a basic real-world example that actually uses an interface too, to clarify the difference, and to demonstrate how this tool use useful in conjunction with cla

Re: [PHP-DEV] some notes about traits

2011-11-15 Thread Rasmus Schultz
Hi Stefan, Appreciate you taking the time to discuss this - and I apologize if I jumped the gun with some of these comments. I knew about the traits features in Scala, and I guess I assumed this would be similar - not so. Reading through my own remarks and your comments, I now have a better unde

Re: [PHP-DEV] session_regenerate_id() not replacing Set-Cookie header

2011-11-15 Thread Patrick ALLAERT
2011/11/15 Paul Dragoonis : > On Tue, Nov 15, 2011 at 10:09 PM, Patrick ALLAERT > wrote: >> Hello, >> >> Calling session_regenerate_id() inside a same request will generate >> multiple Set-Cookie headers >> >> example code: >> > session_start(); >> session_regenerate_id(); >> session_regenerate_id

Re: [PHP-DEV] remove FPM experimental flag on 5.4

2011-11-15 Thread Jérôme Loyet
Le 4 juillet 2011 11:42, Adam Harvey a écrit : > > On Jul 2, 2011 11:27 PM, "Jérôme Loyet" wrote: >> I'd like to remove the FPM experimental flag in 5.4 and trunk. What do >> you think ? >> >> Maybe this needs a rfc/vote. > > I don't think it does, really. FPM has been in for a while, works well,

Re: [PHP-DEV] session_regenerate_id() not replacing Set-Cookie header

2011-11-15 Thread Paul Dragoonis
On Tue, Nov 15, 2011 at 10:09 PM, Patrick ALLAERT wrote: > Hello, > > Calling session_regenerate_id() inside a same request will generate > multiple Set-Cookie headers > > example code: > session_start(); > session_regenerate_id(); > session_regenerate_id(); > ?> > > will result in, e.g.: > Set-C

[PHP-DEV] session_regenerate_id() not replacing Set-Cookie header

2011-11-15 Thread Patrick ALLAERT
Hello, Calling session_regenerate_id() inside a same request will generate multiple Set-Cookie headers example code: will result in, e.g.: Set-Cookie: PHPSESSID=d8afvidkqp9jd4kns8ij976o72; path=/ Set-Cookie: PHPSESSID=lkjla7kvotnfhutb43llcirj61; path=/ As per rfc6265, it seems incorrect: "Serv

Re: [PHP-DEV] get_magic_quotes_gpc() throws deprecated warning in 5.4

2011-11-15 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I committed zuelke's patch. On 11/15/2011 02:23 PM, Pierrick Charron wrote: > I also worked on the patch and I agree this is just an error :) I > can do the change if you want. > > Pierrick > > On 15 November 2011 07:51, David Soria Parra wrote: >

Re: [PHP-DEV] get_magic_quotes_gpc() throws deprecated warning in 5.4

2011-11-15 Thread Pierre Joye
go ahead! On Tue, Nov 15, 2011 at 2:23 PM, Pierrick Charron wrote: > I also worked on the patch and I agree this is just an error :) I can > do the change if you want. > > Pierrick > > On 15 November 2011 07:51, David Soria Parra wrote: >> On 2011-11-12, David Zülke wrote: >>> Had a few other t

Re: [PHP-DEV] get_magic_quotes_gpc() throws deprecated warning in 5.4

2011-11-15 Thread Pierrick Charron
I also worked on the patch and I agree this is just an error :) I can do the change if you want. Pierrick On 15 November 2011 07:51, David Soria Parra wrote: > On 2011-11-12, David Zülke wrote: >> Had a few other tests failing, updated those accordingly and attached a >> newer version. > > Acc

Re: [PHP-DEV] get_magic_quotes_gpc() throws deprecated warning in 5.4

2011-11-15 Thread David Soria Parra
On 2011-11-12, David Z?lke wrote: > Had a few other tests failing, updated those accordingly and attached a newer > version. According to the RFC it should not throw an error, so I think your patch is fine. If Pierre, who implemented it, doesnt have an objection I'll commit your patch tomorrow

Re: [PHP-DEV] Wrong/outdated usernames in SVNROOT/global_avail

2011-11-15 Thread Pierre Joye
On Sat, Nov 12, 2011 at 1:56 AM, Florian Anderiasch wrote: > Some are typos I think (sascha -> sas, pierre -> pajoye, ilia -> iliaa), > others I haven't checked. I fixed those, thanks :) -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime De