Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Nicolas Grekas
> What I am really hearing in this thread is some people have interest in a > way to easily access the __COMPILER_HALT_OFFSET__ Well, not exactly for me : I'm not interested strictly on getting the offset. I'm more interested in doing generic static code analysis, and part of that is getting the

[PHP-DEV] Re: PHP 5.4.0beta1 released

2011-09-15 Thread David Soria Parra
On 2011-09-16, David Soria Parra wrote: > Hello! > > Stas has packed PHP 5.4.0beta1 which you can find here: > > http://downloads.php.net/stas/ > > The Windows team provides windows binaries which you find here: > > http://windows.php.net/qa/ > > Please test it carefully, and report any bu

[PHP-DEV] PHP 5.4.0beta1 released

2011-09-15 Thread David Soria Parra
Hello! Stas has packed PHP 5.4.0beta1 which you can find here: http://downloads.php.net/stas/ The Windows team provides windows binaries which you find here: http://windows.php.net/qa/ Please test it carefully, and report any bugs in the bug system, but only if you have a short reprodu

Re: [PHP-DEV] A couple of missing directories if configure.js is forgotten.

2011-09-15 Thread Pierre Joye
hi Richard, Can you open a bug for each of your patches please? Thanks! 2011/9/15 Ángel González : > Richard Quadling wrote: >> >> Hi. >> >> Sometimes I remove Release prior to nmake to make sure everything builds >> clean. >> >> 2 directories fail to get build >> >> Release\win32 >> Release\deve

Re: [PHP-DEV] A couple of missing directories if configure.js is forgotten.

2011-09-15 Thread Ángel González
Richard Quadling wrote: Hi. Sometimes I remove Release prior to nmake to make sure everything builds clean. 2 directories fail to get build Release\win32 Release\devel The attached patch fixes that. - @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %D @mkdir %D> NUL + @for %D in

Re: [PHP-DEV] 5.4 beta

2011-09-15 Thread Pierre Joye
On Thu, Sep 15, 2011 at 11:42 PM, Stas Malyshev wrote: > The problem is data may vary by CLDR version, etc. and keeping pace with all > variants on all platforms, etc. will be a nightmare. To have a couple of versions, say x.y, x.y+1 sounds reasonable and possible. Cheers, -- Pierre @pierrejo

Re: [PHP-DEV] 5.4 beta

2011-09-15 Thread Stas Malyshev
Hi! On 9/15/11 2:39 PM, Pierre Joye wrote: We do need tests per version. The EXPECTF- becomes more and more necessary :) The problem is data may vary by CLDR version, etc. and keeping pace with all variants on all platforms, etc. will be a nightmare. -- Stanislav Malyshev, Software Architect

Re: [PHP-DEV] 5.4 beta

2011-09-15 Thread Pierre Joye
On Thu, Sep 15, 2011 at 9:08 PM, Stas Malyshev wrote: > Hi! > > On 9/14/11 1:25 AM, Hannes Magnusson wrote: >> >> Could you look at the intl tests? >> I have similar failures the the gcov, plus couple of more I sent you >> the other day. > > Yes, I will. From casual look it seems like they are cau

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Chris Stockton
Hello, On Thu, Sep 15, 2011 at 8:13 AM, Nikita Popov wrote: > On Thu, Sep 15, 2011 at 5:05 PM, Hannes Magnusson > wrote: >> Wait wait wait. Thats the point here? >> __COMPILER_HALT_OFFSET__ already tells you where the data starts. > __COMPILER_HALT_OFFSET__ tells you the offset if you are runnin

Re: [PHP-DEV] 5.4 beta

2011-09-15 Thread Stas Malyshev
Hi! On 9/14/11 1:25 AM, Hannes Magnusson wrote: Could you look at the intl tests? I have similar failures the the gcov, plus couple of more I sent you the other day. Yes, I will. From casual look it seems like they are caused by variation between ICU versions, I'll look into how to make tests

Re: [PHP-DEV] Running mhash tests

2011-09-15 Thread Alexey Shein
It's very strange but after 5-6 recompiles with different configurations (I tried to reduce "breaking" setup) my current configuration started to work itself. Thanks everybody for help. 2011/9/15 Scott MacVicar : > > On 14 Sep 2011, at 13:46, Alexey Shein wrote: > >> 2011/9/15 Pierre Joye : >>> h

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Nikita Popov
On Thu, Sep 15, 2011 at 5:05 PM, Hannes Magnusson wrote: > Wait wait wait. Thats the point here? > __COMPILER_HALT_OFFSET__ already tells you where the data starts. __COMPILER_HALT_OFFSET__ tells you the offset if you are running the file. It is only available in the file that does the actual __ha

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Hannes Magnusson
On Thu, Sep 15, 2011 at 16:51, Nikita Popov wrote: > Hi Hannes, thanks for your response! > > On Thu, Sep 15, 2011 at 9:22 AM, Hannes Magnusson > wrote: >> the change to ext/tokenizer/tests/token_get_all_variation16.phpt seems >> really weird? > I changed the test to not include a __halt_compiler

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Nikita Popov
Hi Hannes, thanks for your response! On Thu, Sep 15, 2011 at 9:22 AM, Hannes Magnusson wrote: > the change to ext/tokenizer/tests/token_get_all_variation16.phpt seems > really weird? I changed the test to not include a __halt_compiler statement anymore, as it didn't make sense in this context, an

[PHP-DEV] A couple of missing directories if configure.js is forgotten.

2011-09-15 Thread Richard Quadling
Hi. Sometimes I remove Release prior to nmake to make sure everything builds clean. 2 directories fail to get build Release\win32 Release\devel The attached patch fixes that. Index: win32/build/Makefile === --- win32/build/Makefil

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-15 Thread Pierre Joye
On Thu, Sep 15, 2011 at 12:07 PM, Hannes Magnusson wrote: > Running tests exclusively in an environment known to work doesn't help us. It indeed does, and much more than random failures in random environments. However it is not about one or the other, it is about both and about having as much t

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-15 Thread Hannes Magnusson
On Wed, Sep 14, 2011 at 12:36, Alexey Shein wrote: > 2011/9/14 Ferenc Kovacs : >>> >>> Why do we even have this tmp-php.ini? Why not just make test without >>> any .ini files, i.e. just with -n option? >> >> [20:44:09] Tyrael: tmp-php.ini is built from the system ini >> [20:44:45] Tyrael: if he

[PHP-DEV] SVN Account Request: bappidgreat

2011-09-15 Thread Ashok Kumar Nath
Developing the PHP runtime -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Revert Tokenizer behavior for 5.4

2011-09-15 Thread Hannes Magnusson
On Tue, Sep 13, 2011 at 22:08, Ferenc Kovacs wrote: > On Tue, Sep 13, 2011 at 9:56 PM, Christopher Jones > wrote: >> >> >> On 09/13/2011 12:25 PM, Nikita Popov wrote: >>> >>> I changed my previous patch to an SVN patch, so it is easier to apply >>> and added another patch (the one called "tokeniz