Hi Flavius,
Unfortunately, the proposed fix is wrong.
It changes the operators precedence and it's definitely wrong.
I suppose the crash caused by side effect of some other bug.
Try to run the same script with valgrind.
Thanks. Dmitry.
On 09/11/2011 02:27 PM, Flavius Aspra wrote:
Hi
I think
I definitely agree that the problem is with a mis-configured FTP server
returning a private RFC1918 IP address. That would happen if the FTP
server was on a server behind a NAT gateway and the server only knew
about it's local RFC1918 IP address and not it's internet-routable IP
address. Howeve
hmm, after deep looking, I found maybe this behavior(cann't connect
to NAT server when use pasv mode) is "as expected",
since this is not php ftp-ext issue, but a ftp server configure issue,
that is, if we apply this patch, will make the php ftp-ext not a
standard ftp protocl executor.
thanks
2011/9/12 Avi Brender :
> Hi,
>
> Please see if the attached patch better addresses your concerns.
>
> Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal
> and is modeled after the other variables PHP_FTP_TIMEOUT_SEC and
> PHP_FTP_OPT_AUTOSEEK. The variable actually passed
Hi,
Please see if the attached patch better addresses your concerns.
Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only
internal and is modeled after the other variables PHP_FTP_TIMEOUT_SEC
and PHP_FTP_OPT_AUTOSEEK. The variable actually passed to the
ftp_set_option() functio
Hi,
On Sun, 2011-09-11 at 23:26 +0100, Gustavo Lopes wrote:
> On Sun, 11 Sep 2011 20:26:20 +0100, Sebastian Bergmann
> wrote:
>
> > [...]
> > --
> > [1] https://wiki.php.net/rfc/streamwrapper-factory
> > [2] http://schlueters.de/~johannes/php/stream_factory.diff
> >
>
> A patch against tr
On Sun, 11 Sep 2011 20:26:20 +0100, Sebastian Bergmann
wrote:
[...]
--
[1] https://wiki.php.net/rfc/streamwrapper-factory
[2] http://schlueters.de/~johannes/php/stream_factory.diff
A patch against trunk (or 5.4) would have been nicer. Other than that:
* This patch has a huge BC:
PHP
On Sun, Sep 11, 2011 at 11:04 PM, Stas Malyshev wrote:
> Hi!
>
> On 9/11/11 8:44 AM, Ferenc Kovacs wrote:
>>
>> AFAIK you shoud get it(as I did on my debian machines), as both
>> display_startup_errors and error_reporting is force enabled for the
>> tests:
>> http://svn.php.net/viewvc/php/php-src/
Hi,
Am 11.09.2011 23:40, schrieb Anthony Ferrara:
So, based on the rfc, does "must return an instance" mean that it can't
throw an exception (ex: if a resource couldn't be opened)?
A resource is opened on `streamWrapper::dir_opendir()` or
`streamWrapper::stream_open()` anyway, but not on Wrap
So, based on the rfc, does "must return an instance" mean that it can't
throw an exception (ex: if a resource couldn't be opened)?
On Sep 11, 2011 3:26 PM, "Sebastian Bergmann" wrote:
> We (Arne Blankerts, Stefan Priebsch, Benjamin Eberlei, and I) have
> worked on/with code where a factory for str
Flavius Aspra wrote:
Hi
I think I've found a bug in the engine, and I think it occures only
with the latest gcc ("gcc version 4.6.1 20110819 (prerelease)"), since
it used to work with earlier versions.
For example line 867
http://lxr.php.net/opengrok/xref/PHP_5_3/Zend/zend_execute_API.c#867
Hi!
On 9/11/11 8:44 AM, Ferenc Kovacs wrote:
AFAIK you shoud get it(as I did on my debian machines), as both
display_startup_errors and error_reporting is force enabled for the
tests:
http://svn.php.net/viewvc/php/php-src/trunk/run-tests.php?view=markup#l232
http://svn.php.net/viewvc/php/php-src
hi!
Please upload the patch in the bug tracker as well.
It would be also better to use a more verbose name.
FTP_OPT_USEPASVADDRESS is somehow cryptic.
Laruence's comment is still valid, the zval should be converted if it
is not int or bool.
Btw, could you test cases as well please?
Cheers,
On
Hi,
I've updated the patch - please see attached.
Avi Brender
Elite Hosts, Inc
www.elitehosts.com
WARNING !!! This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged information.
Any unauth
We (Arne Blankerts, Stefan Priebsch, Benjamin Eberlei, and I) have
worked on/with code where a factory for stream wrappers would be very
helpful.
Earlier this year we talked to Ilia about this at ConFoo and he was open
to the idea but did not have the time to implement it. At FrOSCon we
talk
On Sat, Sep 10, 2011 at 8:46 PM, Stas Malyshev wrote:
> Hi!
>>
>> care to comment?
>
> It looks like neither me nor others (inluding gcov machine) are getting that
> message.
>
AFAIK you shoud get it(as I did on my debian machines), as both
display_startup_errors and error_reporting is force enab
hi,
A simple test if it is IS_BOOL or IS_LONG should be enough, both types
use the the long value (convert_to_boolean_ex is slow and duplicate
the zval while it is not necessary). Then test > 0 instead of simply
assigning the value.
On Sun, Sep 11, 2011 at 5:59 AM, Laruence wrote:
> Hi:
> aft
Hi
I think I've found a bug in the engine, and I think it occures only with
the latest gcc ("gcc version 4.6.1 20110819 (prerelease)"), since it
used to work with earlier versions.
For example line 867
http://lxr.php.net/opengrok/xref/PHP_5_3/Zend/zend_execute_API.c#867
should be
&& P
Am 11.09.2011 06:31, schrieb Rui Hirokawa:
> Hello,
>
> I think the second argument of parse_str/mb_parse_str
> should be changed from optional to mandatory.
> parse_str(string encoded_string [, array result])
> -> parse_str(string encoded_string , array result)
no because there is no reason an
Hi!
On 9/8/11 12:04 PM, Benjamin Eberlei wrote:
I would like to mention this segfault that i am having with 5.4 alpha 3:
https://bugs.php.net/bug.php?id=55578
The reproduce case is trivial (thanks to Felipe and Tyrael for improving it
even more)
FWIW, was unable to reproduce it on Darwin with
Hi!
On 9/10/11 9:31 PM, Rui Hirokawa wrote:
I think the second argument of parse_str/mb_parse_str
should be changed from optional to mandatory.
This would create BC problems.
You can mess up you code with any function, I do not think it warrants
BC break.
--
Stanislav Malyshev, Software Arch
21 matches
Mail list logo
