Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Joey Smith
On Sat, Aug 06, 2011 at 08:07:01PM -0700, Rasmus Lerdorf wrote: > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Ronald Chmara
On Mon, Aug 8, 2011 at 6:52 PM, Larry Garfield wrote: > A previous poster claimed that a DVCS would lead to confusion as to what the > canonical repository was.  That is, in my experience, a common fear of > someone who has not used a DVCS in production. Disclaimer: I haven't committed to PHP in

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Joey Smith
On Mon, Aug 08, 2011 at 10:44:12AM -0700, Stas Malyshev wrote: > Hi! > > On 8/8/11 9:34 AM, Johannes Schlüter wrote: > > * It is said that the preferred way to get a patch from one branch > > to another is by doing a merge operation in the VCS. Depending > > on the timing we

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Joey Smith
On Sun, Aug 07, 2011 at 04:50:55PM -0400, David Soria Parra wrote: > Hi Internals, > > NOTE: this is not the place for any religiouise discussion about git vs > mercurial whatsover. if you have nothing else to add than "hg is $*** > anyway" or think hosting platform XY will solve all our problems

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Larry Garfield
On 08/07/2011 04:24 PM, Stas Malyshev wrote: Hi! As somebody that have seen reasonably big project switch from SVN to git and worked quite actively with git since then, I think describing my experience might be useful for those that never tried it. 1. git is much better than svn especially a

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread dukeofgaming
Hi, very glad this topic has resurfaced and I honesly think using a DVCS will be a game-changer for PHP. Just wanted to drop a couple of answers I've dedicated some time in at SE, several diagrams, to-point explanations and references that might be of uso to clear out introductory topics. http://p

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread David Muir
On 09/08/11 01:07, Lester Caine wrote: > David Muir wrote: >> John Szakmeister, who is a Subversion developer himself, has a good >> comparison of svn, hg, bzr and git: >> http://www.szakmeister.net/blog/2011/feb/17/choosing-new-version-control-system/ >> >> >> Long story short, his company went wi

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
#yay Packages now build again on http://apt.damz.org/ Damien On Mon, Aug 8, 2011 at 6:49 PM, Ilia Alshanetsky wrote: > Different error, fixed now as well. > > On Mon, Aug 8, 2011 at 12:39 PM, Damien Tournoud wrote: >> Thanks for the fix, but it is still failing in xsltprocessor.c, as far >> as

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Stas Malyshev
Hi! On 8/8/11 9:34 AM, Johannes Schlüter wrote: * It is said that the preferred way to get a patch from one branch to another is by doing a merge operation in the VCS. Depending on the timing we will most likely end up with two (trunk + 5.4) or, more likely, thr

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Ilia Alshanetsky
Different error, fixed now as well. On Mon, Aug 8, 2011 at 12:39 PM, Damien Tournoud wrote: > Thanks for the fix, but it is still failing in xsltprocessor.c, as far > as I can tell: > > /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c: In function > 'xsl_ext_function_php': > /tmp/buildd/php5

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
Thanks for the fix, but it is still failing in xsltprocessor.c, as far as I can tell: /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_php': /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:242: warning: pointer targets in initialization differ in signednes

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Johannes Schlüter
On Sun, 2011-08-07 at 16:50 -0400, David Soria Parra wrote: > I was asked to put together a RFC, and so here we are. I've created > an initial draft. It is mostly based on the very good Python PEP-0374. > It compares Git and Mercurial. > > https://wiki.php.net/rfc/dvcs Two comments: *

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Ilia Alshanetsky
Thanks, I've just applied a fix for this. On Mon, Aug 8, 2011 at 10:45 AM, Damien Tournoud wrote: > Just FYI, this commit broke the build: > >  http://svn.php.net/viewvc?view=revision&revision=314515 > > One occurrence as been missed in: > >  ext/xsl/xsltprocessor.c:                        DOM_RE

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Lester Caine
David Muir wrote: John Szakmeister, who is a Subversion developer himself, has a good comparison of svn, hg, bzr and git: http://www.szakmeister.net/blog/2011/feb/17/choosing-new-version-control-system/ Long story short, his company went with git. Makes good reading ... many other comparisons

Re: [PHP-DEV] Reflection, Traits, Aliasing

2011-08-08 Thread Keloran
There seems to be a bug in traits that if you use any of the GLOBAL vars it segfaults e.g. getStuff("tester"); } } that causes a segfault change the trait to wrote: > On 07/25/2011 02:05 PM, Stefan Marr wrote: > > Hi Johannes: > > > > 2011/7/25 Johannes Schlüter : > > > >> Now I use reflecti

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Ferenc Kovacs
On Sun, Aug 7, 2011 at 10:50 PM, David Soria Parra wrote: > Hi Internals, > > Distributed Version Control Systems (DVCS) getting more and more > popular. In fact they have been discussed within the PHP community and > on Internals a few times. It came to my attention that more and more > people li

[PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
Just FYI, this commit broke the build: http://svn.php.net/viewvc?view=revision&revision=314515 One occurrence as been missed in: ext/xsl/xsltprocessor.c:DOM_RET_OBJ(rv, (xmlNodePtr) newdocp, &ret, NULL); Reference: https://drupaltesting.org/jenkins/job/php5.4-build/2

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Lester Caine
David Muir wrote: I'm only reverting a single commit rather than having to weed through the tree to find all the commits that need to be reversed. And if I'm "doing it wrong™", please let me know off list how I can improve things. I think this a general problem with DVCS method of working? At l

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread David Muir
On 08/08/11 07:37, Richard Riley wrote: > David Soria Parra writes: > >> On 2011-08-07, Stas Malyshev wrote: >>> Hi! >>> >>> As somebody that have seen reasonably big project switch from SVN to git >>> and worked quite actively with git since then, I think describing my >>> experience might be

Re: [PHP-DEV] getopt bc break 5.2 -> 5.3

2011-08-08 Thread Martin Spütz
On 08.08.2011 14:09, Richard Quadling wrote: > Can you try ... > > php test.php -- Module.Controller.Action -p foobar I tried $ php test.php -p foobar -- Module.Controller.Action that gave me: array(1) { ["p"]=> string(6) "foobar" } But that doesn't help me much. I could add a prepend_fil

Re: [PHP-DEV] getopt bc break 5.2 -> 5.3

2011-08-08 Thread Richard Quadling
On 8 August 2011 12:40, Martin Spütz wrote: > Hello, > > I have a lot legacy code that doesn't work with 5.3's getopt. > > PHP 5.2.14 (cli) (built: Sep 24 2010 12:50:53) > > $ php test.php Module.Controller.Action -p foobar > array(1) { >  ["p"]=> >  string(6) "foobar" > } > > PHP 5.3.6 (cli) (bui

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Ivan Enderlin @ Hoa
On 08/08/11 13:16, Paul Dragoonis wrote: On Mon, Aug 8, 2011 at 12:06 PM, Alexey Shein wrote: I think it's just a bad habit inherited from Javascript, where you can do like this: var a = function(a, b) { }; alert(a.length); // shows 2 I don't think that PHP needs it, explicit method is way bet

[PHP-DEV] getopt bc break 5.2 -> 5.3

2011-08-08 Thread Martin Spütz
Hello, I have a lot legacy code that doesn't work with 5.3's getopt. PHP 5.2.14 (cli) (built: Sep 24 2010 12:50:53) $ php test.php Module.Controller.Action -p foobar array(1) { ["p"]=> string(6) "foobar" } PHP 5.3.6 (cli) (built: Aug 8 2011 11:02:31): $ php test.php Module.Controller.Acti

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Paul Dragoonis
On Mon, Aug 8, 2011 at 12:06 PM, Alexey Shein wrote: > I think it's just a bad habit inherited from Javascript, where you can > do like this: > var a = function(a, b) { }; > alert(a.length); // shows 2 > > I don't think that PHP needs it, explicit method is way better. I am agreeing with the fac

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Alexey Shein
I think it's just a bad habit inherited from Javascript, where you can do like this: var a = function(a, b) { }; alert(a.length); // shows 2 I don't think that PHP needs it, explicit method is way better. 2011/8/8 Sebastian Bergmann : > On 08/08/2011 04:49 AM, Etienne Kneuss wrote: >> >> I don't

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Sebastian Bergmann
On 08/08/2011 04:49 AM, Etienne Kneuss wrote: I don't believe Countable implies ArrayAccess, but I do think that Countable should only be implemented in cases where it is obvious what it will return, for example collections. In this case, count(Closure) is really not that explicit, I'd rather ha

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Ilia Alshanetsky
Scott, I've looked through most of the changes (some are even mine ;-) ) and they seem to be fairly harmless initialization tweaks etc... As it stands I think we should be in good shape to package 5.3.7 on Wed and finally get it out of the door. On Mon, Aug 8, 2011 at 3:18 AM, Scott MacVicar wro

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Etienne Kneuss
Hello, 2011/8/8 Johannes Schlüter : > On Mon, 2011-08-08 at 09:16 +0200, Ivan Enderlin @ Hoa wrote: >> Hi Internals, >> >> I would like to suggest you a new feature (for PHP5.4 or maybe next). >> The idea is to implement the \Countable interface into closures to >> easily count the arguments numbe

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Ivan Enderlin @ Hoa
On 08/08/11 09:45, Johannes Schlüter wrote: On Mon, 2011-08-08 at 09:16 +0200, Ivan Enderlin @ Hoa wrote: Hi Internals, I would like to suggest you a new feature (for PHP5.4 or maybe next). The idea is to implement the \Countable interface into closures to easily count the arguments number. NO

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Lester Caine
Stas Malyshev wrote: On 8/7/11 5:46 PM, Lester Caine wrote: Use git. And stick two fingers up at the windows developer base ;) What's the problem with git and windows? I understand there is a good GUI-installable package with all needed and everything works just fine - at least I know people

Re: [PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Johannes Schlüter
On Mon, 2011-08-08 at 09:16 +0200, Ivan Enderlin @ Hoa wrote: > Hi Internals, > > I would like to suggest you a new feature (for PHP5.4 or maybe next). > The idea is to implement the \Countable interface into closures to > easily count the arguments number. NO! One could add a getParmNo() or su

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Scott MacVicar
On 6 Aug 2011, at 20:07, Rasmus Lerdorf wrote: > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have Coverity account

[PHP-DEV] Add \Countable support to \Closure

2011-08-08 Thread Ivan Enderlin @ Hoa
Hi Internals, I would like to suggest you a new feature (for PHP5.4 or maybe next). The idea is to implement the \Countable interface into closures to easily count the arguments number. I know that it is already possible with reflection [1] but it could be a comfortable trick I think. Subsidi

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Ryan McCue
Kiall Mac Innes wrote: > Later on in the doc, you go into detail about submodules, and CRLF -> LF > support in both Git and Hg. To be fair, submodules don't work exactly the same. Unlike svn:externals, which are linked to a repository, submodules are linked to a repository *and a commit*. That mea

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-08 Thread Ryan McCue
Lester Caine wrote: > Richard Riley wrote: >> Its really simple. >> >> Use git. > And stick two fingers up at the windows developer base ;) The CLI works exactly the same as on any other platform, and the graphical tools are fairly good. I've found that they're at least as good as Hg's Windows too