[PHP-DEV] [VOTE]strn(case)cmp supporting a negative length as its third paramter

2011-07-31 Thread Laruence
Hi everyone: plz vote for this : "strn(case)cmp supporting a negative length as its third paramter" RFC: https://wiki.php.net/rfc/strncmpnegativelen#vote if you have any objection, plz write back. thanks -- Laruence  Xinchen Hui http://www.laruence.com/ -- PHP Internals - PHP Runtim

[PHP-DEV] 5.4 alpha3

2011-07-31 Thread Stas Malyshev
Hi! The next alpha release - alpha3 - is planned for Aug 4, this Thursday. If you have something pending - please act accordingly. If we could have TODO list items in (https://wiki.php.net/todo/php54) it'd be nice. Also a bit of attention to failed tests (we have a number in date handling, pha

Re: [PHP-DEV] [RFC] Weak References

2011-07-31 Thread Stas Malyshev
Hi! On 7/31/11 6:59 PM, Hannes Landeholm wrote: Hi, I'd like to initiate voting on this RFC today since the minimum period of two weeks has now passed. Can someone with the right wiki powers/responsibilities start a vote and announce the [VOTE] on the mailing list? I think I'm missing some im

Re: [PHP-DEV] [RFC] Weak References

2011-07-31 Thread Hannes Landeholm
Hi, I'd like to initiate voting on this RFC today since the minimum period of two weeks has now passed. Can someone with the right wiki powers/responsibilities start a vote and announce the [VOTE] on the mailing list? Thank you, ~Hannes

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-07-31 Thread Solar Designer
On Mon, Aug 01, 2011 at 02:54:29AM +0400, Solar Designer wrote: > On Mon, Aug 01, 2011 at 02:33:27AM +0400, Solar Designer wrote: > > On Sun, Jul 31, 2011 at 02:43:12PM -0700, Stas Malyshev wrote: > > > The change that introduced this problem is: > > > http://svn.php.net/viewvc/php/php-src/branches

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-07-31 Thread Stas Malyshev
Hi! On 7/31/11 3:33 PM, Solar Designer wrote: Now that I look at this, I think there are more problems around this place in the code: I just fixed the immediate problem, but giving a second look to this code I don't really understand why there should be NULL termination at all - we know the

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-07-31 Thread Solar Designer
On Mon, Aug 01, 2011 at 02:33:27AM +0400, Solar Designer wrote: > On Sun, Jul 31, 2011 at 02:43:12PM -0700, Stas Malyshev wrote: > > The change that introduced this problem is: > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/standard/crypt_sha256.c?r1=300427&r2=312952 > > Now that I

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-07-31 Thread Solar Designer
Hi Stas, Pierre - On Sun, Jul 31, 2011 at 02:43:12PM -0700, Stas Malyshev wrote: > On 7/19/11 4:44 PM, Solar Designer wrote: > >That is, the salts are truncated. There's a relevant recent change in > >crypt.c involving the line: > > > > salt_in_len = MIN(PHP_MAX_SALT_LEN, salt_in_len)

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-07-31 Thread Stas Malyshev
Hi! On 7/19/11 4:44 PM, Solar Designer wrote: Hi, These tests fail in trunk on my x86_64 build: crypt_sha256.phpt crypt_variation1.phpt The differences are like this: Expected:<$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5> Got<$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNtQZWE2C

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
applied :) Thanks again! On Sun, Jul 31, 2011 at 10:05 PM, Solar Designer wrote: > On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote: >> It looks like your original patch did not change anything in crypt.c > > That's correct.  I overlooked the need to modify crypt.c initially. > I only

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote: > It looks like your original patch did not change anything in crypt.c That's correct. I overlooked the need to modify crypt.c initially. I only got to that when adding the extra tests, at which time I also found the incorrect check in

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
On Sun, Jul 31, 2011 at 8:20 PM, Solar Designer wrote: > Pierre, > > Thanks for the prompt response. > > On Sun, Jul 31, 2011 at 12:12:48PM +0200, Pierre Joye wrote: >> On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: >> > http://news.php.net/php.internals/54098 >> > >> > at least the cryp

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
Pierre, Thanks for the prompt response. On Sun, Jul 31, 2011 at 12:12:48PM +0200, Pierre Joye wrote: > On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: > > http://news.php.net/php.internals/54098 > > > > at least the crypt.c bugfix is a must to apply before releasing 5.3.7 > > and 5.4.0.

[PHP-DEV] SVN Account Request: zuzu

2011-07-31 Thread VIVEK NARANG
I would like to invest my time, developing the PHP runtime. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Pierre Joye
hi, On Sun, Jul 31, 2011 at 10:31 AM, Solar Designer wrote: > Hi, > > Please apply the patches from: > > http://news.php.net/php.internals/54098 > > at least the crypt.c bugfix is a must to apply before releasing 5.3.7 > and 5.4.0. The patches are applied already, they are in 5.3.7RC4 and should

Re: [PHP-DEV] [PATCH] crypt_blowfish 1.2

2011-07-31 Thread Solar Designer
Hi, Please apply the patches from: http://news.php.net/php.internals/54098 at least the crypt.c bugfix is a must to apply before releasing 5.3.7 and 5.4.0. On Wed, Jul 20, 2011 at 03:37:14AM +0400, Solar Designer wrote: ... > Anyway, attached are patches adding the tests from crypt_blowfish 1.2

Re: [PHP-DEV] Can I use strings with some unicode characters as array keys?

2011-07-31 Thread Lars Schultz
Hi Andre, You could've just tried it yourself;) $list = array( 'a'=>'string key', utf8_encode('ä')=>'unicode key', //will be treated as an ascii-string 10=>'int key', 2.2=>'float key', //will be cast to an int(2) null=>'null key', //will be cast to a string(0) "" true=>'boolean key', //will be c