Re: [PHP-DEV] new gcov.php.net machine is up

2011-07-24 Thread Gwynne Raskind
On this subject, I've been looking into what produces the largest warnings spam with a decent set of warnings turned on, and I'd like to recommend this patch. I can't commit it myself (I don't have Zend karma), nor would I care to without getting some opinion on it. The patch is against 5.4, but sh

[PHP-DEV] Consider the use of rawurldecode() on $_GET and $_REQUEST instead of urldecode()

2011-07-24 Thread Tig
Current the following string (inside the quotes) "give me a + plz" should be encoded correctly to "give%20me%20a%20+%20plz" when passed as a query string. Now when the query string is presented with $_GET['x'], the result is "give me a plz". Clearly wrong. This leads to people (I'm sure I'm not

[PHP-DEV] Fwd: Bug #55214 [Com]: use of __CLASS__ within trait returns trait name not class name

2011-07-24 Thread Stefan Marr
Hi: I would like to ask for a review of the solution for the following issue. A patch is currently available at: https://bugs.php.net/patch-display.php?bug=55214&patch=__CLASS__-in-traits.002.patch&revision=1311532096 The problem is that __CLASS__ used in the body of a trait method does not behav