[PHP-DEV] Re: path for #39863 etc. in trunk?

2011-03-06 Thread Pierre Joye
It was not about a better implentation, such changes are not possible in 5.3. The goal is to avoid many code duplication and makes sure than any new code has this check in place. I can't think of any other similar patches not present in trunk. On 7 Mar 2011 08:04, "Stas Malyshev" wrote: Hi!

[PHP-DEV] Re: path for #39863 etc. in trunk?

2011-03-06 Thread Stas Malyshev
Hi! Yes, there was a discussion in progress about adding or not a input parameter for filenames to do all the checks. That's the only stopping point back then (in January afair). I will check&post again the question and proposal to see if we can get that sorted now. If there are questions abou

[PHP-DEV] Re: path for #39863 etc. in trunk?

2011-03-06 Thread Pierre Joye
hi Stas, Yes, there was a discussion in progress about adding or not a input parameter for filenames to do all the checks. That's the only stopping point back then (in January afair). I will check&post again the question and proposal to see if we can get that sorted now. Cheers, On Mon, Mar 7, 2

Re: [PHP-DEV] [patch] allow socket_[gs]et_options() to work on streams

2011-03-06 Thread Stas Malyshev
Hi! I think a better option would be a function to convert a php socket stream into a socket resource. That would avoid limiting this to socket_get_options/socket_set_options and polluting the socket ext functions prologue with these conversions. I think we already have PHP_STREAM_AS_SOCKETD,

[PHP-DEV] file streams & metadata

2011-03-06 Thread Stas Malyshev
Hi! PHP file streams provide very powerful and useful abstraction layer over the I/O-related functions. However, there's a group of functions which are excluded from this support - namely, touch(), chmod(), chown() and chgrp() - i.e., functions dealing with file metadata. This lead to librari

[PHP-DEV] path for #39863 etc. in trunk?

2011-03-06 Thread Stas Malyshev
Hi! What's the status of patch for NULL-in-filename issue for trunk? I see patch for 5.3 was made by Pierre 3.5 months ago with note "trunk will have patch later", but nothing happened as it seems. Anybody's working on it? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcr

Re: [PHP-DEV] streams problem in 5.3

2011-03-06 Thread Stas Malyshev
Hi! Can you tell what exactly you're doing? Why is there any cast in the first place? As far as I can see, the include should eventually call php_stream_open_for_zend_ex, which should give a ZEND_HANDLE_STREAM file handle that defers reading to _php_stream_read and fsize to php_zend_stream_fsiz

Re: [PHP-DEV] PDO odbc patch

2011-03-06 Thread Pierre Joye
On Sat, Mar 5, 2011 at 5:12 PM, Elizabeth M Smith wrote: > On 3/5/2011 10:48 AM, Christopher Jones wrote: >> >> >> On 3/5/11 5:58 AM, Elizabeth Smith wrote: >> >>> Attached is a patch that works for both 5.3 >>> and trunk, includes an additional test for the issue. >> >> Hi Elizabeth, >> >> Can yo