Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread James Devine
I've updated bug request #54037 to include a patch which creates HTML specific constants for HTML_PARSE_NODEFDTD and HTML_PARSE_NOIMPLIED, it also creates LIBXML_PEDANTIC and LIBXML_RECOVER constants On Thu, Feb 17, 2011 at 12:52 PM, Christian Stocker wrote: > Hi > > Looks good to me. But can you

Re: [PHP-DEV] Re: Clarification on the Enum language structure

2011-02-17 Thread Ben Schmidt
Also, I feel like it should be restricted to integral types only, and defaults to a zero-based incrementing integer. This is more in line with other programming languages that already implement enums and will present "expected behavior" for people moving over to PHP. for me that's a plain old in

Re: [PHP-DEV] Re: Clarification on the Enum language structure

2011-02-17 Thread Stas Malyshev
Hi! I think the proposal in the Wiki is just fine - enums should be simple, restricted to enumeration and be just a syntax sugar for the series of constants/defines. public function setLogLevel (Levels $logLevel) { $this->logLevel = $logLevel; } This I think is an overkill. Think about

Re: [PHP-DEV] Re: Clarification on the Enum language structure

2011-02-17 Thread Richard Quadling
On 17 February 2011 19:32, Martin Scotta wrote: > On Thu, Feb 17, 2011 at 3:01 PM, Jarrod Nettles wrote: > >> An enum is not a class. > > totally agree. an enum is a family of related constant values. > > >> It has no methods or properties and is not something that you instantiate. >> > partially

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread Christian Stocker
Hi Looks good to me. But can you add the constants from: typedef enum { HTML_PARSE_RECOVER = 1<<0, /* Relaxed parsing */ HTML_PARSE_NODEFDTD = 1<<2, /* do not default a doctype if not found */ HTML_PARSE_NOERROR = 1<<5, /* suppress error reports */ HTML_PARSE_NOWARNING= 1<<6, /*

Re: [PHP-DEV] Re: Clarification on the Enum language structure

2011-02-17 Thread Martin Scotta
On Thu, Feb 17, 2011 at 3:01 PM, Jarrod Nettles wrote: > An enum is not a class. totally agree. an enum is a family of related constant values. > It has no methods or properties and is not something that you instantiate. > partially agree, you cannot instantiate nor destruct a constant. it's a

RE: [PHP-DEV] Re: Clarification on the Enum language structure

2011-02-17 Thread Jarrod Nettles
An enum is not a class. It has no methods or properties and is not something that you instantiate. Also, I feel like it should be restricted to integral types only, and defaults to a zero-based incrementing integer. This is more in line with other programming languages that already implement en

Re: [PHP-DEV] PHP 5.3.6RC1 Released for Testing

2011-02-17 Thread Ferenc Kovacs
2011/2/17 Alexey Zakhlestin > > On 17.02.2011, at 16:17, Johannes Schlüter wrote: > > > The first release candidates of 5.3.6 was just released for testing and > > can be downloaded here: > > > > http://downloads.php.net/johannes/php-5.3.6RC1.tar.bz2 (md5sum: > > f78d7b47ddbfca42ebdfcdef2adfe859)

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread James Devine
Will do, thanks! On Thu, Feb 17, 2011 at 6:43 AM, Pierre Joye wrote: > hi, > > Can you make a patch against trunk instead please? > > Also pls follow the CS: > > if (foo) { > } > > Ideally attach your patch to a feature request at bugs.php.net, so we > won't loose it :) > > thanks for your work!

Re: [PHP-DEV] PHP 5.3.6RC1 Released for Testing

2011-02-17 Thread Alexey Zakhlestin
On 17.02.2011, at 16:17, Johannes Schlüter wrote: > The first release candidates of 5.3.6 was just released for testing and > can be downloaded here: > > http://downloads.php.net/johannes/php-5.3.6RC1.tar.bz2 (md5sum: > f78d7b47ddbfca42ebdfcdef2adfe859) > > The windows binaries are available at

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread Pierre Joye
hi, Can you make a patch against trunk instead please? Also pls follow the CS: if (foo) { } Ideally attach your patch to a feature request at bugs.php.net, so we won't loose it :) thanks for your work! Cheers, On Thu, Feb 17, 2011 at 12:57 AM, James Devine wrote: > I've included a patch for

[PHP-DEV] PHP 5.3.6RC1 Released for Testing

2011-02-17 Thread Johannes Schlüter
The first release candidates of 5.3.6 was just released for testing and can be downloaded here: http://downloads.php.net/johannes/php-5.3.6RC1.tar.bz2 (md5sum: f78d7b47ddbfca42ebdfcdef2adfe859) The windows binaries are available at: http://windows.php.net/qa/ This is the first step in the releas