Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-27 Thread Raphael Geissert
Derick Rethans wrote: > On Mon, 22 Feb 2010, Raphael Geissert wrote: >> >> gcc 4.4's optimiser removes the overflow check present in >> php_filter_parse_int and ZEND_HANDLE_NUMERIC (but I can't touch that part >> of the code anyway...) which prevents the overflow from being detected. > > Doesn't

Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-27 Thread Raphael Geissert
Pierre Joye wrote: > > What patch? Please do not commit anything there without first posting > to the list. There were enough breakage in this area, no need to > introduce new ones again. > Here it is: http://git.debian.org/?p=pkg- php/php.git;a=blob;f=debian/patches/filter_validate_int.patch;hb