Re: [PHP-DEV] PHP socket automatically shuts down after ? hours of idling?

2009-11-25 Thread Chris Jiang
Hi all, after running a strace program, I've found the real issue with in it. It was a mysql connection timeout causing the PHP encountering a fatal error, and shuts down the server. Thank you all again for your time and help. :D Hi what is your platform ?2. Provide a working, migth be a r

Re: [PHP-DEV] [PATCH] default session serialization

2009-11-25 Thread Stanislav Malyshev
Hi! Attached is a patch (against HEAD) which adapts the default ("php") session serializer to serialize the whole array using php_var_serialize instead of calling it once per element. This simplifies the serialization code, and allows unicode session keys, or even ascii keys containing the p

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Jess Portnoy
Hello, I agree that it [potentially] many false positives and the is even addressed in the homepage. While this is common to most static analyzers to some extent and requires going through each "find" with care while mumbling "again with this crap..", I still think it has some value. One pers

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Rasmus Lerdorf
Jess Portnoy wrote: > Hello, > > clang is indeed a great tool but since it does a lot more than just > static analysis. > For those cases where one wants source code analysis, especially > security oriented, I'd recommend flawfinder > [http://www.dwheeler.com/flawfinder]. I find that flawfinder i

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Michael Maclean
Jess Portnoy wrote: > The thing I like a lot about clang is that it can be used as a drop-in > substitute for GCC so you can actual call clang or clang++ instead of > executing gcc/g++, see here: Sure, that's how I compiled PHP with it. CC=clang ./configure --enable-all --my-usual=stuff make make

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Jess Portnoy
Hey, The thing I like a lot about clang is that it can be used as a drop-in substitute for GCC so you can actual call clang or clang++ instead of executing gcc/g++, see here: http://clang.llvm.org/get_started.html The results you published certainly look interesting :) May the source be with

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Michael Maclean
Hi, Jess Portnoy wrote: clang is indeed a great tool but since it does a lot more than just static analysis. Yeah, it looked like an interesting thing and so I decided to play with it. Incidentally, I discovered later that clang appears to compile PHP 5.3 pretty much flawlessly just now (at

Re: [PHP-DEV] [PATCH] potential null dereference in ext/ftp/ftp.c

2009-11-25 Thread Jess Portnoy
Hello, clang is indeed a great tool but since it does a lot more than just static analysis. For those cases where one wants source code analysis, especially security oriented, I'd recommend flawfinder [http://www.dwheeler.com/flawfinder]. This is a very good tool and it exists in the official

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-sr

2009-11-25 Thread Jani Taskinen
Alexey Zakhlestin wrote: On 25.11.2009, at 13:43, Antony Dovgal wrote: On 25.11.2009 13:36, Alexey Zakhlestin wrote: Wouldn't following recommendations printed in warnings help? Sure, but only for newer autoconf versions. Which means we would break autoconf 2.13 if we follow them. Is that a

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-sr

2009-11-25 Thread Derick Rethans
On Wed, 25 Nov 2009, Alexey Zakhlestin wrote: > > On 25.11.2009, at 13:43, Antony Dovgal wrote: > > > On 25.11.2009 13:36, Alexey Zakhlestin wrote: > >> Wouldn't following recommendations printed in warnings help? > > > > Sure, but only for newer autoconf versions. > > Which means we would brea

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-sr

2009-11-25 Thread Alexey Zakhlestin
On 25.11.2009, at 13:43, Antony Dovgal wrote: > On 25.11.2009 13:36, Alexey Zakhlestin wrote: >> Wouldn't following recommendations printed in warnings help? > > Sure, but only for newer autoconf versions. > Which means we would break autoconf 2.13 if we follow them. Is that a problem for trunk

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-sr

2009-11-25 Thread Antony Dovgal
On 25.11.2009 13:36, Alexey Zakhlestin wrote: > Wouldn't following recommendations printed in warnings help? Sure, but only for newer autoconf versions. Which means we would break autoconf 2.13 if we follow them. -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-sr

2009-11-25 Thread Alexey Zakhlestin
On 25.11.2009, at 12:59, Antony Dovgal wrote: > On 25.11.2009 09:57, Pierre Joye wrote: >> hi Sebastian, >> >> open a bug please :) >> >> On Wed, Nov 25, 2009 at 7:54 AM, Sebastian Bergmann >> wrote: >>> Rasmus Lerdorf wrote: rasmus Wed, 25 Nov 2009 01:30

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-s

2009-11-25 Thread Antony Dovgal
On 25.11.2009 09:57, Pierre Joye wrote: > hi Sebastian, > > open a bug please :) > > On Wed, Nov 25, 2009 at 7:54 AM, Sebastian Bergmann > wrote: >> Rasmus Lerdorf wrote: >>> rasmus Wed, 25 Nov 2009 01:30:06 + >>> >>> Revision: http://svn.php.net/viewvc?view

Re: [PHP-DEV] Re: svn: / pecl/pdo_4d/trunk/config.m4 pecl/pdo_ibm/trunk/config.m4 pecl/pdo_informix/trunk/config.m4 pecl/pdo_user/trunk/config.m4 php/php-src/branches/PHP_5_2/acinclude.m4 php/php-src

2009-11-25 Thread Rasmus Lerdorf
Sebastian Bergmann wrote: > Rasmus Lerdorf wrote: >> rasmus Wed, 25 Nov 2009 01:30:06 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=291283 >> >> Log: >> Someone strap down Jani and give him a sedative please. >> This makes our toolchain wor