Re: [PHP-DEV] Submitting performance patches

2009-10-30 Thread Arvind Srinivasan
thanks pierre. i'll do that. arvi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] SVN Account Request: abhinavgupta

2009-10-30 Thread Abhinav Gupta
I also want to take part in fixing bugs and active development of php. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] - Check configured error level before reporting E_NOTICE messages

2009-10-30 Thread Derick Rethans
On Fri, 30 Oct 2009, Arvind Srinivasan wrote: > When compiled with #ifdef ZTS, zend_error invokes pthread_get_specific. > > The performance analyzer tool indicated that zend_error was being > invoked during normal processing of requests, even though no error > messages were logged. The source of

Re: [PHP-DEV] Submitting performance patches

2009-10-30 Thread Pierre Joye
hi, I would suggest to open new requests in our bug tracker. You will reach the right people using the tracker and your patches will not get lost in the ML archive. Cheers, On Fri, Oct 30, 2009 at 11:03 AM, Arvind Srinivasan wrote: > Hi, > > For the past few months I've been working on improving

[PHP-DEV] [PATCH] - Add optional configuration directive to skip ini value processing in obj.conf

2009-10-30 Thread Arvind Srinivasan
sapi/nsapi.c includes logic - nsapi_php_ini_entries() - for populating PHP's ini table with key/value pairs from Web Server's obj.conf file. This processing is unnecessary overhead for those Web Server configuration where the obj.conf files only contain standard Web Server pblock entries which aren

[PHP-DEV] [PATCH] - Use pool_strdup instead of STRDUP in the NSAPI plugin for PHP

2009-10-30 Thread Arvind Srinivasan
The STRDUP macro in NSAPI ends up invoking pthread_get_specific each time. Since the PHP NSAPI plugin has access to the pool member of the Session variable, it can use pool_strdup instead of STRDUP. Please review the attached patch that uses pool_strdup instead of STRDUP thereby reducing the numbe

[PHP-DEV] [PATCH] - Avoid unnecessary strlen in PHP's NSAPI plugin

2009-10-30 Thread Arvind Srinivasan
Please review the attached patch which avoids an unnecessary strlen call (in the NSAPI plugin for PHP) by using php_register_variable_safe instead of php_register_variable. thanks, arvi diff -r 64f24a22f518 sapi/nsapi/nsapi.c --- a/sapi/nsapi/nsapi.cWed Aug 26 17:33:06 2009 +0530 +++ b/sap

[PHP-DEV] [PATCH] - Remove unnecessary strdup calls in the NSAPI plugin for PHP

2009-10-30 Thread Arvind Srinivasan
Please review the attached patch which removes unnecessary strdup calls in PHP's NSAPI plugin for Sun Web Server. The strings are unaltered in the SG(request_info) structure so there isn't any need to strdup them. thanks, arvi diff -r 94f02183a175 sapi/nsapi/nsapi.c --- a/sapi/nsapi/nsapi.c

[PHP-DEV] [PATCH] - Use pool_malloc/pool_free instead of MALLOC/FREE in the NSAPI plugin

2009-10-30 Thread Arvind Srinivasan
The PHP NSAPI plugin for Sun Web Server could be made more efficient by using the pool_* APIs that are exposed by Sun Web Server's NSAPI interface. The attached patch avoids invoking pthread_getspecific by using pool_malloc/pool_free instead of MALLOC/FREE. thx, arvi diff -r ababbd629dca sapi/nsa

[PHP-DEV] [PATCH] - Avoid invoking setitimer when timeouts have been disabled

2009-10-30 Thread Arvind Srinivasan
When compiled with #ifdef ZTS, the setitimer calls in zend_unset_timeout show up as a performance hotspot even when I'd set max_execution_time and max_input_time to 0 in php.ini. I've attached a patch for review that avoids invoking zend_unset_timeout (and thereby the expensive setitimer call with

[PHP-DEV] Submitting performance patches

2009-10-30 Thread Arvind Srinivasan
Hi, For the past few months I've been working on improving PHP performance primarily on CMT hardware on Solaris. I've used Sun Studio C++'s collector/analyzer to identify the performance bottlenecks in PHP when running a web-based ecommerce-site workload. Over the next few weeks I hope to post my