[PHP-DEV] [PATCH] fix for ext/phar openssl signature verification in tar archives

2009-06-23 Thread Greg Beaver
Hi, I just discovered two critical errors in tar's signature verification handling that affects archives signed with an openssl signature. The attached patch fixes these issues, and adds a test for the openssl functionality (this slipped through the cracks somehow). This is an important iss

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Greg Beaver
jvlad wrote: >> Hi, >> >> Thanks. The line in question is the first line of the generated >> (non-phar) phar.php script which is the foreach line in: >> >> > foreach (array("SPL", "Reflection", "Phar") as $ext) { >> if (!extension_loaded($ext)) { >> echo "$argv[0] requires PHP extension $ext.\n" >

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
> Hi, > > Thanks. The line in question is the first line of the generated > (non-phar) phar.php script which is the foreach line in: > > foreach (array("SPL", "Reflection", "Phar") as $ext) { > if (!extension_loaded($ext)) { > echo "$argv[0] requires PHP extension $ext.\n" > exit(1); > } > } > ?>

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Greg Beaver
jvlad wrote: >> can you run the custom gdb dumpbt so we can see which line of >> install-pear-nozlib.phar is triggering the error? >> > > (gdb) dump_bt executor_globals.current_execute_data > [0x00861cc0] ??? > /export/home/jvlad/php/php5.3-200906221030/ext/phar/phar.php:10 Hi, Thanks. The lin

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
> can you run the custom gdb dumpbt so we can see which line of > install-pear-nozlib.phar is triggering the error? > (gdb) dump_bt executor_globals.current_execute_data [0x00861cc0] ??? /export/home/jvlad/php/php5.3-200906221030/ext/phar/phar.php:10 -- PHP Internals - PHP Runtime Developmen

Re: [PHP-DEV] header_remove() issues (overly aggressive?)

2009-06-23 Thread Hannes Magnusson
2009/6/23 Gwynne Raskind : > On Jun 23, 2009, at 3:49 PM, Johannes Schlüter wrote: >>> >>> While documenting header_remove() I was experimenting a little bit.. >>> >>> If an "empty" argument is passed to the function (empty string, null, >>> false,..) the function doesn't do anything, as it checks

Re: [PHP-DEV] Call for a doc push

2009-06-23 Thread Greg Beaver
Hannes Magnusson wrote: > Just by updating the UPGRADING file you will increase the chance of > the feature actually making it to the end-user by 100%, and getting it > documented "for free" by 75%. And as we all know, 82.5% of all stats > are made up on the spot. The best part is that 60% of the

Re: [PHP-DEV] header_remove() issues (overly aggressive?)

2009-06-23 Thread Gwynne Raskind
On Jun 23, 2009, at 3:49 PM, Johannes Schlüter wrote: While documenting header_remove() I was experimenting a little bit.. If an "empty" argument is passed to the function (empty string, null, false,..) the function doesn't do anything, as it checks for ZEND_NUM_ARGS() rather then the length of

Re: [PHP-DEV] header_remove() issues (overly aggressive?)

2009-06-23 Thread Johannes Schlüter
Hi, On Tue, 2009-06-23 at 10:55 +0200, Hannes Magnusson wrote: > While documenting header_remove() I was experimenting a little bit.. > > If an "empty" argument is passed to the function (empty string, null, > false,..) the function doesn't do anything, as it checks for > ZEND_NUM_ARGS() rather t

Re: [PHP-DEV] Call for a doc push

2009-06-23 Thread Hannes Magnusson
On Fri, Jun 19, 2009 at 18:38, Rasmus Lerdorf wrote: > Personally I am going to try to make one doc commit per day for the next > little while. Thats very much appreciated. Also, if people who added new features (language level, extensions, classes, methods, functions, arguments, mode options, fo

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Greg Beaver
jvlad wrote: >> Hi, >> >> I just ran a make install of PHP 5.3 on Solaris 32-bit: >> >> cel...@t2000-010131:~/php5$ gcc -v >> Reading specs from /usr/sfw/lib/gcc/sparc-sun-solaris2.11/3.4.3/specs >> Configured with: >> /gates/sfwnv/builds/sfwnv-gate/usr/src/cmd/gcc/gcc-3.4.3/configure >> --prefix=/

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
> Hi, > > I just ran a make install of PHP 5.3 on Solaris 32-bit: > > cel...@t2000-010131:~/php5$ gcc -v > Reading specs from /usr/sfw/lib/gcc/sparc-sun-solaris2.11/3.4.3/specs > Configured with: > /gates/sfwnv/builds/sfwnv-gate/usr/src/cmd/gcc/gcc-3.4.3/configure > --prefix=/usr/sfw --with-as=/usr

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Greg Beaver
jvlad wrote: Generating phar.php *** Error code 138 make: Fatal error: Command failed for target `ext/phar/phar.php' >>> next run of "make install" produces: >>> >>> $ make install >>> Generating phar.phar >>> make: *** [ext/phar/phar.phar] Bus Error (core dumped) >> System info

[PHP-DEV] Re: cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_result.c

2009-06-23 Thread David Soria Parra
On 2009-06-23, "David Soria Parra" wrote: > dsp Tue Jun 23 14:15:28 2009 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/mysqlnd mysqlnd_result.c > Log: > MFH: Fix bug #48644 mysqlnd does not compile with > '--enable-mysqlnd-threading' > > > h

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
>Or it could be possibly fixed by including , like >"win32/php_stdin.h" is included on Windows thrus no compilation error >here. Let me know if the following patch fixes your problem: > >Index: php_spl.h >=== >RCS file: /repository/php

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Kalle Sommer Nielsen
Hi 2009/6/23 jvlad : > Now the problem is: > > > /bin/sh > /home/jvlad/php/php5.3-200906221030/libtool --silent --preserve-dup-deps > --mode=compile > gcc  -Iext/phar/ -I/home/jvlad/php/php5.3-200906221030/ext/phar/ > -DPHP_ATOM_INC >  -I/home/jvlad/php/php5.3-200906221030/include > -I/home/jvl

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
Further investigation shown that compiler takes about 1GB(!) of memory when it compiles php5.3-200906221030/ext/fileinfo/libmagic/apprentice.c On some systems this amount of memory is not available and may lead to errors such as hangs or crashes. Is it a known pro

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread Rasmus Lerdorf
jvlad wrote: >>> Further investigation shown that compiler takes about 1GB(!) of memory >>> when >>> it compiles php5.3-200906221030/ext/fileinfo/libmagic/apprentice.c >>> On some systems this amount of memory is not available and may lead to >>> errors such as hangs or crashes. >>> >>> Is it a kn

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
>> Further investigation shown that compiler takes about 1GB(!) of memory >> when >> it compiles php5.3-200906221030/ext/fileinfo/libmagic/apprentice.c >> On some systems this amount of memory is not available and may lead to >> errors such as hangs or crashes. >> >> Is it a known problem? >> Is t

Re: [PHP-DEV] Re: 5.3.0 stable release

2009-06-23 Thread jvlad
>>> Generating phar.php >>> *** Error code 138 >>> make: Fatal error: Command failed for target `ext/phar/phar.php' >>> >> >> next run of "make install" produces: >> >> $ make install >> Generating phar.phar >> make: *** [ext/phar/phar.phar] Bus Error (core dumped) > > System information, compiler,

[PHP-DEV] header_remove() issues (overly aggressive?)

2009-06-23 Thread Hannes Magnusson
Hi all While documenting header_remove() I was experimenting a little bit.. If an "empty" argument is passed to the function (empty string, null, false,..) the function doesn't do anything, as it checks for ZEND_NUM_ARGS() rather then the length of string.. thats a doc issue or bug? Second, it r