Re: [PHP-DEV] Re: Why does $_REQUEST exist?

2009-05-14 Thread Michael Shadle
I think this strikes a good balance between backward compatibility... I would hope though the code for it is very simple, to not add overhead to PHP. Basically in PHP the pseudocode equivalent would be if(ini_get('reigster_request') == true) { $_REQUEST = array_merge($_GET, $_POST, $_COOKIE, $_

Re: [PHP-DEV] Re: Why does $_REQUEST exist?

2009-05-14 Thread Patrick ALLAERT
2009/5/15 Michael Shadle > > On Thu, May 14, 2009 at 3:03 PM, Nathan Rixham wrote: > > > bc? all the reasoning in the world won't justify it to 1 million businesses > > running php 4 code which is reliant on $_REQUEST behind the scenes. > > > > although it would generate a tonne of freelance work

Re: [PHP-DEV] Segfault while looping through hash table

2009-05-14 Thread Moriyoshi Koizumi
On Fri, May 15, 2009 at 12:31 PM, Farley Knight wrote: > zend_hash_internal_pointer_reset(Z_ARRVAL(zhash)); > > printf("This hash table has %d entries\n", > zend_hash_num_elements(Z_ARRVAL(zhash))); > > int current = 0; > > while (zend_hash_get_current_data(Z_ARRVAL(zhash), (void**)&value) >

[PHP-DEV] Segfault while looping through hash table

2009-05-14 Thread Farley Knight
Hi all, I'm having some issues with some custom embedding of the PHP sapi. I'm trying to call PHP from Ruby and I'd like to be able to pass data back and forth freely, but I'm running into segfaults. It works well enough for small values, but for some large values, it crashes on me. Currently my m

[PHP-DEV] Re: Why does $_REQUEST exist?

2009-05-14 Thread Michael Shadle
On Thu, May 14, 2009 at 3:03 PM, Nathan Rixham wrote: > bc? all the reasoning in the world won't justify it to 1 million businesses > running php 4 code which is reliant on $_REQUEST behind the scenes. > > although it would generate a tonne of freelance work :p that code has to change for 5.3 or

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-05-14 Thread Moriyoshi Koizumi
While I am stil wondering why we could not stop this kind of mess before the release, we should also revert the default for 5.3. There's no point making the behavior different between releases. Moriyoshi On Fri, May 15, 2009 at 5:10 AM, Andrei Zmievski wrote: > Ilia Alshanetsky wrote: >> >> Andr

[PHP-DEV] Re: [PATCH] mysqli #35203 / #48065 Eliminate special case for calling procedures in mysqli

2009-05-14 Thread Michael G Schwern
Ping? There's a fully formed patch here, with tests, to fix a mysqli bug. I haven't gotten any feedback. Here's the original message with the patch. http://news.php.net/php.internals/43773 Michael G Schwern wrote: > This is a patch against 5.2.9 to fix mysqli::query so a user can call stored >

[PHP-DEV] Re: Why does $_REQUEST exist?

2009-05-14 Thread Nathan Rixham
Michael Shadle wrote: To me, it basically creates some laziness and reintroduces a vector on the register_globals issue. I've been using $_GET $_POST $_COOKIE $_SESSION $_SERVER etc. since they were introduced, and have never had any problems. Was there a reasoning behind making a variable that

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Stanislav Malyshev
Hi! We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sense to do one more 5.2 release before 5.3 is out and 5.2 can be discontinued. I would like to ro

Re: [PHP-DEV] Request decoding in PHP 6 [patch]

2009-05-14 Thread Andrei Zmievski
Jani Taskinen wrote: This is a good idea. However, we still have the issue of extensions needing some data from the request before $_POST or $_GET are ever mentioned in the script, since the decoding is done only at that time. You just need to call zend_is_auto_global() to trigger the init.

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Andrei Zmievski
Not yet. It's a simple declaration change for json_encode_r(), but json_decode() doesn't have json_decode_r(), so we'd need to create it from the guts of json_decode(). -Andrei Ilia Alshanetsky wrote: If we are simply changing the declaration that should be fine, is there a patch available for

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-05-14 Thread Andrei Zmievski
Ilia Alshanetsky wrote: Andrei, I think Moriyoshi has a point here there are several reports by people who are affected by this, I think it makes sense to leave the introduced functionality as is in 5.3/6, but for PHP 5.2 it probably should be rolled back. Fine. Our sorting/comparison is pr

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Ilia Alshanetsky
If we are simply changing the declaration that should be fine, is there a patch available for review? Ilia Alshanetsky On 14-May-09, at 4:04 PM, Pierre Joye wrote: hi Ilia, On Thu, May 14, 2009 at 8:54 PM, Andrei Zmievski > wrote: Jani Taskinen wrote: It's still new stuff. And we nee

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Andrei Zmievski
Ilia Alshanetsky wrote: Andrei, There is no question about functionality being useful for some people. But what is the point of different branches if we put whatever we want into each branch? We may as well stick to one branch and commit features, bug fixes, etc... into it. I would fully ag

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Pierre Joye
hi Ilia, On Thu, May 14, 2009 at 8:54 PM, Andrei Zmievski wrote: > Jani Taskinen wrote: >> >> It's still new stuff. And we need more things in 5.3/6 to make them more >> interesting to general populus too. ;) > > Great, so I'll just end up copying almost all of ext/json code into > pecl/memcached

Re: [PHP-DEV] Request decoding in PHP 6 [patch]

2009-05-14 Thread Jani Taskinen
Andrei Zmievski kirjoitti: Ilia Alshanetsky wrote: Andrei, For you point #7 regarding the session extension. Perhaps we should make a simple API allowing extensions to register callbacks to execute on input data. Once request encoding is set, the callbacks can be ran for GPC input allow exte

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Lester Caine
Hannes Magnusson wrote: On Thu, May 14, 2009 at 18:45, Lester Caine wrote: Ilia Alshanetsky wrote: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sens

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/iconv iconv.c

2009-05-14 Thread Ilia Alshanetsky
Should be fine Ilia Alshanetsky On 14-May-09, at 3:14 PM, Moriyoshi Koizumi wrote: Ilia, do you still see any problem merging this to 5.2? Moriyoshi On Sat, Apr 11, 2009 at 6:16 PM, Hannes Magnusson wrote: Ilia? I guess the chances of getting this merged Moriyoshi will increase by 100%

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/iconv iconv.c

2009-05-14 Thread Moriyoshi Koizumi
Ilia, do you still see any problem merging this to 5.2? Moriyoshi On Sat, Apr 11, 2009 at 6:16 PM, Hannes Magnusson wrote: > Ilia? > > I guess the chances of getting this merged Moriyoshi will increase by > 100% if you have a testcase.. > > -Hannes > > On Tue, Mar 17, 2009 at 07:31, Moriyoshi Ko

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Ilia Alshanetsky
Andrei, There is no question about functionality being useful for some people. But what is the point of different branches if we put whatever we want into each branch? We may as well stick to one branch and commit features, bug fixes, etc... into it. Ilia Alshanetsky On 14-May-09, at 2:5

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-05-14 Thread Ilia Alshanetsky
Andrei, I think Moriyoshi has a point here there are several reports by people who are affected by this, I think it makes sense to leave the introduced functionality as is in 5.3/6, but for PHP 5.2 it probably should be rolled back. Ilia Alshanetsky On 14-May-09, at 2:21 PM, Moriyoshi K

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Ilia Alshanetsky
Maybe only allow people who ran make test and submitted the results during the RC phase to submit bugs, eh? ;-) Ilia Alshanetsky On 14-May-09, at 2:49 PM, Jani Taskinen wrote: Ilia Alshanetsky kirjoitti: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making ver

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Andrei Zmievski
Jani Taskinen wrote: It's still new stuff. And we need more things in 5.3/6 to make them more interesting to general populus too. ;) Great, so I'll just end up copying almost all of ext/json code into pecl/memcached then. Hooray for loose coupling. -Andrei -- PHP Internals - PHP Runtime Dev

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Jani Taskinen
Ilia Alshanetsky kirjoitti: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sense to do one more 5.2 release before 5.3 is out and 5.2 can be discontinu

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Jani Taskinen
It's still new stuff. And we need more things in 5.3/6 to make them more interesting to general populus too. ;) --Jani Andrei Zmievski kirjoitti: It doesn't impact anything though, does it? And it would really help for implementing json-based serializers (such as for memcached). -Andrei I

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-05-14 Thread Jani Taskinen
Andrei, I would also like to get this reverted (in _all_ branches!) as it really is huge WTF and another BC breakage, totally unnecessary as such. --Jani Moriyoshi Koizumi kirjoitti: Is there any chance of revisiting this issue? I mean, to change the default back to SORT_STRING. We now have

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Andrei Zmievski
It doesn't impact anything though, does it? And it would really help for implementing json-based serializers (such as for memcached). -Andrei Ilia Alshanetsky wrote: This is a new feature, so it would be more appropriate for 5.3/6 more so then for 5.2 IMHO. Ilia Alshanetsky On 14-May-09,

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS configure.in /main php_version.h

2009-05-14 Thread Moriyoshi Koizumi
Is there any chance of revisiting this issue? I mean, to change the default back to SORT_STRING. We now have a couple more reports regarding this: http://bugs.php.net/47370#c147594 http://bugs.php.net/48115 Regards, Moriyoshi On Fri, Feb 27, 2009 at 8:30 AM, Ilia Alshanetsky wrote: > Moriyoshi,

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Ilia Alshanetsky
This is a new feature, so it would be more appropriate for 5.3/6 more so then for 5.2 IMHO. Ilia Alshanetsky On 14-May-09, at 1:39 PM, Andrei Zmievski wrote: Ilia Alshanetsky wrote: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I thi

Re: [PHP-DEV] How to contribute for PHP Internals

2009-05-14 Thread Christopher Jones
David Coallier wrote: 2009/5/14 Sahid Ferdjaoui : Hello Internals, I want to contribute for PHP Internal, but i don't know how to do it. I am ready to give approximately 6 to 12 hours per week for PHP. i have checked a wiki, but i don't see a "get involved" section and i do not know how to

Re: [PHP-DEV] How to contribute for PHP Internals

2009-05-14 Thread Sahid Ferdjaoui
Hello David, I will follow your advice now :) Thanks ! -- ~/sahid http://sahid.funraill.org On Thu, May 14, 2009 at 6:16 PM, David Coallier wrote: > 2009/5/14 Sahid Ferdjaoui : >> Hello Internals, >> >> I want to contribute for PHP Internal, >> but i don't know how to do it. >> >> I am ready

Re: [PHP-DEV] Request decoding in PHP 6 [patch]

2009-05-14 Thread Andrei Zmievski
Ilia Alshanetsky wrote: Andrei, For you point #7 regarding the session extension. Perhaps we should make a simple API allowing extensions to register callbacks to execute on input data. Once request encoding is set, the callbacks can be ran for GPC input allow extensions (not just session) to

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Andrei Zmievski
Ilia Alshanetsky wrote: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sense to do one more 5.2 release before 5.3 is out and 5.2 can be discontinued.

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Guilherme Blanco
IMHO, 5.2 should be stopped as soon as 5.3.0 is released. On Thu, May 14, 2009 at 2:09 PM, Michael Shadle wrote: > On Thu, May 14, 2009 at 10:05 AM, Pierre Joye wrote: >> Hi, >> >> On Thu, May 14, 2009 at 6:21 PM, Ilia Alshanetsky wrote: >>> We have a fair number of fixes in the 5.2 branch alre

Re: [PHP-DEV] Request decoding in PHP 6 [patch]

2009-05-14 Thread Ilia Alshanetsky
Andrei, For you point #7 regarding the session extension. Perhaps we should make a simple API allowing extensions to register callbacks to execute on input data. Once request encoding is set, the callbacks can be ran for GPC input allow extensions (not just session) to do their input proc

[PHP-DEV] Why does $_REQUEST exist?

2009-05-14 Thread Michael Shadle
To me, it basically creates some laziness and reintroduces a vector on the register_globals issue. I've been using $_GET $_POST $_COOKIE $_SESSION $_SERVER etc. since they were introduced, and have never had any problems. Was there a reasoning behind making a variable that essentially glues them a

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Michael Shadle
On Thu, May 14, 2009 at 10:05 AM, Pierre Joye wrote: > Hi, > > On Thu, May 14, 2009 at 6:21 PM, Ilia Alshanetsky wrote: >> We have a fair number of fixes in the 5.2 branch already and while 5.3 is >> making very good progress I think it is still ways off in terms of final >> release and stabiliza

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Pierre Joye
Hi, On Thu, May 14, 2009 at 6:21 PM, Ilia Alshanetsky wrote: > We have a fair number of fixes in the 5.2 branch already and while 5.3 is > making very good progress I think it is still ways off in terms of final > release and stabilization. I think it makes sense to do one more 5.2 release > befo

[PHP-DEV] Request decoding in PHP 6 [patch]

2009-05-14 Thread Andrei Zmievski
Request decoding is one of a few remaining pieces of the Unicode puzzle. The proposed solution was outlined in a blog post [1] I wrote a while back. There has been no movement on this front pretty much since then, but now that 5.3 is wrapping up I want to put some momentum behind PHP 6. Towards

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Hannes Magnusson
On Thu, May 14, 2009 at 18:45, Lester Caine wrote: > Ilia Alshanetsky wrote: >> >> We have a fair number of fixes in the 5.2 branch already and while 5.3 is >> making very good progress I think it is still ways off in terms of final >> release and stabilization. I think it makes sense to do one mo

Re: [PHP-DEV] PHP 5.2.10

2009-05-14 Thread Lester Caine
Ilia Alshanetsky wrote: We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sense to do one more 5.2 release before 5.3 is out and 5.2 can be discontinued.

[PHP-DEV] PHP 5.2.10

2009-05-14 Thread Ilia Alshanetsky
We have a fair number of fixes in the 5.2 branch already and while 5.3 is making very good progress I think it is still ways off in terms of final release and stabilization. I think it makes sense to do one more 5.2 release before 5.3 is out and 5.2 can be discontinued. I would like to roll

[PHP-DEV] Re: Fix for bug #45540 not in PHP_5_2

2009-05-14 Thread Arnaud Le Blanc
Hi, On Thu, 2009-05-14 at 17:14 +0300, Jani Taskinen wrote: > Hi, > > Why wasn't this fix merged to PHP_5_2? It's clearly a bug and it really > should > be fixed in the stable branch as well.. The fix changes a parameter of php_stream_url_wrap_http_ex(), I guess that I thought that it was unsu

Re: [PHP-DEV] How to contribute for PHP Internals

2009-05-14 Thread David Coallier
2009/5/14 Sahid Ferdjaoui : > Hello Internals, > > I want to contribute for PHP Internal, > but i don't know how to do it. > > I am ready to give approximately 6 to 12 hours per week for PHP. > > i have checked a wiki, > but i don't see a "get involved" section and i do not know how to start :) >

[PHP-DEV] Fix for bug #45540 not in PHP_5_2

2009-05-14 Thread Jani Taskinen
Hi, Why wasn't this fix merged to PHP_5_2? It's clearly a bug and it really should be fixed in the stable branch as well.. --Jani -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] Bug #48256 readline crash

2009-05-14 Thread Jani Taskinen
Tim Starling kirjoitti: The readline extension links both libreadline and libhistory. This is unnecessary, and inspection of the readline example programs since version 2.0 implies that it has always been unnecessary. Both libraries include history.o, so linking to both gives you two copies of th

[PHP-DEV] Win32 snapshot sha1() differences.

2009-05-14 Thread Richard Quadling
Hi. Just checking out the latest NTS VC9 Win32 snapshots and the sha1()'s are different. php-5.3-nts-VC9-x86 : 2009-May-14 11:00:00 Failed Is b406e5605d5c222b0d12051cfdac6ad1b7b0ea5c php-5.3-nts-VC9-x86 : 2009-May-14 11:00:00 Failed Is 195e1358973fe96118dcb569921eff4ad121d82c The oth

[PHP-DEV] How to contribute for PHP Internals

2009-05-14 Thread Sahid Ferdjaoui
Hello Internals, I want to contribute for PHP Internal, but i don't know how to do it. I am ready to give approximately 6 to 12 hours per week for PHP. i have checked a wiki, but i don't see a "get involved" section and i do not know how to start :) about me : I'm french, i have 24 years, I