[PHP-DEV] 5.3 commits, build fixes only please.

2009-01-27 Thread Pierre Joye
hi, As a little reminder from Lukas last post about b1: PHP_5_3 is open to build fix commits only. Please try to follow this little rule until we are done with the release. It will avoid us the pain to fix last minute breakage before the release. Thanks for your understanding, Cheers, -- Pierre

[PHP-DEV] PHP_5_3 missed merge from PHP_5_2 for write_func callback

2009-01-27 Thread shire
I came across a problem in PHP_5_3 and HEAD because I was using a feature added in PHP_5_2. It doesn't look like it was merged to HEAD to me, and then due to a merge from HEAD->PHP_5_3 it removed the changes made in PHP_5_2. This was for the write_func call back in print_zval_r_ex. Original

Re: [PHP-DEV] substr passing null...

2009-01-27 Thread Nathanael D. Noblet
Johannes Schlüter wrote: I know Ilia recently fixed a few functions that didn't ignore null parameters, but it doesn't appear that substr() was one of them. I guess that's part of the zend_parse_parameters changes. As we now use the "s" modifier for instance which might better be a "s!". We sho

Re: [PHP-DEV] substr passing null...

2009-01-27 Thread Johannes Schlüter
Hi, On Mon, 2009-01-26 at 17:05 -0800, Christopher Jones wrote: > > Nathanael D. Noblet wrote: > > Hello, > > I just have a question, often there are 'optional' parameters to > > functions, I've always thought that most of the time I could pass null > > to these if I wanted to leave one emp