Re: [PHP-DEV] PHP 5.2.7 + magic_quotes_gpc broken

2008-12-06 Thread Scott MacVicar
On 7 Dec 2008, at 04:24, Cristian Rodríguez wrote: Scott MacVicar escribió: Since this is a relative serious issue from a security stand point if people rely on it being enabled and a potential data loss for those trying to undo it, I'd like to see a release packaged asap. Please dont releas

Re: [PHP-DEV] PHP 5.2.7 + magic_quotes_gpc broken

2008-12-06 Thread Cristian Rodríguez
Scott MacVicar escribió: > Since this is a relative serious issue from a security stand point if > people rely on it being enabled and a potential data loss for those > trying to undo it, I'd like to see a release packaged asap. Please dont release a new package, but a new php version (5.2.8 or 5

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
On Sat, Dec 6, 2008 at 22:52, Lars Strojny <[EMAIL PROTECTED]> wrote: > Alright, than I would appreciate a few real world use cases. Ok one immediate use case I can think of: http://pear.php.net/package/Numbers_Words In brazilian portuguese we write numbers like that: 1023 => mil e vinte e tres

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Lars Strojny
Hi Igor, Am Samstag, den 06.12.2008, 22:38 -0200 schrieb Igor Feghali: > On Sat, Dec 6, 2008 at 21:07, Lars Strojny <[EMAIL PROTECTED]> wrote: [...] > nope. I just think its something too "simple", too "obvious" and too > "frequent" so it deserves the love of php internals. Having to call > array_

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
On Sat, Dec 6, 2008 at 21:07, Lars Strojny <[EMAIL PROTECTED]> wrote: > enough. You ran into a situation where this became a bottleneck in your > code? nope. I just think its something too "simple", too "obvious" and too "frequent" so it deserves the love of php internals. Having to call array_fil

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Lars Strojny
Hi Igor, thanks for the patch, I think it is an idea worth considering. Except that the proposed solution with executing array_filter() might be enough. You ran into a situation where this became a bottleneck in your code? Am Samstag, den 06.12.2008, 00:21 -0200 schrieb Igor Feghali: > Hello Ther

[PHP-DEV] PHP 5.2.7 + magic_quotes_gpc broken

2008-12-06 Thread Scott MacVicar
Hey, There have been several bug reports about magic_quotes_gpc being broken, at the moment in 5.2.7 the escaping is not performed even when enabled. So any applications that attempt to undo the work of magic_quotes_gpc will end up with problems. I've backed out the bug that broke this #4

[PHP-DEV] Re: Implode() FR and Patch

2008-12-06 Thread Lorenzo Alberton
Hi Igor, I would like to propose a third argument to implode(), named skip_empty, that will cause empty elements to be ignored when generating the implode string. By empty I mean everything that converts to an empty string such as '', false, null, etc. what about applying array_filter() to the

Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"

2008-12-06 Thread Benjamin Schwarze
I dont understand your comment clearly. Have you tested the current official code or my patch? marius popa schrieb: On Fri, Nov 28, 2008 at 5:56 PM, Benjamin Schwarze <[EMAIL PROTECTED]> wrote: There is already a bug report: http://bugs.php.net/42089 I saw that someone commented to the bug ,

[PHP-DEV] Re: Implode() FR and Patch

2008-12-06 Thread Igor Feghali
Please see attached a new patch that fixes the problem with delimiters bigger than one char (that's what happens when you code after midnight). Also, as suggested by Hannes, skip_empty is now being parsed as zend boolean (b) instead of zval (Z). Regards, Igor Feghali. Index: ext/standard/php_strin

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
I'd appreciate it*

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
Dear Igor, in local tests, here on my server, the performance was, every time I did it, at least 0.02 Second up to 0.1 Second faster than the origin. I'd appreciate, if this feature got included into the next build. Thanks, -- (c) Kenan Sulayman Freelance Designer and Programmer Life's Live Poet

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
Hello Kenan, Thank you for your feedback. On Sat, Dec 6, 2008 at 07:41, Kenan R Sulayman <[EMAIL PROTECTED]> wrote: > A question: hasn't the new one got a better performance ? According to my tests I would say they perform are equal. Please let me know if you did any deeper tests. PS: on string

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
Dear Igor, that's a really great feature! A question: hasn't the new one got a better performance ? Thanks, -- (c) Kenan Sulayman Freelance Designer and Programmer Life's Live Poetry http://MyJurnal.tk/