Re: [PHP-DEV] ReflectionProperty::setValue() and ReflectionProperty::setAccessible()

2008-11-29 Thread Sebastian Bergmann
Derick Rethans schrieb: > We shouldn't really modify test cases though, but just add new ones. I only modified the existing test case because it contained dead code and looked a bit confusing to me when I first read it. > Other than that it looks ok, and yes, I simply forgot about this when >

Re: [PHP-DEV] ReflectionProperty::setValue() and ReflectionProperty::setAccessible()

2008-11-29 Thread Derick Rethans
On Sat, 29 Nov 2008, Sebastian Bergmann wrote: > Sebastian Bergmann schrieb: > > Currently ReflectionProperty::setValue() ignores the setting made by > > ReflectionProperty::setAccessible(). Is this intentional or was it just > > forgotten to handle ref->ignore_visibility in setValue()? > > See

Re: [PHP-DEV] ReflectionProperty::setValue() and ReflectionProperty::setAccessible()

2008-11-29 Thread Sebastian Bergmann
Sebastian Bergmann schrieb: > Currently ReflectionProperty::setValue() ignores the setting made by > ReflectionProperty::setAccessible(). Is this intentional or was it just > forgotten to handle ref->ignore_visibility in setValue()? See http://bugs.php.net/bug.php?id=46718 for a patch that implem

Re: [PHP-DEV] apha3

2008-11-29 Thread Lukas Kahwe Smith
On 29.11.2008, at 03:02, Christian Seiler wrote: PHP 5.3, ZE2 FPU precision: http://www.christian-seiler.de/temp/php/2008-11-28-fpu+rounding/php53-fpu.patch PHP 5.3, round() behaviour: http://www.christian-seiler.de/temp/php/2008-11-28-fpu+rounding/php53-round.patch PHP 6, ZE2 FPU precision:

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-29 Thread Uwe Schindler
I implemented and tested now version a), works fine! header_remove() now only removes headers set/modified by PHP. I tested the case to remove *all* headers by cleaning the server's header hash table, but this breaks server hard: Best example: Removing the "Transfer-encoding: chunked" header, th

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-29 Thread Uwe Schindler
Hallo Arnaud, > I believe that Apache does sets its headers just before sending them, so > when > PHP deletes all headers in Apache's hashtable this does not removes > "Server", > "Date", etc. If this is not the case for NSAPI, solution a) seems good, > but > also allows to remove "Date" by settin

[PHP-DEV] [PATCH] ext/curl: fix for bug #46711

2008-11-29 Thread Mark Karpeles
Hello, Added a patch and a test file to http://bugs.php.net/46711 . After extensive tests I believe this bug should be considered fixed (no more memory leak, and expected behaviour is still working). I would also like to provide more tests to libcurl and give some of my time to fix existing bugs.