Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Christian Stocker
Hi Dmitry On 8.8.2008 17:52 Uhr, Dmitry Stogov wrote: Hi, The attached patch is going to fix the problem. Works also on my OS X 10.4 box now. Thanks a lot for the effort (and if it brings a performance boost, even better :) ) chregu It implements its own realpath() function, so we won'

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! I'm not sure to like the idea. I'm not a fan of OO strictness but I'd to agree with Marcus, I do not expect a reference from an overrided How can you "not expect reference"? I.e. which code that worked previously wouldn't work now? __get. There is also the problem with internal classes

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Pierre Joye
hi! On Sat, Aug 9, 2008 at 1:50 AM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > >> I know that we don't like to add new magic methods, but this case >> seems to require new ones. What's about __getByRef (and its setter >> equivalent if it is also not supported yet)? > > Why would we need

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! I know that we don't like to add new magic methods, but this case seems to require new ones. What's about __getByRef (and its setter equivalent if it is also not supported yet)? Why would we need that? We already have perfectly good __get, which can perfectly return by-ref. The question i

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! What makes you think there won't be a problem with the reverse. The caller does not expect a reference but the calle returns one? In OOP the return Well, I don't know any case where $a = foo() would work in a substantially different way for the user if foo() returns by-ref and not by-val

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Pierre Joye
hi Stanislav , Marcus, On Sat, Aug 9, 2008 at 1:00 AM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Stanislav, > > Saturday, August 9, 2008, 12:40:34 AM, you wrote: > >> Hi! > >>> Yes, it breaks the principle. E.g. caller knows callee returns by ref - you >>> break this, as easy as that. > >>

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Marcus Boerger
Hello Stanislav, Saturday, August 9, 2008, 12:40:34 AM, you wrote: > Hi! >> Yes, it breaks the principle. E.g. caller knows callee returns by ref - you >> break this, as easy as that. > I'm sorry I think you misunderstood my proposal. I proposed allowing > overriding this: > public function __

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! Yes, it breaks the principle. E.g. caller knows callee returns by ref - you break this, as easy as that. I'm sorry I think you misunderstood my proposal. I proposed allowing overriding this: public function __get($name) with this: public function &__get($name) but not the reverse. So if

Re: [PHP-DEV] [PATCH] Closures and reflection improvements

2008-08-08 Thread Marcus Boerger
Hello Christian, Johannes, Friday, August 8, 2008, 11:48:37 PM, you wrote: > Hello Christian, > I updated your patch for 5.3 due to recent changes. It works pretty fine > for me. Care to test again, especially with your new tests? Note that test > ext/reflection/tests/closures_001.phpt does no

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Marcus Boerger
Hello Stanislav, Saturday, August 9, 2008, 12:16:29 AM, you wrote: > Hi! >> I think we may want to stick to our is-a mantra. > I'm not sure I understand what you mean here. But our principle was to > allow things that do not violate the LSP - such as adding optional > parameters, for exampl

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! I think we may want to stick to our is-a mantra. I'm not sure I understand what you mean here. But our principle was to allow things that do not violate the LSP - such as adding optional parameters, for example. I think returning by-ref can be allowed on the same principle. Is there a

Re: [PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Marcus Boerger
Hello Stanislav, I think we may want to stick to our is-a mantra. marcus Friday, August 8, 2008, 10:32:53 PM, you wrote: > Hi! > Right now, strict inheritance rules do not allow to override > public function __get($name) > with > public function & __get($name) > I think we may want to allow

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-08-08 Thread Marcus Boerger
Hello Greg, Monday, August 4, 2008, 10:37:23 PM, you wrote: > Rasmus Lerdorf wrote: >> Jani Taskinen wrote: >>> -- Changed PCRE, Reflection and SPL extensions to always be enabled. >>> (Marcus) >>> +- Changed PCRE, Reflection and SPL extensions to be always enabled. >>> (Marcus) >> >> That was

Re: [PHP-DEV] [PATCH] Closures and reflection improvements

2008-08-08 Thread Marcus Boerger
Hello Christian, I updated your patch for 5.3 due to recent changes. It works pretty fine for me. Care to test again, especially with your new tests? Note that test ext/reflection/tests/closures_001.phpt does not work for me and I have no clue why. Well, besides that obviously the closure class

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Rasmus Lerdorf
Rasmus Lerdorf wrote: Dmitry Stogov wrote: Hi, The attached patch is going to fix the problem. It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cache usage by caching intermediate results. Very nice. The intermediate caching is going to

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Rasmus Lerdorf
Dmitry Stogov wrote: Hi, The attached patch is going to fix the problem. It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cache usage by caching intermediate results. Very nice. The intermediate caching is going to drastically reduce th

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Jani Taskinen
Just semantics but I'd name the function 'tsrm_realpath[_r]' to be absolutely clear what it does. --Jani Dmitry Stogov kirjoitti: Hi, The attached patch is going to fix the problem. It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cach

[PHP-DEV] by-ref return & inheritance

2008-08-08 Thread Stanislav Malyshev
Hi! Right now, strict inheritance rules do not allow to override public function __get($name) with public function & __get($name) I think we may want to allow this (but not the reverse - overriding by-ref return with by-val should not be allowed). Since by-ref return still can be used in by-va

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /main php.h ZendEngine2 zend_execute_API.c

2008-08-08 Thread Marcus Boerger
Hello Lukas, Friday, August 8, 2008, 9:01:42 PM, you wrote: > On 08.08.2008, at 15:18, Marcus Boerger wrote: >> helly Fri Aug 8 13:18:31 2008 UTC >> >> Modified files: >> /ZendEngine2zend_execute_API.c >> /php-src/mainphp.h >> Log: >> - PHP 5.3 todo, store error handl

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h zend_API.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h php-src/main main.c php.h

2008-08-08 Thread Marcus Boerger
Hello Etienne, Friday, August 8, 2008, 9:54:49 PM, you wrote: > Hello, > On Fri, Aug 8, 2008 at 9:50 PM, Etienne Kneuss <[EMAIL PROTECTED]> wrote: >> Hello, >> >> On Fri, Aug 8, 2008 at 7:10 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: >>> helly Fri Aug 8 17:10:49 2008 UTC >>> >>> M

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /main php.h ZendEngine2 zend_execute_API.c

2008-08-08 Thread Etienne Kneuss
Hello, On Fri, Aug 8, 2008 at 9:01 PM, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > > On 08.08.2008, at 15:18, Marcus Boerger wrote: > >> helly Fri Aug 8 13:18:31 2008 UTC >> >> Modified files: >> /ZendEngine2 zend_execute_API.c >> /php-src/main php.h >> Log: >> - PHP 5.3 todo, s

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h zend_API.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h php-src/main main.c php.h

2008-08-08 Thread Hannes Magnusson
On Fri, Aug 8, 2008 at 21:54, Etienne Kneuss <[EMAIL PROTECTED]> wrote: > Forgot to mention it: there is something weird in mysqli_driver.c, I > don't know what the author's original intention was, but it looks > wrong. > c.f. FIXME I think I already filed a bug report about that some months ago,

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h zend_API.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h php-src/main main.c php.h

2008-08-08 Thread Etienne Kneuss
Hello, On Fri, Aug 8, 2008 at 9:50 PM, Etienne Kneuss <[EMAIL PROTECTED]> wrote: > Hello, > > On Fri, Aug 8, 2008 at 7:10 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> helly Fri Aug 8 17:10:49 2008 UTC >> >> Modified files: >>/php-src/main main.c php.h >>/ZendEngine2

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h zend_API.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h php-src/main main.c php.h

2008-08-08 Thread Etienne Kneuss
Hello, On Fri, Aug 8, 2008 at 7:10 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > helly Fri Aug 8 17:10:49 2008 UTC > > Modified files: >/php-src/main main.c php.h >/ZendEngine2zend.h zend_API.c zend_execute_API.c zend_vm_def.h >zend_vm_ex

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /main php.h ZendEngine2 zend_execute_API.c

2008-08-08 Thread Lukas Kahwe Smith
On 08.08.2008, at 15:18, Marcus Boerger wrote: helly Fri Aug 8 13:18:31 2008 UTC Modified files: /ZendEngine2 zend_execute_API.c /php-src/main php.h Log: - PHP 5.3 todo, store error handling mode on stack when executing internal or overloaded functions and methods. The issue

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /main php.h ZendEngine2 zend_execute_API.c

2008-08-08 Thread Lukas Kahwe Smith
On 08.08.2008, at 15:18, Marcus Boerger wrote: helly Fri Aug 8 13:18:31 2008 UTC Modified files: /ZendEngine2zend_execute_API.c /php-src/main php.h Log: - PHP 5.3 todo, store error handling mode on stack when executing internal or overloaded functions and methods. The issue

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /main php.h ZendEngine2 zend_execute_API.c

2008-08-08 Thread Lukas Kahwe Smith
On 08.08.2008, at 15:18, Marcus Boerger wrote: helly Fri Aug 8 13:18:31 2008 UTC Modified files: /ZendEngine2 zend_execute_API.c /php-src/main php.h Log: - PHP 5.3 todo, store error handling mode on stack when executing internal or overloaded functions and methods. The issue

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Dmitry Stogov
Great! :) It's mean I'm on the right way. The patch still needs additional work and testing, but I hope it'll be ready before alpha 2. Thanks. Dmitry. Arnaud Le Blanc wrote: > Hi, > > On Friday 08 August 2008 17:52:26 Dmitry Stogov wrote: >> Hi, >> >> The attached patch is going to fix the probl

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Arnaud Le Blanc
Hi, On Friday 08 August 2008 17:52:26 Dmitry Stogov wrote: > Hi, > > The attached patch is going to fix the problem. > It implements its own realpath() function, so we won't depend on system > anymore. It also improve realpath cache usage by caching intermediate > results. > > I tested it on Linux

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Dmitry Stogov
Hi Pierre, Thank you for feedback. I already noticed the missing FindClose() and several other issues. I'll send updated patch on weekend, but the sooner I get info if bug is fixed on FreeBSD the better. Thanks. Dmitry. Pierre Joye wrote: > Hi Dmitry, > > On Fri, Aug 8, 2008 at 5:52 PM, Dmitry

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Pierre Joye
Hi Dmitry, On Fri, Aug 8, 2008 at 5:52 PM, Dmitry Stogov <[EMAIL PROTECTED]> wrote: > Hi, > > The attached patch is going to fix the problem. > It implements its own realpath() function, so we won't depend on system > anymore. It also improve realpath cache usage by caching intermediate > results.

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Dmitry Stogov
Hi, The attached patch is going to fix the problem. It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cache usage by caching intermediate results. I tested it on Linux and Windows only and it seems to work without problems. It breaks one tes

Re: [PHP-DEV] PHP 4.4.9 Released!

2008-08-08 Thread Derick Rethans
On Fri, 8 Aug 2008, Rui Hirokawa wrote: > "Chris Stockton" <[EMAIL PROTECTED]> wrote: > > > fixed bug #27421 (by david at dfoerster dot de) mbstring.func_overload > > set in .htaccess becomes global > > There are a typo in NEWS of PHP 4.4.9. > #37421 should be #27421. Fixed Derick -- HEAD be

Re: [PHP-DEV] PHP 4.4.9 Released!

2008-08-08 Thread Rui Hirokawa
There are a typo in NEWS of PHP 4.4.9. #37421 should be #27421. > fixed bug #27421 (by david at dfoerster dot de) mbstring.func_overload > set in .htaccess becomes global Rui On Thu, 7 Aug 2008 14:09:47 -0700 "Chris Stockton" <[EMAIL PROTECTED]> wrote: > Hello, > > Is the link in the changelo

Re: [PHP-DEV] include bug in 5.3

2008-08-08 Thread Hannes Magnusson
On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > virtual_file_ex() assumes that realpath() returns NULL when the file does not > exists. But BSD's realpath() will not return NULL if all > components *but the last* exist. So realpath(/foo/bar) will return /foo/bar > even if