Re: [PHP-DEV] cleaning up the functions - any volunteers?

On Jun 19, 2008, at 7:06 PM, Stanislav Malyshev wrote: I have cleaned up Zend engine functions, converting them to the new API, but there are about 1000 instances throughout PHP code (especially ext/standard) which still use the old way. This way is less correct, inconsistent with the new

Re: [PHP-DEV] cleaning up the functions - any volunteers?

On Jun 19, 2008, at 7:06 PM, Stanislav Malyshev wrote: While we nearing the release of 5.3 (hopefully?), there are many functions in the PHP code which still use old parameter parsing API (zend_get_parameters_ex) instead of the new one (zend_parse_parameters). This is my first patch sub

RE: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

See below: > -Original Message- > From: Alexander Wagner [mailto:[EMAIL PROTECTED] > Sent: Friday, June 27, 2008 12:31 PM > To: internals@lists.php.net > Cc: Andi Gutmans; Dmitry Stogov; Christian Seiler; Stas Malyshev > Subject: Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

On Friday 27 June 2008, Dmitry Stogov wrote: > 1) Fixed ref/noref issues Works for me. See attached test 11. Gesundheit Wag -- For sale: baby shoes, never worn. - flash fiction by Hemingway --TEST-- Closure test: Closure calls itself --SKIPIF-- --FILE-- --EXPECT-- 3 2 1 0 --TEST-- Closure

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

On Friday 27 June 2008, Andi Gutmans wrote: > I am not sure I like the idea of explicit $this. > [..] If we ever discover this is a huge issue Implicit unoptimized $this is never going to be a "huge issue", because it is not badly broken, only sublty. My crystal ball tells me that the following i

RE: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

I am not sure I like the idea of explicit $this. Frankly, I really doubt we will have serious resource issues as a result of holding a reference to $this for too long. I think we're looking to solve a non-issue. I'd prefer to take the approach which is easier to use and cleaner from a user pers

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

Hi! I thought about use($this) too. :) I'll try to implement it in the next version of the patch. I think implicitly using $this when it's referred to is much better. $this is very special variable so it deserves special treatment. If we'd need to spare a couple of bytes for that - that's no

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

I thought about use($this) too. :) I'll try to implement it in the next version of the patch. Thanks. Dmitry. Alexander Wagner wrote: > On Friday 27 June 2008, Andi Gutmans wrote: >> I lean towards the use(...) syntax. > > Me too. > >>> * I provided a patch variant that only stores $this if $

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

> Yes, you're right. My solution for this would be: I can't get this to work, it segfaults for me now when I try to use closures. Maybe I screwed something up, this is my first Zend-Engine-hackery. As you agree that the current behaviour is kinda weird, just put the fix in the next wave of patch

Re: [PHP-DEV] [PATCH] [RFC] Closures and lambda functions in PHP

On Friday 27 June 2008, Andi Gutmans wrote: > I lean towards the use(...) syntax. Me too. > > * I provided a patch variant that only stores $this if $this is > > explicitely used inside a closure [..] > > Safest not to take shortcuts. You get yourself into trouble with things > which will s

Re: [PHP-DEV] Drop ext/mhash and add an emulation layer in ext/hash (5.3+), call for help

On Fri, 27 Jun 2008, Scott MacVicar wrote: > Pierre Joye wrote: > > On Mon, Jun 2, 2008 at 12:34 PM, Scott MacVicar <[EMAIL PROTECTED]> wrote: > > > Pierre Joye wrote: > > > > On Mon, Jun 2, 2008 at 10:21 AM, Derick Rethans <[EMAIL PROTECTED]> > > > > wrote: > > > > > On Mon, 2 Jun 2008, Pierre J