RE: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Andi Gutmans
Hi Marcus, Johannes, and all, First of all let me say that I have no conceptual problem with replacing the scanner with re2c. If it's cleaner, performs better and a better maintained piece of software (let's hope Marcus doesn't get run over) then we can move to re2c. There are a few important thi

Re: [PHP-DEV] Bug when throwing an Exception in a constructor

2008-03-03 Thread Felipe Pena
Em Seg, 2008-03-03 às 22:51 -0300, Felipe Pena escreveu: > Hello. > > > Index: Zend/zend_exceptions.c > === > RCS file: /repository/ZendEngine2/zend_exceptions.c,v > retrieving revision 1.79.2.6.2.9.2.4 > diff -u -p -r1.79.2.6.2.9.2.

Re: [PHP-DEV] Bug when throwing an Exception in a constructor

2008-03-03 Thread Felipe Pena
Hello. Index: Zend/zend_exceptions.c === RCS file: /repository/ZendEngine2/zend_exceptions.c,v retrieving revision 1.79.2.6.2.9.2.4 diff -u -p -r1.79.2.6.2.9.2.4 zend_exceptions.c --- Zend/zend_exceptions.c 21 Jan 2008 19:39:55

[PHP-DEV] Fix for #39018 (suppressing error messages)

2008-03-03 Thread Felipe Pena
Hello developers, I made a patch for the bug#39018: $x = 'test'; @$x[4] == 'a'; (@$x[4]) == 'a'; (@($x[4])) == 'a'; @($x[4]) == 'a'; $foo = 'test'; $x = @$foo[6]; Actually, all cases above shows E_NOTICE. With the patch, E_NOTICE is not showed. Patches: [5.3] http://felipe.ath.cx/diff/bug39018

[PHP-DEV] Bug when throwing an Exception in a constructor

2008-03-03 Thread Arnold Daniels
Hi, I'm running into a bug when throwing an Exception in a constructor. I sometimes get the message "Exception thrown without a stack frame in Unknown on line 0" and sometimes a message like seen below. Unfortunately I'm not a create a simple example which causes the same exception, so repor

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Pierre Joye
Hi Stan, On Mon, Mar 3, 2008 at 10:27 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > > > > intl (and related changes) is almost the only why one will upgrade to > > 5.3.x. There is no core (as in zend engine) for 95% of our users. Sorry I was not clear. I did not say that there is no

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! intl (and related changes) is almost the only why one will upgrade to 5.3.x. There is no core (as in zend engine) for 95% of our users. From NEWS: - Added and improved PHP syntax and semantics: . Added NOWDOC. (Gwynne Raskind, Stas, Dmitry) . Added "?:" operator. (Marcus) . Added sup

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! In PHP 6, not 5.3. http://wiki.pooteeweet.org/PhP53#toc3 item 2. ITYM item 1. But that's *extension*, not *engine core*. I'm of course all for having pecl/intl joined :) CVS does merging on its own when ther are no conflicts. I am talking about real merge support. As I said, since

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Pierre, Monday, March 3, 2008, 9:31:37 PM, you wrote: > Hi Marcus, > On Mon, Mar 3, 2008 at 9:16 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> Hello Stanislav, >> >> >> Monday, March 3, 2008, 8:48:38 PM, you wrote: >> >> > Hi! >> >> >> It is clearer but it is not a problem. New featu

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Pierre Joye
Hi Marcus, On Mon, Mar 3, 2008 at 9:16 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Stanislav, > > > Monday, March 3, 2008, 8:48:38 PM, you wrote: > > > Hi! > > >> It is clearer but it is not a problem. New features may introduce new > >> dependencies. Having a dependency on libicu wh

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Steph Fox
No one was considering any such move. Having pecl/intl shipped per default as symlinked into ext would be as much optional as --enable-zend-multibyte or --enable-mbstring are right now. This will be more like brining in zip to 5.2. However it is completely off-topic as it is just one possible cau

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Stanislav, Monday, March 3, 2008, 8:56:41 PM, you wrote: > Hi! >> interface but that wasn't really a good idea. So I came up with a new >> interface and all that this would break is stuff like Phar (well there is > If it breaks phar, it may break others too... Anyway, good description >

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Stanislav, Monday, March 3, 2008, 8:48:38 PM, you wrote: > Hi! >> It is clearer but it is not a problem. New features may introduce new >> dependencies. Having a dependency on libicu while we introduce intl >> and other features related to unicode or i18n. I would agree if we >> were talki

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Steph Fox
Is it clearer why I think PHP 5.x and 6 are different and why I think ICU dependency in the 5.3 core might be a problem? FWIW... I also think that bringing in ICU in 5.3 so late in the cycle - or actually at all in 5.3 - is not such a bright idea. 'so late in the cycle'? We haven't had a beta

[PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello everyone, sorry for the crosspost. But recent discussions about: '[RFC] Replace the flex-based scanner with an re2c [1] based lexer' revealed one big issue. During the development of said RFC we dropped --enable-multibyte-support and interaction between engine and ext/mbstring using declar

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Derick Rethans
On Mon, 3 Mar 2008, Stanislav Malyshev wrote: > 4. We expect people to upgrade from 5.2.x to 5.3.x without changing their > systems. > > Is it clearer why I think PHP 5.x and 6 are different and why I think ICU > dependency in the 5.3 core might be a problem? FWIW... I also think that bringing i

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Pierre Joye
On Mon, Mar 3, 2008 at 8:48 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > > > > It is clearer but it is not a problem. New features may introduce new > > dependencies. Having a dependency on libicu while we introduce intl > > and other features related to unicode or i18n. I would agr

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! interface but that wasn't really a good idea. So I came up with a new interface and all that this would break is stuff like Phar (well there is If it breaks phar, it may break others too... Anyway, good description of what was changed won't hurt. 2. PHP 5.x is same-major branch, where y

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread George Schlossnagle
On Mar 3, 2008, at 2:48 PM, Stanislav Malyshev wrote: Hi! It is clearer but it is not a problem. New features may introduce new dependencies. Having a dependency on libicu while we introduce intl and other features related to unicode or i18n. I would agree if we were talking about 5.2.x. pe

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! It is clearer but it is not a problem. New features may introduce new dependencies. Having a dependency on libicu while we introduce intl and other features related to unicode or i18n. I would agree if we were talking about 5.2.x. pecl/intl is an extension, there's no surprise that you nee

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Stanislav, Monday, March 3, 2008, 7:59:41 PM, you wrote: > Hi! >> 1) If mmap is supported, then use it >> 2) If mmap is not supported or does not work then read the whole stream >> 3) If that is not possible read char by char > Why should it read the whole stream into memory? The file cou

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Pierre Joye
Hi, On Mon, Mar 3, 2008 at 7:59 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Just curious who you were answering to... Anyway, to be clear: > 1. PHP 6 is major version with its major feature being Unicode support. > 2. PHP 5.x is same-major branch, where you are not expected to have to

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! 1) If mmap is supported, then use it 2) If mmap is not supported or does not work then read the whole stream 3) If that is not possible read char by char Why should it read the whole stream into memory? The file could be very big, maybe it would make more sense to read it is some chunks?

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Stanislav Malyshev
Hi! Since there's no documentation about zend-multibyte stuff I spent some time searching for other resources about it, but except bug reports I found nothing whee it was required. I'm sure there are some but comments like "TODO: support widechars" in the code give me the impression that it does

Re: [PHP-DEV] Protected static props redeclared as public share value across classes

2008-03-03 Thread Robin Fernandes
On 26/02/2008, Robin Fernandes <[EMAIL PROTECTED]> wrote: > > On 28/01/2008, Marcus Boerger <[EMAIL PROTECTED]> wrote: > > > > > > I checked it out in more detail and it is indeed broken as in it is > not > > > consistent > > If possible, I'd like to revive this discussion. Patch included

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Alan Knowles
a few replaces with this file should be a good testcase - probably worth testing * comments with these character in them. both /* and // * string with these characters in them. lynx -source 'http://smontagu.damowmow.com/genEncodingTest.cgi?family=windows&codepage=950' | grep test | grep -v tes

Re: [PHP-DEV] Re: PHP 5.3 Autoload+Namespaces+Functions incorret (atleast wierd) behaviour.

2008-03-03 Thread Johannes Schlüter
Hi Marcus, On Mon, 2008-03-03 at 13:27 +0100, Marcus Boerger wrote: > new namespace::class() > new namaespace::namedspace::class() > > and so on, or: > > namespace::class::functoin() > namespace::function() > > and so on. That is, when detecting braces after it and a new in front > than it is a

Re: [PHP-DEV] Re: PHP 5.3 Autoload+Namespaces+Functions incorret (atleast wierd) behaviour.

2008-03-03 Thread Marcus Boerger
Hello Johannes, Monday, March 3, 2008, 12:40:52 PM, you wrote: > Hi Fredrik, > On Fri, 2008-02-29 at 16:02 +0100, > "=?ISO-8859-1?Q?Fredrik_Holmstr=F6m?=" wrote: >> Basicly, the call is this: Demo::Functions::test(); where both Demo >> and Functions are namespaces, and test() is a function insid

[PHP-DEV] Re: PHP 5.3 Autoload+Namespaces+Functions incorret (atleast wierd) behaviour.

2008-03-03 Thread Johannes Schlüter
Hi Fredrik, On Fri, 2008-02-29 at 16:02 +0100, "=?ISO-8859-1?Q?Fredrik_Holmstr=F6m?=" wrote: > Basicly, the call is this: Demo::Functions::test(); where both Demo > and Functions are namespaces, and test() is a function inside the > Demo::Functions namespace. If you have an autoload handler here a

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Lukas Kahwe Smith
On 03.03.2008, at 00:48, Alan Knowles wrote: Can you clarify the Multibyte issues: - I presume this means that it can handle ASCII/UTF8/16 etc. but will not handle things like BIG5/GB encoding in source code - this may be a bit of an issue around here.. At first I also thought that this

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Johannes Schlüter
Hi, On Sun, 2008-03-02 at 14:47 -0800, Stanislav Malyshev wrote: > Hi! > > > be much easier, switching to re2c promises a much faster lexer. Actually, > > without any specific re2c optimizations we already get around a 20% scanner > > I think 20% faster is very cool. > However, as I understand r

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Derick, ok, for now I changed to not issue any error at all. marcus Monday, March 3, 2008, 11:28:31 AM, you wrote: > On Mon, 3 Mar 2008, Marcus Boerger wrote: >> actually you get a message (E_COMPILE_WARNING) that this is not >> supported. Maybe we could turn this into an E_NOTICE th

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Alan, be my hero then :-) Could you generate a few tests for the multibyte support so that we know how it is used right now and what we need to take care of? marcus Monday, March 3, 2008, 12:48:44 AM, you wrote: > Can you clarify the Multibyte issues: > - I presume this means that it ca

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Stanislav, Monday, March 3, 2008, 5:39:35 AM, you wrote: > Hi! >>> Were the stream support issues solved? >> >> We completely dropped multibyte support. The reason is that the way we were > I wasn't asking about multibyte (that we discuss below), but about other > streams - I think I me

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Derick Rethans
On Mon, 3 Mar 2008, Marcus Boerger wrote: > actually you get a message (E_COMPILE_WARNING) that this is not > supported. Maybe we could turn this into an E_NOTICE though. No, I don't get any warning/notice/ whatever with PHP 5.3: [EMAIL PROTECTED]:~$ php-5.3dev -derror_reporting=65535 foo

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Marcus Boerger
Hello Derick, actually you get a message (E_COMPILE_WARNING) that this is not supported. Maybe we could turn this into an E_NOTICE though. marcus Monday, March 3, 2008, 9:28:01 AM, you wrote: > On Sun, 2 Mar 2008, Marcus Boerger wrote: >> However, we had to drop multibyte support as well as

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Johannes Schlüter
Hi Derick, On Mon, 2008-03-03 at 09:28 +0100, Derick Rethans wrote: > On Sun, 2 Mar 2008, Marcus Boerger wrote: > > > However, we had to drop multibyte support as well as the encoding > > declare. > > Just wondering, why did you have to drop the "declare(encoding=...)" ? > It's just ignored in

[PHP-DEV] PHP 6 Bug Summary Report

2008-03-03 Thread internals
PHP 6 Bug Database summary - http://bugs.php.net Num Status Summary (59 total including feature requests) ===[*Configuration Issues] 42262 Open get_magic_quotes_gpc() should be there and return false ==

Re: [PHP-DEV] [RFC] Replace the flex-based scanner with an re2c [1] based lexer

2008-03-03 Thread Derick Rethans
On Sun, 2 Mar 2008, Marcus Boerger wrote: > However, we had to drop multibyte support as well as the encoding > declare. Just wondering, why did you have to drop the "declare(encoding=...)" ? It's just ignored in PHP 5.x - and it is useful to have for migrating php 5.3 apps to 6. So can you at