Antony Dovgal wrote:
> On 03/01/2007 12:35 AM, Doug Goldstein wrote:
>>> Did you really test it with non-NULL terminated strings?
>>> Don't you need to add '\0' manually?
>>
>> The test is that you run the example code from bug #38819, watch PHP
>> crash. Apply my patch and watch PHP not crash. Fai
On 03/01/2007 12:46 AM, Antony Dovgal wrote:
I removed PHP_FE(ldap_get_values) because it's a pointless function.
The point is that the patch should FIX this function, not REMOVE it.
And it's still there, but commented out (which makes not sense).
Uhm.. Ignore that, I need to sleep more.
--
On 03/01/2007 12:35 AM, Doug Goldstein wrote:
Did you really test it with non-NULL terminated strings?
Don't you need to add '\0' manually?
The test is that you run the example code from bug #38819, watch PHP
crash. Apply my patch and watch PHP not crash. Fairly simple. My backtrace
is identica
Antony Dovgal wrote:
> On 03/01/2007 12:04 AM, Doug Goldstein wrote:
>>> Wait, I thought the DEPRECATED thing fixed it (I can't test it myself
>>> as I
>>> don't use LDAP).
>>> If not, then what was it all about?
>>
>> The test case still failed for me. It also does not address the fact
>> that
>>
On 03/01/2007 12:04 AM, Doug Goldstein wrote:
Wait, I thought the DEPRECATED thing fixed it (I can't test it myself as I
don't use LDAP).
If not, then what was it all about?
The test case still failed for me. It also does not address the fact that
the usage of the PHP ldap functions is unsafe b
Antony Dovgal wrote:
> Hello.
> Thanks for sending the patch here.
>
> On 02/28/2007 11:33 PM, Doug Goldstein wrote:
>> Referencing Bug #38819 & Bug #40671
>> http://bugs.php.net/bug.php?id=38819
>> http://bugs.php.net/bug.php?id=40671
>>
>> Essentially I looked through the above mentioned bug, the
Hello.
Thanks for sending the patch here.
On 02/28/2007 11:33 PM, Doug Goldstein wrote:
Referencing Bug #38819 & Bug #40671
http://bugs.php.net/bug.php?id=38819
http://bugs.php.net/bug.php?id=40671
Essentially I looked through the above mentioned bug, the bugs opened
with OpenLDAP developers, a
Referencing Bug #38819 & Bug #40671
http://bugs.php.net/bug.php?id=38819
http://bugs.php.net/bug.php?id=40671
Essentially I looked through the above mentioned bug, the bugs opened
with OpenLDAP developers, and then reviewed ext/ldap/ldap.c and it
appears the API calls made by PHP are not necessari
Sean Coates wrote:
>> The strcat results were approximately *10 times slower* on 5.2.1 than on
>> 5.2.0.
>
> Upping the number significantly (from 20 to 2000) smooths out
> abnormalities:
>
> 5.2.0:
> strcat(2000) 5.556
>
>
> 5.2.1:
> strcat(2000) 5.628
Which I hope helps m
